Pytest causes exception Runtime "dictionary changed size during iteration" #121021

New Issue

Alexis-19 · 2024-04-24T13:49:11+02:00

Alexis-19 commented

2024-04-24 13:49:11 +02:00

System Information
Operating system: WSL 2.1.5.0 - Ubuntu 20.04.6 LTS
Graphics card: NVIDIA GeForce RTX 3070 Laptop GPU

Blender Version
Broken: bpy 4.1.0
Worked: ?

Short description of error
If bpy is imported while running python unit tests with pytests, a Runtime exception will be raised but ignored in the atexit callback of pytest.

This error is related to #111649 but the fix doesn't seem to work in the context of pytest.

Exact steps for others to reproduce the error
To reproduce this error you just need a file that imports bpy. Here for example a file named test.py.

#test.py
import bpy

Then run the following command to execute the tests contained in test.py. (You can install pytest with pip install pytest)
python -m pytest test.py

The command output should look like that.

python -m pytest test.py
=========================================== test session starts ============================================
platform linux -- Python 3.11.6, pytest-6.2.5, py-1.11.0, pluggy-1.5.0
rootdir: /...
plugins: forked-1.6.0, xdist-2.5.0, anyio-4.3.0, cov-2.12.1, dash-2.16.1
collected 0 items                                                                                          

========================================== no tests ran in 0.47s ===========================================
Exception ignored in atexit callback: <function disable_all at 0x7f8e689f2700>
Traceback (most recent call last):
  File "/root/.../python3.11/site-packages/bpy/4.1/scripts/modules/addon_utils.py", line 564, in disable_all
    addon_modules = [
                    ^
  File "/root/.../python3.11/site-packages/bpy/4.1/scripts/modules/addon_utils.py", line 564, in <listcomp>
    addon_modules = [
                    ^
RuntimeError: dictionary changed size during iteration

The tests are working properly, but the exception is raised in what seems to be the exit handler of the pytest module.

**System Information** Operating system: WSL 2.1.5.0 - Ubuntu 20.04.6 LTS Graphics card: NVIDIA GeForce RTX 3070 Laptop GPU **Blender Version** Broken: bpy 4.1.0 Worked: ? **Short description of error** If bpy is imported while running python unit tests with pytests, a Runtime exception will be raised but ignored in the atexit callback of pytest. This error is related to #111649 but the fix doesn't seem to work in the context of pytest. **Exact steps for others to reproduce the error** To reproduce this error you just need a file that imports `bpy`. Here for example a file named `test.py`. ``` #test.py import bpy ``` Then run the following command to execute the tests contained in test.py. (You can install pytest with `pip install pytest`) `python -m pytest test.py` The command output should look like that. ``` python -m pytest test.py =========================================== test session starts ============================================ platform linux -- Python 3.11.6, pytest-6.2.5, py-1.11.0, pluggy-1.5.0 rootdir: /... plugins: forked-1.6.0, xdist-2.5.0, anyio-4.3.0, cov-2.12.1, dash-2.16.1 collected 0 items ========================================== no tests ran in 0.47s =========================================== Exception ignored in atexit callback: <function disable_all at 0x7f8e689f2700> Traceback (most recent call last): File "/root/.../python3.11/site-packages/bpy/4.1/scripts/modules/addon_utils.py", line 564, in disable_all addon_modules = [ ^ File "/root/.../python3.11/site-packages/bpy/4.1/scripts/modules/addon_utils.py", line 564, in <listcomp> addon_modules = [ ^ RuntimeError: dictionary changed size during iteration ``` The tests are working properly, but the exception is raised in what seems to be the exit handler of the pytest module.

Alexis-19 added the

labels 2024-04-24 13:49:11 +02:00

Alexis-19 commented

2024-04-24 16:36:33 +02:00

I tried to copy the modules dictionnary in the disable_all() function in addon_utils.py. The exception is not showing anymore but I not sure the function behavior is preserved.

37d87e89bc

I tried to copy the modules dictionnary in the `disable_all()` function in `addon_utils.py`. The exception is not showing anymore but I not sure the function behavior is preserved. https://projects.blender.org/blender/blender/commit/37d87e89bc691aa2567adf07d09a11554ebe0693

YimingWu added

and removed

labels 2024-04-25 03:52:23 +02:00

YimingWu commented

2024-04-25 03:53:25 +02:00

I guess pytest is also accessing and modifying sys.modules. I think your patch is a reasonable fix actually. Assigned bpy module for devs to take a look. Thanks for reporting!

I guess `pytest` is also accessing and modifying `sys.modules`. I think your patch is a reasonable fix actually. Assigned bpy module for devs to take a look. Thanks for reporting!

👍 1

YimingWu referenced a pull request that will close this issue

2024-04-26 02:59:36 +02:00

Fix #121021: Avoid size change of `addon_modules` during iteration #121100

Sign in to join this conversation.