Grease Pencil: Add eyedropper to palette popup #111736
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
10 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#111736
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Inspired by this idea by gakutada.
The Issue
The color picker popup in Grease Pencil is missing the eyedropper button:
That is present in regular color pickers:
Even though holding the
Ekey with the mouse over the color swatch works fine:The Solution
Add the operator to the popup. Aligned to the right-side so it's similar to the regular color popup.
Hello, if I can I would really like to take this as my first issue.
Great! Nobody has claimed this yet so feel free to go ahead.
All details are in developer.blender.org and the developer intro in the wiki
Thank you! I will start right away.
@Ferenc-Gyombolai senor, ping me if you change your mind. I will look for other issue meanwhile, thank you and good luck
hello, i was going through the issue right now and was looking at the codes related to it and was wondering it would be better to add the eyedropper icon and functionalities directly to he popup codebase as in the given video instead of fixing it in the grease pencil tool.
furthermore,
5adb3b6882this commit over here created a proper eyedropper codebase and implemented in the grease pencil tool. can we use it in the same way for including it in popup palette code ?@pablovazquez
@pablovazquez Hi , wouldn't that be redundant since this widget already has an eyedropper ?
it wont be necessary but the original popup has the icon , so it would be better to complete its originality.
Hi @HamilcarR ,
Are you still working on it? I have tried on my side and able to do it but as I am new to the codebase, would love to discuss about the approach I took and also, I have some questions regarding my approach.
It would be nice if we can collaborate on this one. Looking forward to hearing from you.
Hello @Harpreet-Singh-4 , Currently I'm working on my project finishing some features , but I intend to come back to blender soon .
But you should probably ask questions on the chat , I'm also new , and not familiar with all the codebase.
Did you manage to make the operators work though ? Can you share a commit so I can see , I was pretty stuck with the operators last time I was working on it.
Sure @HamilcarR here is the PR which I have marked as Draft for now #113297
Hi @pablovazquez,
Hope you are doing well. I am able to add the eyedropper in the palette pop up and it works. But I have question regarding the callback for the eyedropper button I have implemented. Can you please have a look at the PR I have linked and give your feedback if the callback I have implemented is the correct way.
Thanks.
Hi! Is this issue still open? If so, I would like to contribute to it. Although I'm a complete beginner to open source contributions and would require a fair bit of guidance to tackle this. Do let me know if someone will be able to assist me through this. Thank you!
Hi @Khevan-Thanki ,
There is open PR on this one #113297
You can have a look at this.
@Harpreet-Singh-4
Just to clarify, does it mean someone is already working on it? Sorry I'm a bit unfamiliar with the term open PR.
@pablovazquez
Sorry, but not quite understanding what is requested here. This area shows two colors at once, green and black in the capture. I can click on either color and get a colorpicker wheel with an eyedropper. The area below that is for palettes, and your solution involves adding an eyedropper icon there.
What is that eyedropper in the palette intending to do? I might guess that it adds a new palette entry for the color sampled? Or perhaps alter the color of the selected item in the palette? Or is meant to alter just the current color, the green in the top capture?
@pablovazquez @Harley
I am guessing that this is likely this case, and will try my hand at implementing that.
~ also hello Blender Foundation. 👋
Hello!
I don't think that will really be what is requested here. The eyedropper would then be redundant ( clicking on that color reveals an eyedropper), and it would be in the palette section which doesn't make a lot of sense.
@Harley
The potential of removing one of the two color pickers, perhaps we are redundant in the amount of 1 whole additional color picker which causes some UX confusion?
Possible Ideas
What if we remove the secondary color picker that opens when you click one of the two colors, add the eyedropper above the palette section, and have a selected state for each of the 2 colors, when one of the two colors is in a "selected state" - the color wheel at the top, as well as the eyedropper, operate on the selected one?
-- or --
Remove the wheel at the top, preserving only the secondary color wheel that is visible upon clicking one of the two colors (the ones that have their respective eyedroppers already visible)?
Which do you think sounds more preferable?
-- yet, also --
Quite possibly neither, because I am just jumping back into blender after being absent for several years and am likely misunderstanding the context surrounding the current design! Bear with me while I try to catch myself up to speed, lol.
Personally I'd prefer for Pablo to clarify what is really wanted here before we rush into anything. He's back in a couple weeks.
Sounds like a plan, I will pickup a different issue in the meantime and provide support wherever I can.
@pablovazquez hello i would like know if the task is take or no ? And else i would takes