Animation: create a full separate copy of BoneCollections while in armature edit mode #112134

New Issue

Nathan Vegdahl · 2023-09-08T13:05:34+02:00

Nathan Vegdahl commented

2023-09-08 13:05:34 +02:00

This is to avoid touching the main data structures in the Armature datablock while in edit mode, which interacts badly with undo.

Relevant:

#111965

This is to avoid touching the main data structures in the Armature datablock while in edit mode, which interacts badly with undo. Relevant: - #111965

Nathan Vegdahl added the

labels 2023-09-08 13:05:45 +02:00

Nathan Vegdahl added this to the Animation & Rigging project 2023-09-08 13:05:50 +02:00

Nathan Vegdahl added this to the 4.1 milestone 2023-09-08 13:05:55 +02:00

Nathan Vegdahl referenced this issue

2023-09-08 13:06:37 +02:00

Fix #111780: bone collections and undo don't work together #111965

Alexander Gavrilov commented

2023-09-09 12:12:52 +02:00

How would this work with the Python API? The Armature.collections property would probably have to magically choose which list to use.

Nathan Vegdahl commented

2023-09-11 11:24:10 +02:00

That's a good question. And it does give me a bit of pause if this is actually what we want to proceed with, rather than e.g. waiting to just get rid of the edit mode data structures entirely. @mont29 and @dr.sybren, thoughts?

The Armature.collections property would probably have to magically choose which list to use.

That's one way it could work. Another way would be to mirror the Bone/EditBone distinction, by having a separate BoneCollection API for edit mode. That would be clunky, but it would be consistent with the whole Bone/EditBone thing, which is similarly clunky.

That's a good question. And it does give me a bit of pause if this is actually what we want to proceed with, rather than e.g. waiting to just get rid of the edit mode data structures entirely. @mont29 and @dr.sybren, thoughts? > The Armature.collections property would probably have to magically choose which list to use. That's one way it could work. Another way would be to mirror the Bone/EditBone distinction, by having a separate BoneCollection API for edit mode. That would be clunky, but it would be consistent with the whole Bone/EditBone thing, which is similarly clunky.

Bastien Montagne commented

2023-09-11 11:42:32 +02:00

I would try mirroring the bone/editbone behavior yes (this is short-term solution anyways). We can think further if that fails.

Sybren A. Stüvel commented

2023-09-11 12:51:52 +02:00

I'd prefer a more magic armature.collections property. That seems easier for scripters (they can just use the same property in any mode) and also it's a bit more future-proof (it keeps working if/when we remove the whole editbone mess).

There's plenty of code that does if (arm->edbo != nullptr) { ... special case ... }, and I think that's fine too in the RNA accessors for the collections property & the functions on that type.

IMO it's important that we create a future-proof API. That way we can alter things "on the inside" without having to worry about breaking changes.

I'd prefer a more magic `armature.collections` property. That seems easier for scripters (they can just use the same property in any mode) and also it's a bit more future-proof (it keeps working if/when we remove the whole editbone mess). There's plenty of code that does `if (arm->edbo != nullptr) { ... special case ... }`, and I think that's fine too in the RNA accessors for the `collections` property & the functions on that type. IMO it's important that we create a future-proof API. That way we can alter things "on the inside" without having to worry about breaking changes.

👍 1

Bastien Montagne commented

2023-09-11 13:06:18 +02:00

Yikes I read Nathan's comment too fast (and forgot how EditBones are currently handled in RNA!).

Indeed what I wanted to say is that I would rather have a single API for bone collections regardless of the mode, and have the RNA do the 'smart choosing' behind the scene. So I agree with Sybren and Alexander here.

Yikes I read Nathan's comment too fast (and forgot how EditBones are currently handled in RNA!). Indeed what I wanted to say is that I would rather have a single API for bone collections regardless of the mode, and have the RNA do the 'smart choosing' behind the scene. So I agree with Sybren and Alexander here.

👍 1

Sybren A. Stüvel removed this from the 4.1 milestone 2024-03-13 09:25:35 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Animation: create a full separate copy of BoneCollections while in armature edit mode #112134