GPv3: Set selected curve material as active material #113569

New Issue

Pratik Borhade · 2023-10-12T06:10:04+02:00

Pratik Borhade commented

2023-10-12 06:10:04 +02:00

Set material of selected stoke as active in UIList.

Define GREASE_PENCIL_OT_set_active_material operator in grease_pencil_edit.cc
Mention this operator in strokes panel: VIEW3D_MT_edit_greasepencil_stroke
Iterate through all the drawings at current scene frame (foreach_editable_drawing)
- Get geometry of this drawing: bke::CurvesGeometry &curves = drawing.strokes_for_write();
- Retrieve material attribute:
  bke::SpanAttributeWriter<int> materials = curves.attributes_for_write().lookup_or_add_for_write_span<int>("material_index", ATTR_DOMAIN_CURVE);
- Get material of the first selected curve
- Change active material in the material slots list using the material index of the curve
- Exit drawing loop
Send notifiers to other editors: WM_event_add_notifier()

Set material of selected stoke as active in UIList. - Define `GREASE_PENCIL_OT_set_active_material` operator in `grease_pencil_edit.cc` - Mention this operator in strokes panel: `VIEW3D_MT_edit_greasepencil_stroke` - Iterate through all the drawings at current scene frame (`foreach_editable_drawing`) - Get geometry of this drawing: ` bke::CurvesGeometry &curves = drawing.strokes_for_write();` - Retrieve material attribute: `bke::SpanAttributeWriter<int> materials = curves.attributes_for_write().lookup_or_add_for_write_span<int>("material_index", ATTR_DOMAIN_CURVE);` - Get material of the first selected curve - Change active material in the material slots list using the material index of the curve - Exit drawing loop - Send notifiers to other editors: `WM_event_add_notifier()`

Pratik Borhade added the

labels 2023-10-12 06:10:04 +02:00

Pratik Borhade added this to the Grease Pencil project 2023-10-12 12:08:43 +02:00

Pratik Borhade added

and removed

labels 2023-10-12 12:49:57 +02:00

Pratik Borhade added the

Module

Grease Pencil

label 2023-10-12 13:02:07 +02:00

Falk David referenced this issue

2023-10-25 18:43:46 +02:00

GPv3: Community Tasks: Overview #114158

Antonio Vazquez commented

2023-10-27 10:31:32 +02:00

@PratikPB2123 I don't think this is correct. In your text you are assigning the material to the curve and must be inverse. I will take this one.

Antonio Vazquez self-assigned this 2023-10-27 10:31:40 +02:00

Antonio Vazquez changed title from ~~GPv3: Set active material~~ to GPv3: Set selected material as active material

2023-10-27 10:34:43 +02:00

Antonio Vazquez changed title from ~~GPv3: Set selected material as active material~~ to GPv3: Set selected curve material as active material

2023-10-27 10:35:00 +02:00

Antonio Vazquez referenced this issue

2023-10-27 11:12:23 +02:00

GPv3: Set selected curve material as active material #114188

Pratik Borhade commented

2023-10-27 23:29:27 +02:00

@antoniov hi, not sure if I understand this completely but in task description I wrote object->actcol = materials.span[curve_index] which is same your change in PR

Anyways, thanks for the PR 🙂

@antoniov hi, not sure if I understand this completely but in task description I wrote `object->actcol = materials.span[curve_index]` which is same your change in PR Anyways, thanks for the PR 🙂

👍 1

Falk David referenced this issue from a commit

2023-11-08 15:00:59 +01:00

GPv3: Set selected curve material as active material

Pratik Borhade commented

2023-11-13 12:28:41 +01:00

a8cb0b0ca0

a8cb0b0ca09959ef4228300d45a3d88a87f4d08c

Pratik Borhade closed this issue

2023-11-13 12:28:44 +01:00

Pratik Borhade added the

Status