GPv3: Clean Loose Points #113599

New Issue

Pratik Borhade · 2023-10-12T14:08:39+02:00

Pratik Borhade commented

2023-10-12 14:08:39 +02:00

Clear stroke from the viewport if stroke points are less than or equal to operator "limit" value

Define GREASE_PENCIL_OT_frame_clean_loose operator in grease_pencil_edit.cc
Create new operator property "limit" (same as legacy GP)
Iterate through all the drawings at current scene frame (foreach_editable_drawing)
- Get geometry of this drawing: bke::CurvesGeometry &curves = drawing.strokes_for_write();
- Iterate through all the curves present in this drawing (use curves.curves_range())
  - Get points count of individual curve: curves.points_by_curve()[curve_index].size()
  - Delete curve when points in single curve are <= limit (CurvesGeometry::remove_curves())
Send dependency graph update and send notifiers to other editors

Clear stroke from the viewport if stroke points are less than or equal to operator "limit" value - Define `GREASE_PENCIL_OT_frame_clean_loose` operator in `grease_pencil_edit.cc` - Create new operator property "limit" (same as legacy GP) - Iterate through all the drawings at current scene frame (`foreach_editable_drawing`) - Get geometry of this drawing: `bke::CurvesGeometry &curves = drawing.strokes_for_write();` - Iterate through all the curves present in this drawing (`use curves.curves_range()`) - Get points count of individual curve: `curves.points_by_curve()[curve_index].size()` - Delete curve when points in single curve are <= limit (`CurvesGeometry::remove_curves()`) - Send dependency graph update and send notifiers to other editors

Pratik Borhade added the

labels 2023-10-12 14:08:40 +02:00

Pratik Borhade added

and removed

labels 2023-10-12 14:36:05 +02:00

Pratik Borhade added this to the Grease Pencil project 2023-10-12 14:36:23 +02:00

Hans Goudey commented

2023-10-13 10:26:04 +02:00

Nice! Two things I'd point out:

This should probably work within the existing curves selection, which can be retrieved as an index mask with some existing utilities
There's a utility to create an index mask based on a predicate, IndexMask::from_predicate which should help make it just a few lines to select all the single-point curves

Nice! Two things I'd point out: - This should probably work within the existing curves selection, which can be retrieved as an index mask with some existing utilities - There's a utility to create an index mask based on a predicate, `IndexMask::from_predicate` which should help make it just a few lines to select all the single-point curves

Pratik Borhade commented

2023-10-13 11:10:25 +02:00

Thanks @HooglyBoogly

This should probably work within the existing curves selection, which can be retrieved as an index mask with some existing utilities

AFAICS legacy GP considers all strokes (not selected) available at the current frame.

Thanks @HooglyBoogly > This should probably work within the existing curves selection, which can be retrieved as an index mask with some existing utilities AFAICS legacy GP considers all strokes (not selected) available at the current frame.

Falk David referenced this issue

2023-10-25 18:43:46 +02:00

GPv3: Community Tasks: Overview #114158

Pratik Borhade self-assigned this 2023-11-27 13:03:29 +01:00

Pratik Borhade referenced a pull request that will close this issue

2023-12-08 05:05:28 +01:00

GPv3: Clean loose points operator #115923

Falk David referenced this issue from a commit

2023-12-08 16:53:22 +01:00

GPv3: Clean loose points operator

Falk David closed this issue

2023-12-08 16:53:23 +01:00