GPv3: Split Stroke #113643

New Issue

Pratik Borhade · 2023-10-13T08:22:44+02:00

Pratik Borhade commented

2023-10-13 08:22:44 +02:00

Create a new stroke of selected points from a single stroke and remove previous points. Do this in same drawing.
This operator is specific to points mode.

Define operator GREASE_PENCIL_OT_stroke_split in grease_pencil_edit.cc
Iterate through all the drawings at current scene frame (foreach_editable_drawing)
- Get geometry of current drawing: drawing.strokes_for_write();
- Find selected points with the help of .selection attribute
- Copy selected points are return it in new CurvesGeometry. (use: curves_copy_point_selection)
- Delete selected points from current drawing: (#111571 is required)
- Resize geometry at current drawing to include these new points and curves of new drawing: CurvesGeometry::resize()
- Update offset and copy other attributes of new drawing in current drawing (maybe use bke::gather_attributes?)

Create a new stroke of selected points from a single stroke and remove previous points. Do this in same drawing. This operator is specific to points mode. - Define operator `GREASE_PENCIL_OT_stroke_split` in `grease_pencil_edit.cc` - Iterate through all the drawings at current scene frame (`foreach_editable_drawing`) - Get geometry of current drawing: `drawing.strokes_for_write();` - Find selected points with the help of `.selection` attribute - Copy selected points are return it in new CurvesGeometry. (use: `curves_copy_point_selection`) - Delete selected points from current drawing: (https://projects.blender.org/blender/blender/pulls/111571 is required) - Resize geometry at current drawing to include these new points and curves of new drawing: `CurvesGeometry::resize()` - Update offset and copy other attributes of new drawing in current drawing (maybe use `bke::gather_attributes`?)

Pratik Borhade added the

labels 2023-10-13 08:23:22 +02:00

Pratik Borhade added this to the Grease Pencil project 2023-10-13 08:23:46 +02:00

Hans Goudey commented

2023-10-13 10:18:09 +02:00

I would suggest changing the steps a little bit to avoid allocating data more times than necessary. Avoiding .resize() is typically nice if we can know the final size before an allocation.

Calculate the total size of the new geometry after the deletion and addition
Create the new CurvesGeometry to contain the entire result
Copy the non-selected strokes/points into the beginning of the new curves
Copy the selected points to the end of the new curves

I would suggest changing the steps a little bit to avoid allocating data more times than necessary. Avoiding `.resize()` is typically nice if we can know the final size before an allocation. - Calculate the total size of the new geometry after the deletion and addition - Create the new CurvesGeometry to contain the entire result - Copy the non-selected strokes/points into the beginning of the new curves - Copy the selected points to the end of the new curves

Pratik Borhade commented

2023-10-19 12:01:35 +02:00

@HooglyBoogly , thanks. I'm writing new task for GREASE_PENCIL_OT_stroke_separate so revisited this. I think curves_copy_point_selection won't help here. Because we expect to separate continuous selected points in new stroke. AFAICS this function don't create new stroke for continuous selected points.
I guess new steps could be:

Get selection attribute from source_geometry
Get continuous selected points: array_utils::find_all_ranges()
Create new CurvesGeometry (d_geom)
Write attributes, offset for unselected points
Write attributes, offset for selected points in d_geom (with the help of selection range and source_geometry)

@HooglyBoogly , thanks. I'm writing new task for `GREASE_PENCIL_OT_stroke_separate` so revisited this. I think `curves_copy_point_selection` won't help here. Because we expect to separate continuous selected points in new stroke. AFAICS this function don't create new stroke for continuous selected points. I guess new steps could be: - Get selection attribute from source_geometry - Get continuous selected points: `array_utils::find_all_ranges()` - Create new CurvesGeometry (d_geom) - Write attributes, offset for unselected points - Write attributes, offset for selected points in d_geom (with the help of selection range and source_geometry)

Hans Goudey commented

2023-10-19 12:18:33 +02:00

Not sure how related it is, but I revisted an old patch for a split curves node too: #113926

Pratik Borhade referenced this issue

2023-10-19 13:49:56 +02:00

GPv3: Separate #113932

Falk David referenced this issue

2023-10-25 18:43:46 +02:00

GPv3: Community Tasks: Overview #114158

Ayanfe Ibitoye commented

2023-12-06 04:36:55 +01:00

Hi, I'd like to work on this if no one's already gotten to it.