Node Tool deletes Shape Keys #113662

Open
opened 2023-10-13 12:12:08 +02:00 by Nika Kutsniashvili · 8 comments
Contributor

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1650/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 537.42

Blender Version
Broken: version: 4.0.0 Beta, branch: blender-v4.0-release, commit date: 2023-10-11 23:03, hash: 67e4af3ea1cb
Worked: (newest version of Blender that worked as expected)

Short description of error

image

Exact steps for others to reproduce the error

  • Open attached .blend file
  • Execute the Node Group "My Tool"

Note that all Shape Keys are destroyed.

**System Information** Operating system: Windows-10-10.0.19043-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1650/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 537.42 **Blender Version** Broken: version: 4.0.0 Beta, branch: blender-v4.0-release, commit date: 2023-10-11 23:03, hash: `67e4af3ea1cb` Worked: (newest version of Blender that worked as expected) **Short description of error** <video src="/attachments/b58fc7fe-be10-4a3d-8278-721d17633259" controls></video> ![image](/attachments/23d0f51a-8056-4f85-83a8-33be9fe40aee) **Exact steps for others to reproduce the error** - Open attached .blend file - Execute the Node Group "My Tool" Note that all Shape Keys are destroyed.
Nika Kutsniashvili added the
Priority
Normal
Type
Report
Status
Needs Triage
labels 2023-10-13 12:12:09 +02:00
Author
Contributor

I'm not sure if you can see video I uploaded but I can't. This has been issue on this website for quite a while now and I keep mentioning it. Please somebody fix it, it's very hard to report bugs like this.

https://imgur.com/Sh2Tb4d

I'm not sure if you can see video I uploaded but I can't. This has been issue on this website for quite a while now and I keep mentioning it. Please somebody fix it, it's very hard to report bugs like this. https://imgur.com/Sh2Tb4d

I'm not sure if you can see video I uploaded but I can't. This has been issue on this website for quite a while now and I keep mentioning it. Please somebody fix it, it's very hard to report bugs like this.

I think it's an issue with the video file. After downloading it locally, it does not open in Chrome, Firefox or Quicktime Player here, but it does open in VLC.

> I'm not sure if you can see video I uploaded but I can't. This has been issue on this website for quite a while now and I keep mentioning it. Please somebody fix it, it's very hard to report bugs like this. I think it's an issue with the video file. After downloading it locally, it does not open in Chrome, Firefox or Quicktime Player here, but it does open in VLC.

Thank you for the report. I can confirm and have edited the description to make it clearer.

Thank you for the report. I can confirm and have edited the description to make it clearer.
Iliya Katushenock added this to the 4.0 milestone 2024-02-15 19:57:50 +01:00
Hans Goudey added
Priority
High
Type
Bug
and removed
Priority
Normal
Type
Report
labels 2024-02-15 20:04:48 +01:00
Member

This will depend on the node tree in the end, but a basic node tree that doesn't do anything shouldn't remove shape keys. And ideally it would be reported to the user when it happens.

This will depend on the node tree in the end, but a basic node tree that doesn't do anything shouldn't remove shape keys. And ideally it would be reported to the user when it happens.
Iliya Katushenock removed this from the 4.0 milestone 2024-02-15 20:06:51 +01:00
Member

Looking into this a bit more, I think it is a known issue in the end. But I'll look into adding a warning to tell users about it anyway.

The problem is that node tools currently work on "evaluated" copies of objects, and shape keys are stored entirely differently for evaluated data-blocks.

Looking into this a bit more, I think it is a known issue in the end. But I'll look into adding a warning to tell users about it anyway. The problem is that node tools currently work on "evaluated" copies of objects, and shape keys are stored entirely differently for evaluated data-blocks.
Hans Goudey added
Priority
Normal
Type
Known Issue
and removed
Priority
High
Type
Bug
labels 2024-03-01 21:58:41 +01:00
Author
Contributor

@HooglyBoogly so I'm assuming that means if (please Hans) shape keys are just regular attributes, node tools will still not affect them since they act like modifier, and best we can hope for is to not delete them? I think that's fair and expected. Affecting shape keys isn't something I want to do anyway (or affecting vertex count), but shape keys not getting removed when node tool is used would be nice.

@HooglyBoogly so I'm assuming that means if (please Hans) shape keys are just regular attributes, node tools will still not affect them since they act like modifier, and best we can hope for is to not delete them? I think that's fair and expected. Affecting shape keys isn't something I want to do anyway (or affecting vertex count), but shape keys not getting removed when node tool is used would be nice.
Member

If shape keys were regular attributes, that would work. But they're far from it currently, unfortunately. Shape key data arrays are stored in a separate Key data-block. During depsgraph evaluation the active shape key is processed, but nothing else.

There seems to be wide agreement that the shape key design is bad nowadays. The Blender studio even uses geometry nodes instead sometimes, for compatibility with library overrides I think. So I don't think shape key storage is on my "refactor" list unfortunately.

A more likely change is using original data-blocks in node tools instead. That would at least increase the number of supported nodes (from 0!) to include nodes like "Set Position" that don't change topology. And it may also significantly improve performance for node tools.

**If** shape keys were regular attributes, that would work. But they're far from it currently, unfortunately. Shape key data arrays are stored in a separate `Key` data-block. During depsgraph evaluation the active shape key is processed, but nothing else. There seems to be wide agreement that the shape key design is bad nowadays. The Blender studio even uses geometry nodes instead sometimes, for compatibility with library overrides I think. So I don't think shape key storage is on my "refactor" list unfortunately. A more likely change is using original data-blocks in node tools instead. That would at least increase the number of supported nodes (from 0!) to include nodes like "Set Position" that don't change topology. And it may also significantly improve performance for node tools.
Author
Contributor

Well as facial animator that just killed something inside me, but maybe light shines one day on shape keys and Key data-block can be rested in piece!

A more likely change is using original data-blocks in node tools instead. That would at least increase the number of supported nodes (from 0!) to include nodes like "Set Position" that don't change topology. And it may also significantly improve performance for node tools.

Even though I would find that useful personally, I wouldn't spend my time on that if I were you. Shape Keys create such a terrible headache for animation (and new anim data block), as well as sculpting and multi-res that its only a matter of time till bigger design is needed.

Well as facial animator that just killed something inside me, but maybe light shines one day on shape keys and Key data-block can be rested in piece! > A more likely change is using original data-blocks in node tools instead. That would at least increase the number of supported nodes (from 0!) to include nodes like "Set Position" that don't change topology. And it may also significantly improve performance for node tools. Even though I would find that useful personally, I wouldn't spend my time on that if I were you. Shape Keys create such a terrible headache for animation (and new anim data block), as well as sculpting and multi-res that its only a matter of time till bigger design is needed.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#113662
No description provided.