Geometry Nodes: Add node tools warning when shape keys are removed #118986

Merged
Hans Goudey merged 1 commits from HooglyBoogly/blender:node-tools-shape-key-remove-warning into blender-v4.1-release 2024-03-01 22:45:20 +01:00
Member

For various reasons, node tools don't support some data. Shape keys aren't
supported because their format is entirely different for evaluated and
original data-blocks, and node tools currently work in the "evaluated"
world. Though that would be nice to change, in the meantime users
should at least be warned when this happens.

This PR adds a simple "Mesh shape key data removed" operator warning.

See #113662

For various reasons, node tools don't support some data. Shape keys aren't supported because their format is entirely different for evaluated and original data-blocks, and node tools currently work in the "evaluated" world. Though that would be nice to change, in the meantime users should at least be warned when this happens. This PR adds a simple "Mesh shape key data removed" operator warning. See #113662
Hans Goudey added 1 commit 2024-03-01 22:20:10 +01:00
For various reasons, node tools don't support some data. Shape keys aren't
supported because their format is entirely different for evaluated and
original data-blocks, and node tools currently work in the "evaluated"
world. Though that would be nice to change, in the meantime users
should at least be warned when this happens.

This PR adds a simple "Mesh shape key data removed" operator warning.
Hans Goudey added this to the 4.1 milestone 2024-03-01 22:20:34 +01:00
Hans Goudey added the
Interest
Geometry Nodes
label 2024-03-01 22:20:38 +01:00
Hans Goudey added this to the Nodes & Physics project 2024-03-01 22:20:43 +01:00
Hans Goudey requested review from Jacques Lucke 2024-03-01 22:20:51 +01:00
Jacques Lucke approved these changes 2024-03-01 22:33:47 +01:00
Jacques Lucke left a comment
Member

Might be reasonable to show a warning dialog before removing shape keys which people might miss. However, this is already better than before, so ok.

Might be reasonable to show a warning dialog before removing shape keys which people might miss. However, this is already better than before, so ok.
Hans Goudey merged commit beb92830f9 into blender-v4.1-release 2024-03-01 22:45:20 +01:00
Hans Goudey deleted branch node-tools-shape-key-remove-warning 2024-03-01 22:45:23 +01:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#118986
No description provided.