GPv3: Active Layer #113915

New Issue

Pratik Borhade · 2023-10-19T07:17:37+02:00

Pratik Borhade commented

2023-10-19 07:17:37 +02:00

Change active layer from shortcut (for non-object node). Press key to invoke panel where all layers are displayed, select layer to set it active.

Define operator in GREASE_PENCIL_OT_layer_active in grease_pencil_layers.cc
Define int/string operator property (layer) to obtain selected layer (similar to legacy GP)
Get this selected layer in operator execution function: `RNA_int_get(op->ptr, "layer");
Set this layer as active: GreasePencil::set_active_layer()
Set notifiers to animation and properties editor
Create a menu GREASE_PENCIL_MT_layer_active in properties_grease_pencil_common.py
Display layers of current GP object in the panel: (for example: grease_pencil.data.layers[index])
Add keymap entry in blender_defaults.py to invoke this menu op_menu()

Change active layer from shortcut (for non-object node). Press key to invoke panel where all layers are displayed, select layer to set it active. - Define operator in `GREASE_PENCIL_OT_layer_active` in `grease_pencil_layers.cc` - Define int/string operator property (`layer`) to obtain selected layer (similar to legacy GP) - Get this selected layer in operator execution function: `RNA_int_get(op->ptr, "layer"); - Set this layer as active: `GreasePencil::set_active_layer()` - Set notifiers to animation and properties editor - Create a menu `GREASE_PENCIL_MT_layer_active` in `properties_grease_pencil_common.py` - Display layers of current GP object in the panel: (for example: `grease_pencil.data.layers[index]`) - Add keymap entry in `blender_defaults.py` to invoke this menu `op_menu()`

Pratik Borhade added the

labels 2023-10-19 07:17:57 +02:00

Pratik Borhade added this to the Grease Pencil project 2023-10-19 07:18:12 +02:00

Falk David referenced this issue

2023-10-25 18:43:46 +02:00

GPv3: Community Tasks: Overview #114158

Clément Busschaert referenced this issue

2023-11-29 09:54:55 +01:00

GPv3: Community Tasks: Overview #114158

Falk David commented

2023-11-29 11:01:35 +01:00

@SmugRainbowPony Is giving this a try.

Clément Busschaert commented

2023-11-29 13:24:31 +01:00

I'm noticing there's a menu (GPENCIL_MT_layer_active) already present in properties_grease_pencil_common.py:
1970de9d19/scripts/startup/bl_ui/properties_grease_pencil_common.py (L251-L274)

I'm assuming I should keep it around for now, mark it as legacy, and add the GREASE_PENCIL_-prefixed variant next to it?

I'm noticing there's a menu (`GPENCIL_MT_layer_active`) already present in `properties_grease_pencil_common.py`: https://projects.blender.org/blender/blender/src/commit/1970de9d197e11eaba391ca399a42ae661617103/scripts/startup/bl_ui/properties_grease_pencil_common.py#L251-L274 I'm assuming I should keep it around for now, mark it as legacy, and add the `GREASE_PENCIL_`-prefixed variant next to it?

Falk David commented

2023-11-29 13:27:29 +01:00

@SmugRainbowPony Yes that sounds like a good idea.

Clément Busschaert referenced this issue

2023-11-30 12:09:18 +01:00

WIP: GPv3: active_layer operator port #115603

~~Clément Busschaert referenced this issue 2023-11-30 12:21:59 +01:00~~

GPv3: port `active_layer` operator and menu #115606

Clément Busschaert commented

2023-11-30 12:23:22 +01:00

I somehow broke the first PR by force-pushing onto my branch, but here's a valid one ready for review: #115606

Falk David referenced a pull request that will close this issue