GPv3: Delete duplicated frames #114182

New Issue

Pratik Borhade · 2023-10-26T22:29:52+02:00

Pratik Borhade commented

2023-10-26 22:29:52 +02:00

Delete next keyframe if its duplicate of current keyframe

Define GREASE_PENCIL_OT_frame_clean_duplicate in grease_pencil_frames.cc
Add boolean operator property selected to remove selected/all frames
Loop all the layers, in every layer run a loop for every single frame: for (frame : layer.frames().items()) (might need values() or index based for loop (i = 0; i < frame_size; i++)
With the current keyframe, also retrieve next keyframe
If selected is true, run following code when frame.is_selected()
Get geometry:
- Get drawing_index from frame number: layer->drawing_index_at(frame_number);
- Use drawing_index to get active drawing: grease_pencil.drawing(drawing_index)
- Get geometry: bke::CurvesGeometry &geometry = drawing.strokes_for_write();
Verify whether content of both keyframes are same
Check for curve, point count (points_num(), curves_num())
Check whether attributes are same: attributes.for_all()

Delete next keyframe if its duplicate of current keyframe - Define `GREASE_PENCIL_OT_frame_clean_duplicate` in `grease_pencil_frames.cc` - Add boolean operator property `selected` to remove selected/all frames - Loop all the layers, in every layer run a loop for every single frame: `for (frame : layer.frames().items())` (might need `values()` or index based for loop `(i = 0; i < frame_size; i++)` - With the current keyframe, also retrieve next keyframe - If `selected` is true, run following code when `frame.is_selected()` - Get geometry: - Get drawing_index from frame number: `layer->drawing_index_at(frame_number);` - Use drawing_index to get active drawing: `grease_pencil.drawing(drawing_index)` - Get geometry: `bke::CurvesGeometry &geometry = drawing.strokes_for_write();` - Verify whether content of both keyframes are same - Check for curve, point count (`points_num(), curves_num()`) - Check whether attributes are same: `attributes.for_all()`

Pratik Borhade added the

labels 2023-10-26 22:30:39 +02:00

Pratik Borhade added this to the Grease Pencil project 2023-10-26 22:30:54 +02:00

Falk David referenced this issue

2023-11-01 15:54:09 +01:00

GPv3: Community Tasks: Overview #114158

Abdelrahman Said commented

2023-12-02 19:21:46 +01:00

I would love to help with this task, but I wanted to check with you first if you would consider it a good task for someone who is contributing to Blender for the first time. From the description it seems simple enough and, given that I have C/C++ experience and have already built Blender from source a couple of times before, I believe I will be able to do it, but I just want to confirm this with you before I start working on it.

Pratik Borhade commented

2023-12-03 05:49:56 +01:00

@amsaid1989 hi, this task seems good for someone contributing for the first time.

Abdelrahman Said commented

2023-12-03 14:50:54 +01:00

@PratikPB2123 Great.. thank you very much.. I will give it a go and ask on the chat if I need any help

Falk David commented

2023-12-11 11:18:39 +01:00

I'm going to add some more details to this part: "Verify whether content of both keyframes are same"

I suggest to write a static function like this:

static bool curves_geometry_is_equal(const CurvesGeometry &curves_a, const CurvesGeometry &curves_b)

First we do the easy checks (number of points and number of curves):

if (curves_a.curves_num() != curves_b.curves_num() || curves_a.points_num() != curves_b.points_num()) {
   return false;
}

Second, we check if the curve offsets are all the same:

if (curves_a.offsets() != curves_b.offsets()) {
   return false;
}

Third, we check if the set of attributes are the same (this does not check the values in the attributes, just if the number of attributes are the same and the ids match):

const bke::AttributeAccessor attributes_a = curves_a.attributes();
const bke::AttributeAccessor attributes_b = curves_b.attributes();
const Set<AttributeIDRef> ids_a = attributes_a.all_ids();
const Set<AttributeIDRef> ids_b = attributes_b.all_ids();
if (ids_a != ids_b) {
  return false;
}

Finally, we check if all the attributes have the same values:

We know attributes_a == attributes_b at this point so we can just iterate over one of them like

for (const AttributeIDRef &id : attributes_a)

We get the GVArray from both geometies

const GVArray &values_a = *attributes_a.lookup(id);

First, check the sizes (.size()) and return false if they aren't the same
Then, get the types const CPPType &type_a = values_a.type() and make sure they are the same, otherwise return false.
Loop over arrays using IndexRange(values_a.size())
Use type.is_equal_or_false(values_a[i], values_b[i]) to compare the individual values. And again, when this is false, return

In the end we can return true.

I'm going to add some more details to this part: "Verify whether content of both keyframes are same" I suggest to write a `static` function like this: ``` static bool curves_geometry_is_equal(const CurvesGeometry &curves_a, const CurvesGeometry &curves_b) ``` First we do the easy checks (number of points and number of curves): ``` if (curves_a.curves_num() != curves_b.curves_num() || curves_a.points_num() != curves_b.points_num()) { return false; } ``` Second, we check if the curve offsets are all the same: ``` if (curves_a.offsets() != curves_b.offsets()) { return false; } ``` Third, we check if the set of attributes are the same (this does not check the values in the attributes, just if the number of attributes are the same and the ids match): ``` const bke::AttributeAccessor attributes_a = curves_a.attributes(); const bke::AttributeAccessor attributes_b = curves_b.attributes(); const Set<AttributeIDRef> ids_a = attributes_a.all_ids(); const Set<AttributeIDRef> ids_b = attributes_b.all_ids(); if (ids_a != ids_b) { return false; } ``` Finally, we check if all the attributes have the same values: * We know `attributes_a == attributes_b` at this point so we can just iterate over one of them like ``` for (const AttributeIDRef &id : attributes_a) ``` * We get the `GVArray` from both geometies ``` const GVArray &values_a = *attributes_a.lookup(id); ``` * First, check the sizes (`.size()`) and return `false` if they aren't the same * Then, get the types `const CPPType &type_a = values_a.type()` and make sure they are the same, otherwise return `false`. * Loop over arrays using `IndexRange(values_a.size())` * Use `type.is_equal_or_false(values_a[i], values_b[i])` to compare the individual values. And again, when this is false, return In the end we can `return true`.

Abdelrahman Said commented

2023-12-28 23:14:09 +01:00

Hey @filedescriptor. I've implemented most of what you included in your description, however, there is one thing that I haven't figured out yet.

GVArray doesn't implement operator[]. There are 2 overloads of the get() method, but I haven't figured out how to use either of them. This means that I am currently stuck implementing the last point in your description:

Use type.is_equal_or_false(values_a[i], values_b[i]) to compare the individual values. And again, when this is false, return

I would appreciate your help here.

Hey @filedescriptor. I've [implemented](https://projects.blender.org/amsaid1989/blender/src/commit/7d24286c0465ad489f1c5e588866f451dba059e3/source/blender/editors/grease_pencil/intern/grease_pencil_frames.cc#L369-L488) most of what you included in your description, however, there is one thing that I haven't figured out yet. `GVArray` doesn't implement `operator[]`. There are 2 overloads of the `get()` method, but I haven't figured out how to use either of them. This means that I am currently stuck implementing the last point in your description: >- Use `type.is_equal_or_false(values_a[i], values_b[i])` to compare the individual values. And again, when this is false, return I would appreciate your help here.

Abdelrahman Said referenced this issue

2023-12-30 14:01:45 +01:00

GPv3: Port `frame_clean_duplicate` operator #116655

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

GPv3: Delete duplicated frames #114182