Regression: snapping in graph editor with ctrl hotkey no longer functions properly #114588

New Issue

Closed

opened 2023-11-07 17:28:13 +01:00 by Nathan Vegdahl · 4 comments

Nathan Vegdahl commented

2023-11-07 17:28:13 +01:00

Member

System Information
Operating system: Gentoo Linux, x86-64
Graphics card: Radeon RX 7900 XT

Blender Version
Broken: 4.0 Beta - abe925d0c6 - 2023-11-06
Worked: 3.6.5

Short description of error

Holding down ctrl in the graph editor while moving keys no longer snaps vertically, nor does it snap in the same way as it used to horizontally.

Blender 3.6x and earlier always had the same behavior when holding down control: keys would snap to a zoom-level appropriate increment on both the vertical and horizontal axes.

Current Blender now behaves differently: when holding down ctrl, keys fail to snap at all vertically, and the horizontal behavior depends on the snap settings. If snap is set to either frames or seconds, ctrl will swap. If snap is set to none, ctrl does nothing.

The following videos demonstrate the difference. Both videos start moving the key without ctrl held down, and then switch to holding down ctrl.

3.6	4.0

The expected behavior is the same as Blender 3.6.

Exact steps for others to reproduce the error

Set a keyframe on the default cube.
Open a graph editor.
Grab a key frame and start moving it around.
While moving the key, hold down ctrl.

**System Information** Operating system: Gentoo Linux, x86-64 Graphics card: Radeon RX 7900 XT **Blender Version** Broken: 4.0 Beta - abe925d0c671 - 2023-11-06 Worked: 3.6.5 **Short description of error** Holding down ctrl in the graph editor while moving keys no longer snaps vertically, nor does it snap in the same way as it used to horizontally. Blender 3.6x and earlier always had the same behavior when holding down control: keys would snap to a zoom-level appropriate increment on both the vertical and horizontal axes. Current Blender now behaves differently: when holding down ctrl, keys fail to snap *at all* vertically, and the horizontal behavior depends on the snap settings. If snap is set to either frames or seconds, ctrl will swap. If snap is set to none, ctrl does nothing. The following videos demonstrate the difference. Both videos start moving the key without ctrl held down, and then switch to holding down ctrl. | 3.6 | 4.0 | |----|----| | <video src="/attachments/0c382521-fed1-4d29-ba5b-b3be047e671f" title="blender_3.6_graph_editor_ctrl.webm" controls></video> | <video src="/attachments/7e659c6e-4658-468a-ab94-4c1571a7f674" title="blender_4.0-beta_graph_editor_ctrl.webm" controls></video> | The expected behavior is the same as Blender 3.6. **Exact steps for others to reproduce the error** 1. Set a keyframe on the default cube. 2. Open a graph editor. 3. Grab a key frame and start moving it around. 4. While moving the key, hold down ctrl.

blender_3.6_graph_editor_ctrl.webm

1.9 MiB

blender_4.0-beta_graph_editor_ctrl.webm

2.0 MiB

Nathan Vegdahl added the

labels 2023-11-07 17:28:13 +01:00

Iliya Katushenock added the

Animation & Rigging

label 2023-11-07 17:28:33 +01:00

Nathan Vegdahl added this to the Animation & Rigging project 2023-11-07 17:28:38 +01:00

Nathan Vegdahl added the

Animation & Rigging

label 2023-11-07 17:28:51 +01:00

Nathan Vegdahl added this to the 4.0 milestone 2023-11-07 17:32:52 +01:00

Nathan Vegdahl added

and removed

labels 2023-11-07 17:33:12 +01:00

Christoph Lendenfeld was assigned by Nathan Vegdahl

2023-11-07 17:33:34 +01:00

Christoph Lendenfeld commented

2023-11-07 18:54:50 +01:00

Member

so I couldn't figure out how that behavior was achieved in 3.6 and below.
What I did find out:
When pressing CTRL, the MOD_SNAP_INVERT flag is set
This flag means the autosnap mode will return as SACTSNAP_OFF (in transform_snap_animation.c/61 on the 3.6 release branch)

But how the code goes from "snap disabled" to "snapping increments" I don't understand yet

so I couldn't figure out how that behavior was achieved in 3.6 and below. What I did find out: When pressing CTRL, the `MOD_SNAP_INVERT` flag is set This flag means the autosnap mode will return as `SACTSNAP_OFF` (in transform_snap_animation.c/61 on the 3.6 release branch) But how the code goes from "snap disabled" to "snapping increments" I don't understand yet

Germano Cavalcante added

and removed

Animation & Rigging

labels 2023-11-07 22:46:27 +01:00

Germano Cavalcante commented

2023-11-07 22:49:58 +01:00

Member

I imagine the behavior changed with a41da206cd

In fact, the code is confusing, and the incremental snap option doesn't even appear in the snapping popover.

Removing it seems more correct than before, but to avoid regression, it might be good to add the Incremenal Snap option to the popover.

This snap has generic code (it is not in recalcData). It depends on the transformation mode. The code is in transform_snap_increment_ex.

I imagine the behavior changed with a41da206cd In fact, the code is confusing, and the incremental snap option doesn't even appear in the snapping popover. Removing it seems more correct than before, but to avoid regression, it might be good to add the Incremenal Snap option to the popover. This snap has generic code (it is not in recalcData). It depends on the transformation mode. The code is in `transform_snap_increment_ex`.

Christoph Lendenfeld commented

2023-11-07 22:59:45 +01:00

Member

I found the issue.
I would argue this was never an intended feature, but more on that in the PR I will link shortly

I found the issue. I would argue this was never an intended feature, but more on that in the PR I will link shortly

Christoph Lendenfeld referenced a pull request that will close this issue

2023-11-07 23:08:11 +01:00

Fix #114588: Graph Editor increment snap not working #114607

Nathan Vegdahl commented

2023-11-08 12:03:01 +01:00

Author

Member

I would argue this was never an intended feature

Yeah, that doesn't surprise me, honestly. Still good to match the old behavior first, though, I think. Then we can figure out where to go from there.

> I would argue this was never an intended feature Yeah, that doesn't surprise me, honestly. Still good to match the old behavior first, though, I think. Then we can figure out where to go from there.

Christoph Lendenfeld referenced this issue from a commit

2023-11-09 14:38:38 +01:00

Fix #114588: Graph Editor increment snap not working

Christoph Lendenfeld closed this issue

2023-11-09 14:38:40 +01:00

Blender Bot added

and removed

labels 2023-11-09 14:38:42 +01:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#114588

No description provided.