Node Editor: Image and Principled have missing Enums in properties inspector #115727
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
9 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#115727
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Blender Version
Broken: version: 4.1.0 Alpha, branch: main, commit date: 2023-12-02 19:08, hash:
8933284518a2Short description of error
„Image Texture‟ and „Principled BSDF‟ nodes have missing Node Option enums in properties inspector while every other node have every option exposed (i've checked).
Missing options:
Eg of other nodes with enum options:
While this does not cause any error, it prevents working with nodes at zoomed out level or node options turned off.
eg.
The
Principled BSDFcase appears to be a recent regression because the enum properties are present in 3.6.5 (looks like they were drawn by thebyp_funcShaderNodeBsdfPrincipled.draw_buttons_ext()):The
Image Texturecase appears to have never displayed its extra enum properties; I checked 2.80, 2.93, 3.2 and 3.6.I also have this issue
I can confirm as well. The Principled BSDF case was affected between
264c3e7bd7a6 - 407e2b9f700f(possibly13fac109d3caused this)(subsurface radius is intentionally expanded in
ea3814c3ed)Here is 2 unrelated case. Image Texture options is properties on Image data block. In another hand, Principled BSDF properties not is not a part of node itself, but part of panel so that is expected that N-panel ignore them.
Can you make sure if both bug is caused by the same commit, or this report can be splitted?
Could I work on this issue.
Principled BSDFnode changes was done by Cycles module.Image node wasn't changed recently, but also could be checked by Cycles module (or Image one) instead of nodes.
I think this is an issue with the node panels mechanism, not a Cycles problem. The contents of the panels should be draw in the sidebar.
CC @LukasTonne
13fac109added button callbacks to the panel declarations, and removed many shader buttons from the olderdraw_buttonscallback inbNodeType. But the sidebar panel only draws the buttons handled bybNodeType::draw_button.The sockets themselves use the flattened
node.inputslist which ignores the panels, so i guess we need a similar "draw everything and ignore panels" function for buttons.I can add an option to the RNA draw callbacks to draw panel buttons in addition to the top-level buttons. Downside is that the order of buttons and sockets will not match the order in the node instance, it will draw all the buttons before any sockets.
Can we use the same mechanism as #116472 in the node editor sidebar, to support panels there?
@JacquesLucke do the new panels have python support?
@LukasTonne not yet, as mentioned in
f824476bd5Should be fairly straight forward to add though.
Any volunteers for implementing that?
I can make a patch today.