Curve Hook modifier broken due to selection changes #116402

New Issue

Jerry Miller · 2023-12-21T00:06:50+01:00

Jerry Miller commented

2023-12-21 00:06:50 +01:00

System Information
Operating system: Windows 10
Graphics card: 2x Nvidia GeForce RTX 2080 Supers

Blender Version
Broken: 4.0 onwards
Worked: 3.6
Caused by 618f39fca2

Short description of error
When adding a hook object to a curve object it behaves in an unpredictable manner.
This is due the changes in curve selection. Now handles are not selected along with the control point, hence the difference

Exact steps for others to reproduce the error

Open default scene -> add bezier curve
In edit mode, subdivide once
Select the middle control point (notice it's handles are not selected)
Hook to new object.

Possible solutions to implement: #116402 (comment)

Have additional menu items to add hooks to the vertex and it's handles, so there would be 3x menu items to add hooks with the knot, another 3x to add with knot & handles. (an awkward solution but lets to user access the previous default behavior without having to manually select the handles).
Add an operator option to include handles when adding a hook and enable it by default (users are likely to overlook this, making adding a hook to a single vertex more obscure).
Revert the change to selection behavior, so handles are always selected again (listing for completeness, I don't think it's a practical option).

**System Information** Operating system: Windows 10 Graphics card: 2x Nvidia GeForce RTX 2080 Supers **Blender Version** Broken: 4.0 onwards Worked: 3.6 Caused by 618f39fca2 **Short description of error** When adding a hook object to a curve object it behaves in an unpredictable manner. This is due the changes in curve selection. Now handles are not selected along with the control point, hence the difference **Exact steps for others to reproduce the error** - Open default scene -> add bezier curve - In edit mode, subdivide once - Select the middle control point (notice it's handles are not selected) - Hook to new object. - - - Possible solutions to implement: https://projects.blender.org/blender/blender/issues/116402#issuecomment-1097628 - Have additional menu items to add hooks to the vertex and it's handles, so there would be 3x menu items to add hooks with the knot, another 3x to add with knot & handles. _(an awkward solution but lets to user access the previous default behavior without having to manually select the handles)._ - Add an operator option to include handles when adding a hook and enable it by default _(users are likely to overlook this, making adding a hook to a single vertex more obscure)._ - Revert the change to selection behavior, so handles are always selected again _(listing for completeness, I don't think it's a practical option)._

broken hook.blend

108 KiB

Jerry Miller added the

labels 2023-12-21 00:06:51 +01:00

Pratik Borhade commented

2023-12-21 06:12:24 +01:00

Hi, thanks for the report. I'm not able to confirm as described. Hook object seems to affect the curve when moved in 4.0.x and 4.1
Could you verify with factory reset?: File > Defaults > Load Factory Settings

Hi, thanks for the report. I'm not able to confirm as described. Hook object seems to affect the curve when moved in 4.0.x and 4.1 Could you verify with factory reset?: `File > Defaults > Load Factory Settings`

Pratik Borhade added

Status

Needs Information from User

and removed

Status

Needs Triage

labels 2023-12-21 06:12:33 +01:00

Jerry Miller commented

2023-12-21 17:00:29 +01:00

Hi, thanks for the report. I'm not able to confirm as described. Hook object seems to affect the curve when moved in 4.0.x and 4.1
Could you verify with factory reset?: File > Defaults > Load Factory Settings

It's the movement of the curve specifically. In older blender files it would move and have smooth falloff. In 4.0+ its been doing a sharp movement. Plus the falloff on the hook modifier isn't changing anything.

I will do a Factory load and verify it is not just something on my end.... but it happens on my computer, my friends computer next to me and my friend in Brazil that confirmed its being strange.

> Hi, thanks for the report. I'm not able to confirm as described. Hook object seems to affect the curve when moved in 4.0.x and 4.1 > Could you verify with factory reset?: `File > Defaults > Load Factory Settings` It's the movement of the curve specifically. In older blender files it would move and have smooth falloff. In 4.0+ its been doing a sharp movement. Plus the falloff on the hook modifier isn't changing anything. I will do a Factory load and verify it is not just something on my end.... but it happens on my computer, my friends computer next to me and my friend in Brazil that confirmed its being strange.

blender_Opeu85papv.mp4

1.9 MiB

Jerry Miller commented

2023-12-21 19:55:50 +01:00

Hi, thanks for the report. I'm not able to confirm as described. Hook object seems to affect the curve when moved in 4.0.x and 4.1
Could you verify with factory reset?: File > Defaults > Load Factory Settings

I confirmed the problem is still there even after I loaded factory settings. My video in my last comment shows the same behavior that I see with 4.0 being different than the same process in 3.5 or any earlier versions.

confirmed the same issue in 4.0.3 release candidate from yesterday's daily build as well...

> Hi, thanks for the report. I'm not able to confirm as described. Hook object seems to affect the curve when moved in 4.0.x and 4.1 > Could you verify with factory reset?: `File > Defaults > Load Factory Settings` I confirmed the problem is still there even after I loaded factory settings. My video in my last comment shows the same behavior that I see with 4.0 being different than the same process in 3.5 or any earlier versions. confirmed the same issue in 4.0.3 release candidate from yesterday's daily build as well...

Pratik Borhade commented

2023-12-22 05:17:52 +01:00

I see, can confirm actually (but loading older file in 4.0 with hook did not trigger the issue, hence the confusion)

❤️ 1

Pratik Borhade added

and removed

Needs Information from User

labels 2023-12-22 05:18:06 +01:00

Pratik Borhade referenced this issue

2023-12-22 05:20:17 +01:00

Curve hooks don't work correctly in blender 4.0 #116456

Pratik Borhade commented

2023-12-22 06:49:48 +01:00

Strange, git bisect points to 618f39fca2
@ideasman42 ^

Strange, git bisect points to 618f39fca23ca7734a09a8f08efced8379efd2b3 @ideasman42 ^

Laurynas Duburas commented

2023-12-26 23:01:39 +01:00

Sadly after some time of debugging it appeared there is nothing to fix.
@sage2014 in old version when you are assigning modifier control point and both handles are selected.
In 4.0 only control point is selected, thus moving Empty handles stay in old position giving sharp corner.
It can be observed in provided video.

Tried 3.6 version. Handles are selected automatically if control point is selected.
And it seems that it's not possible to select control point without selecting both handles.
I suspect that selection behavior in 4.0 is intentional.

Sadly after some time of debugging it appeared there is nothing to fix. @sage2014 in old version when you are assigning modifier control point and both handles are selected. In 4.0 only control point is selected, thus moving Empty handles stay in old position giving sharp corner. It can be observed in provided video. Tried 3.6 version. Handles are selected automatically if control point is selected. And it seems that it's not possible to select control point without selecting both handles. I suspect that selection behavior in 4.0 is intentional.

Laurynas Duburas commented

2024-01-02 13:29:24 +01:00

@PratikPB2123 is it really a bug?

@PratikPB2123 is it really a bug? <video src="/attachments/b5496129-b81d-43a7-851e-4e837040cc92" title="hook.mov" controls></video>

hook.mov

5.8 MiB

Pratik Borhade commented

2024-01-03 10:48:23 +01:00

Thanks @laurynas . Indeed this is due to selection differences. :)
Curve selection in 4.0 is intentional as specified in the commit message: 90864d3fb8

Not sure whether to consider it a bug but it affects the previous workflow to some extent. I'll pass it to Campbell for the decision :)

Meanwhile, I'll check if this can be improved.

Thanks @laurynas . Indeed this is due to selection differences. :) Curve selection in 4.0 is intentional as specified in the commit message: 90864d3fb80ebebef0f90cc6d60e9eb01e665ba5 Not sure whether to consider it a bug but it affects the previous workflow to some extent. I'll pass it to Campbell for the decision :) Meanwhile, I'll check if this can be improved.

Jerry Miller commented

2024-01-03 21:51:40 +01:00

@PratikPB2123 is it really a bug?

This video helps to show how to fix the issue I was having, however... I selected the control points the same way in both versions. Is it that in the new version, it simply doesn't select all the controls on the control points the same way?

Before, you'd just select the control point and it would automatically select both handles. now its as if you only select the control point but not the two handles.

Either way, the video helps to show how to move forward. I just wonder if this was intended change in blender 4.0 or if there might have been something that causes the two handles to not be selected? or if I just straight up did something wrong lol.

Thank you for the video and responses <3

> @PratikPB2123 is it really a bug? > <video src="/attachments/b5496129-b81d-43a7-851e-4e837040cc92" title="hook.mov" controls></video> This video helps to show how to fix the issue I was having, however... I selected the control points the same way in both versions. Is it that in the new version, it simply doesn't select all the controls on the control points the same way? Before, you'd just select the control point and it would automatically select both handles. now its as if you only select the control point but not the two handles. Either way, the video helps to show how to move forward. I just wonder if this was intended change in blender 4.0 or if there might have been something that causes the two handles to not be selected? or if I just straight up did something wrong lol. Thank you for the video and responses <3

Hans Goudey added

Status

Needs Info from Developers

and removed

Status

Confirmed

labels 2024-01-08 21:42:30 +01:00

Campbell Barton commented

2024-01-09 05:32:27 +01:00

It's understandable that the change in selection behavior causes the change when adding new hooks, I don't think there are especially good ways to resolve this.

Changing the default behavior (treating the handles as if they're selected for e.g.) makes it impossible to add the hook to a single handle - which users may want to do too.

Possible Solutions

Listing potential solutions, although I'm not keen on any of them.

Have additional menu items to add hooks to the vertex and it's handles, so there would be 3x menu items to add hooks with the knot, another 3x to add with knot & handles. (an awkward solution but lets to user access the previous default behavior without having to manually select the handles).
Add an operator option to include handles when adding a hook and enable it by default (users are likely to overlook this, making adding a hook to a single vertex more obscure).
Revert the change to selection behavior, so handles are always selected again (listing for completeness, I don't think it's a practical option).

More generally, we could have a shortcut for selecting a point and it's handles - since it can be useful at times. If this is supported, ideally all bezier curve editors (f-curve, mask... etc) would support this too.

Setting as a lower priority design task as it's possible to select 3 points before adding the hook.

It's understandable that the change in selection behavior causes the change when adding new hooks, I don't think there are especially good ways to resolve this. Changing the default behavior (treating the handles as if they're selected for e.g.) makes it impossible to add the hook to a single handle - which users may want to do too. ## Possible Solutions Listing potential solutions, although I'm not keen on any of them. - Have additional menu items to add hooks to the vertex and it's handles, so there would be 3x menu items to add hooks with the knot, another 3x to add with knot & handles. _(an awkward solution but lets to user access the previous default behavior without having to manually select the handles)._ - Add an operator option to include handles when adding a hook and enable it by default _(users are likely to overlook this, making adding a hook to a single vertex more obscure)._ - Revert the change to selection behavior, so handles are always selected again _(listing for completeness, I don't think it's a practical option)._ More generally, we could have a shortcut for selecting a point and it's handles - since it can be useful at times. If this is supported, ideally all bezier curve editors (f-curve, mask... etc) would support this too. ---- Setting as a lower priority design task as it's possible to select 3 points before adding the hook.

Campbell Barton added

and removed

labels 2024-01-09 05:36:03 +01:00

Campbell Barton added

and removed

Needs Info from Developers

labels 2024-01-09 05:37:45 +01:00

Campbell Barton pinned this 2024-01-09 05:37:45 +01:00

Campbell Barton added the

Status

Needs Information from User

label 2024-01-09 05:37:45 +01:00

Campbell Barton unpinned this 2024-01-09 05:37:52 +01:00

Philipp Oeser referenced this issue

2024-01-11 09:49:46 +01:00

Cannot select curve handles in Blender 4 as in previous versions #117016

Pratik Borhade commented

2024-01-11 09:50:10 +01:00

Add an operator option to include handles when adding a hook and enable it by default

Maybe the second option ^
But answer from core users would help here (people in this thread or someone from the studio)

> Add an operator option to include handles when adding a hook and enable it by default Maybe the second option ^ But answer from core users would help here (people in this thread or someone from the studio)

Jerry Miller commented

2024-01-27 04:07:20 +01:00

Add an operator option to include handles when adding a hook and enable it by default

Maybe the second option ^
But answer from core users would help here (people in this thread or someone from the studio)

Honestly if whatever was added to make it an optional toggle, that'd be great. I personally would like for it to be the same as how it has been before. This way guides or tutorials are still valid. Or at a bare minimum have something listed in the release notes or somewhere that states this functionality was changed somehow.

I know in the blender discord, we had our own custom bot that had user submitted guides for random things and this would cause a tiny bit of confusion.

> > Add an operator option to include handles when adding a hook and enable it by default > > Maybe the second option ^ > But answer from core users would help here (people in this thread or someone from the studio) Honestly if whatever was added to make it an optional toggle, that'd be great. I personally would like for it to be the same as how it has been before. This way guides or tutorials are still valid. Or at a bare minimum have something listed in the release notes or somewhere that states this functionality was changed somehow. I know in the blender discord, we had our own custom bot that had user submitted guides for random things and this would cause a tiny bit of confusion.

Pratik Borhade changed title from ~~Curve Hook modifier broken?~~ to Curve Hook modifier broken due to selection changes

2024-03-01 10:45:52 +01:00

Pratik Borhade commented

2024-03-01 10:51:36 +01:00

Made few tweaks in description, confirming again.

👍 1

Pratik Borhade added

Status

Confirmed

and removed

Status

Needs Information from User