Pasting angle value with minus sign results in error #117783

New Issue

Serge Lyatin · 2024-02-03T13:24:22+01:00

Serge Lyatin commented

2024-02-03 13:24:22 +01:00

System Information
Operating system: win10 64
Graphics card: 1050ti

Blender Version
Broken: 3.6, 4.0.3

Short description of error
Pasting angle value with minus sign results in error:
Error evaluating number, see Info editor for details: bad operand type for unary -: 'tuple'

Exact steps for others to reproduce the error
Set X rotation to -90 deg for a Cube and copy this value with ctrl+c via cursor hover or a click
Paste it to Y rotation with math input: click cursor in the field, type "-" (minus sign w/o quotation marks), press ctrl+v then enter

**System Information** Operating system: win10 64 Graphics card: 1050ti **Blender Version** Broken: 3.6, 4.0.3 **Short description of error** Pasting angle value with minus sign results in error: `Error evaluating number, see Info editor for details: bad operand type for unary -: 'tuple'` **Exact steps for others to reproduce the error** Set X rotation to -90 deg for a Cube and copy this value with ctrl+c via cursor hover or a click Paste it to Y rotation with math input: click cursor in the field, type "-" (minus sign w/o quotation marks), press ctrl+v then enter

1.png

4.4 KiB

Serge Lyatin added the

labels 2024-02-03 13:24:22 +01:00

Richard Antalik commented

2024-02-03 19:31:13 +01:00

But there are two - signs in your screenshot. Seems that this works with unitless numbers, but doesn't work when unit is used.
I assume, that numbers with units are parsed as tupple, and you are effectively doing expression -(-90, 'd') which is invalid expression. In such case this would work as expected

But there are two `-` signs in your screenshot. Seems that this works with unitless numbers, but doesn't work when unit is used. I assume, that numbers with units are parsed as tupple, and you are effectively doing expression `-(-90, 'd')` which is invalid expression. In such case this would work as expected

Richard Antalik commented

2024-02-03 19:57:07 +01:00

Actually, --1m is converted to (-()-(1*1 ))*1, so the invalid part is only -(). But the code expects a number after - sign. So this is still working as expected. I think, there could be "find double negative" string processing stage, since it would be more consistent and quite safe though. But then values like -(-5m) still couldn't be parsed properly.

Actually, `--1m` is converted to `(-()-(1*1 ))*1`, so the invalid part is only `-()`. But the code expects a number after `-` sign. So this is still working as expected. I think, there could be "find double negative" string processing stage, since it would be more consistent and quite safe though. But then values like -(-5m) still couldn't be parsed properly.

Richard Antalik commented

2024-02-03 20:19:26 +01:00

@harley Can you share your opinion here? Should at least double negative be handled here?

Harley Acheson commented

2024-02-05 00:47:45 +01:00

@SergeL = "Pasting angle value with minus sign results in error"

What was your expected result? You weren't entering an "angle value with minus sign" but an angle with two minus signs. Were you expecting this would result in +90 degrees?

This error does not require any copying and pasting. You can see this result by typing values directly into the rotation input:

"90" = +90°
"-90" = -90°
"--90" = "+90°
"++90" = "+90°
"---90" = "-90°
"-------90" = -90°

The problem occurs when adding "d" or "r" after it. These work:
"90d" = +90°
"-90d" = -90°
"++90d" = +90°
"2r" = 114.592°
"-2r" = -114.592°

These do not:
"--90d" = error
"--2r" = error

Is this even something worth worrying about? It seems like an inconvenient way to enter +90° or +2r. What was the reason for pasting the negative value after entering a minus sign?

> @SergeL = "Pasting angle value with minus sign results in error" What was your expected result? You weren't entering an "angle value with minus sign" but an angle with **two minus signs**. Were you expecting this would result in +90 degrees? This error does not require any copying and pasting. You can see this result by typing values directly into the rotation input: "90" = +90° "-90" = -90° "--90" = "+90° "++90" = "+90° "---90" = "-90° "-------90" = -90° The problem occurs when adding "d" or "r" after it. These work: "90d" = +90° "-90d" = -90° "++90d" = +90° "2r" = 114.592° "-2r" = -114.592° These do not: "--90d" = error "--2r" = error Is this even something worth worrying about? It seems like an inconvenient way to enter +90° or +2r. What was the reason for pasting the negative value after entering a minus sign?

Harley Acheson commented

2024-02-05 01:07:57 +01:00

This error is caused inside of unit_distribute_negatives

This routine puts "parentheses around blocks of values after negative signs to get rid of an implied "+" between numbers without an operation between them" The example given is this string:

"-1m50cm + 1 - 2m50cm"
becomes
"-(1m50cm) + 1 - (2m50cm)"

Guessing it was not made expecting to see multiple negatives in a row. Might be able to just repeatedly remove sequences of "--" until there are none?

This error is caused inside of `unit_distribute_negatives` This routine puts "parentheses around blocks of values after negative signs to get rid of an implied "+" between numbers without an operation between them" The example given is this string: "-1m50cm + 1 - 2m50cm" becomes "-(1m50cm) + 1 - (2m50cm)" Guessing it was not made expecting to see multiple negatives in a row. Might be able to just repeatedly remove sequences of "--" until there are none?

Harley Acheson commented

2024-02-05 01:25:10 +01:00

I'll submit a PR for Campbell to look at

Harley Acheson self-assigned this 2024-02-05 01:25:35 +01:00

Harley Acheson referenced a pull request that will close this issue

2024-02-05 01:49:53 +01:00

Fix #117783: Allow Multiple Negatives in Numerical Inputs with Units #117819

Pratik Borhade added

and removed

labels 2024-02-05 05:48:08 +01:00

Serge Lyatin commented

2024-02-05 07:17:15 +01:00

@SergeL = "Pasting angle value with minus sign results in error"

What was your expected result? You weren't entering an "angle value with minus sign" but an angle with two minus signs. Were you expecting this would result in +90 degrees?

Exactly this, it is the fastest way to make positive number when dealing with math input and copied values.

> > @SergeL = "Pasting angle value with minus sign results in error" > > What was your expected result? You weren't entering an "angle value with minus sign" but an angle with **two minus signs**. Were you expecting this would result in +90 degrees? > Exactly this, it is the fastest way to make positive number when dealing with math input and copied values.

Campbell Barton referenced a pull request that will close this issue

2024-02-05 09:51:16 +01:00

Fix #117783: Allow Multiple Negatives in Numerical Inputs with Units #117827

Campbell Barton referenced this issue from a commit

2024-02-05 23:29:45 +01:00

Fix #117783: Allow Multiple Negatives in Numerical Inputs with Units

Campbell Barton closed this issue

2024-02-05 23:29:46 +01:00

Blender Bot added

Status

Resolved

and removed