Fix #117783: Allow Multiple Negatives in Numerical Inputs with Units #117819

Harley Acheson · 2024-02-05T01:49:53+01:00

Harley Acheson commented

2024-02-05 01:49:53 +01:00

Remove all sequences of two minus signs in unit_distribute_negatives
to allow entry of strings like "---90d"

For numerical entry we properly support multiple negatives when the string does not contain units:

"90" = +90°
"-90" = -90°
"--90" = "+90°
"++90" = "+90°
"---90" = "-90°
"-------90" = -90°

But we don't handle multiple negatives when there are units. The following shows "Error evaluating number, see Info editor for details: bad operand type for unary -: 'tuple'":
"--90d" = error
"--2r" = error

This is because when the string contains a unit we call unit_distribute_negatives which puts "parentheses around blocks of values after negative signs to get rid of an implied "+" between numbers without an operation between them. For example: "-1m50cm + 1 - 2m50cm" -> "-(1m50cm) + 1 - (2m50cm)". It does not handle multiple minus signs in a row. This PR just repeatedly removes "--" until there are none, replacing these with spaces. This obviously leaves a minus sign when there is an odd amount. And further processing handles extra spaces just fine.

Remove all sequences of two minus signs in unit_distribute_negatives to allow entry of strings like "---90d" --- For numerical entry we properly support multiple negatives when the string does not contain units: "90" = +90° "-90" = -90° "--90" = "+90° "++90" = "+90° "---90" = "-90° "-------90" = -90° But we don't handle multiple negatives when there are units. The following shows "Error evaluating number, see Info editor for details: bad operand type for unary -: 'tuple'": "--90d" = error "--2r" = error This is because when the string contains a unit we call `unit_distribute_negatives` which puts "parentheses around blocks of values after negative signs to get rid of an implied "+" between numbers without an operation between them. For example: "-1m50cm + 1 - 2m50cm" -> "-(1m50cm) + 1 - (2m50cm)". It does not handle multiple minus signs in a row. This PR just repeatedly removes "--" until there are none, replacing these with spaces. This obviously leaves a minus sign when there is an odd amount. And further processing handles extra spaces just fine.

👍 1

Harley Acheson added 1 commit 2024-02-05 01:49:59 +01:00

8e4bb72e88 Fix #117783 : Allow Multiple Negatives in Numerical Inputs with Units

Remove all sequences of two minus signs in unit_distribute_negatives
to allow entry of strings like "---90d"

Harley Acheson added this to the Core Libraries project 2024-02-05 01:50:30 +01:00

Harley Acheson requested review from Campbell Barton 2024-02-05 01:50:37 +01:00

Campbell Barton commented

2024-02-05 09:53:17 +01:00

Looking into this it seems we could support a more generalized way of supporting multiple unary arguments, submitted !117827.

Harley Acheson commented

2024-02-05 19:07:42 +01:00

Closing in favor of Campbell's #117827 which handles this in a nicer way.

Harley Acheson closed this pull request

2024-02-05 19:07:44 +01:00

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #117783: Allow Multiple Negatives in Numerical Inputs with Units #117819

Pull request closed