blender/blender

Sculpt: Color Filter crash #117824

New Issue

Closed

opened 2024-02-05 06:05:41 +01:00 by TheRedWaxPolice · 8 comments

TheRedWaxPolice commented

2024-02-05 06:05:41 +01:00

System Information
Operating system: Win 10

Blender Version
Broken: blender-4.1.0-alpha+main.d73628a3cda4-windows.amd64-release
Worked: Dunno... even 4.0 and 3.6 are crashing as well...

Short description of error
Blender crashes after using the color filter and then undo and redo

Exact steps for others to reproduce the error

File/New/Sculpting
Choose the Color Filter tool... pick a color... then click and drag in the viewport from left to right to fill the object with the color
Undo
Redo

Crash.....

**System Information** Operating system: Win 10 **Blender Version** Broken: blender-4.1.0-alpha+main.d73628a3cda4-windows.amd64-release Worked: Dunno... even 4.0 and 3.6 are crashing as well... **Short description of error** Blender crashes after using the color filter and then undo and redo **Exact steps for others to reproduce the error** - File/New/Sculpting - Choose the Color Filter tool... pick a color... then click and drag in the viewport from left to right to fill the object with the color - Undo - Redo Crash..... <video controls="" src="https://projects.blender.org/attachments/416be974-8c06-4985-a632-5049878a6f05"></video>

blender_TrMff2m7R7.mp4

2.1 MiB

TheRedWaxPolice added the

labels 2024-02-05 06:05:42 +01:00

Pratik Borhade commented

2024-02-05 06:27:56 +01:00

Member

Thanks for the report. Can confirm the crash in 3.2-4.1

Thanks for the report. Can confirm the crash in 3.2-4.1

Pratik Borhade added

Sculpt, Paint & Texture

and removed

labels 2024-02-05 06:28:32 +01:00

Pratik Borhade commented

2024-02-05 06:56:07 +01:00

Member

After undo color attribute is null as we jump to original undo step.
Performing redo operation afterwards keeps the color-attribute null. I think this is because the color attribute is not stored in sculpt-undo step. or is it deleted already from the file after the initial undo operation?

After undo `color attribute` is null as we jump to [original](/attachments/e97c7d48-f93d-4fb8-89fe-911b7d6342a2) undo step. Performing redo operation afterwards keeps the color-attribute null. I think this is because the color attribute is not stored in sculpt-undo step. or is it deleted already from the file after the initial undo operation?

24 KiB

Philipp Oeser added the

label 2024-02-06 09:40:16 +01:00

ThinkingPolygons commented

2024-02-07 14:20:25 +01:00

i was going to report that bug. glad i did a search before.
but whats going on, crashes are not high priority anymore?
new rules?

i was going to report that bug. glad i did a search before. but whats going on, crashes are not high priority anymore? new rules?

Philipp Oeser commented

2024-02-07 15:34:55 +01:00

Member

Not all crashes need to be considered as High priority

The rule from https://developer.blender.org/docs/handbook/bug_reports/triaging_playbook/ says

"High - Most crashes and recent regressions."

There are many crashes that are sort of expected even (e.g. messing around with the python API is certain ways).

However, @JulienKaspar : would you consider this High priority?

Not all crashes need to be considered as High priority The rule from https://developer.blender.org/docs/handbook/bug_reports/triaging_playbook/ says "High - Most crashes and recent regressions." There are many crashes that are sort of expected even (e.g. messing around with the python API is certain ways). However, @JulienKaspar : would you consider this High priority?

ThinkingPolygons commented

2024-02-07 16:26:28 +01:00

@lichtwerk i mean, a crash after undoing and redoing seems pretty serious to me.

additionally, i just spotted another issue.
following the steps in the first post to reproduce the crash, if before you apply the color filter you do something, like a brush stroke, then apply the filter, then undo and redo, some weird lines appear on the mesh. please see the video

and if you undo twice and then redo it crashes
something is really broken there

@lichtwerk i mean, a crash after undoing and redoing seems pretty serious to me. additionally, i just spotted another issue. following the steps in the first post to reproduce the crash, if before you apply the color filter you do something, like a brush stroke, then apply the filter, then undo and redo, some weird lines appear on the mesh. please see the video <video controls="" src="https://projects.blender.org/attachments/fc62f5a1-e9b4-4f9d-9fbd-8cb3bf791877"></video> and if you undo twice and then redo it crashes something is really broken there

blender_JnkGSIqGbg.mp4

1.2 MiB

Pratik Borhade commented

2024-02-08 04:37:16 +01:00

Member

some weird lines appear on the mesh

Best to open a separate report for this 😅

if you undo twice and then redo it crashes

Reason is same that I mentioned in previous comment

> some weird lines appear on the mesh Best to open a separate report for this 😅 > if you undo twice and then redo it crashes Reason is same that I mentioned in previous comment

ThinkingPolygons commented

2024-02-08 04:54:34 +01:00

Best to open a separate report for this 😅

ok

Reason is same that I mentioned in previous comment

i dont fully understand what you mean in your previous comment tbh

> Best to open a separate report for this 😅 ok > Reason is same that I mentioned in previous comment i dont fully understand what you mean in your previous comment tbh

ThinkingPolygons referenced this issue

2024-02-08 05:07:21 +01:00

Regression: Weird lines on the mesh using sculpt color filter #117971

Hans Goudey added

and removed

labels 2024-02-08 05:16:49 +01:00

Raul Fernandez Hernandez commented

2024-02-27 07:05:11 +01:00

Member

Can confirm this bug. On undo history going back to the original state fails to restore the color of any future state.
The pbvh->color_layer is null when going back to the original state
I suspect a bug the way that first undo step is handled for sculpt filter color
Investigating it further.

Can confirm this bug. On undo history going back to the original state fails to restore the color of any future state. The pbvh->color_layer is null when going back to the original state I suspect a bug the way that first undo step is handled for sculpt filter color Investigating it further.

~~Raul Fernandez Hernandez referenced this issue 2024-02-29 05:10:17 +01:00~~

Fix #117824: Sculpt color filter crash #118885

Hans Goudey referenced a pull request that will close this issue

2024-02-29 14:38:56 +01:00

Fix #117824: Sculpt color filter crash #118885

Raul Fernandez Hernandez referenced this issue from a commit

2024-03-04 16:32:04 +01:00

Fix #117824: Sculpt color filter crash

Raul Fernandez Hernandez closed this issue

2024-03-04 16:32:07 +01:00

Blender Bot added

and removed

labels 2024-03-04 16:32:09 +01:00

Sign in to join this conversation.

No Label

Animation & Rigging

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Viewport & EEVEE

Virtual Reality

Asset Browser Project

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Viewport & EEVEE

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

5 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#117824

No description provided.