Sculpt: Some brushes dont work when dyntopo is enabled #118014
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#118014
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: MacOS Sonoma 14.2
Graphics card: AMD Radeon Pro 5300M 4 GB
Blender Version
Broken: 4.1.0 2024-02-08 00:10
4a50f1d4ee9a
Worked: 4.0.2 2023-12-05 07:41
9be62e85b727
Caused by
bb080140c0
Short description of error
The
Draw
brush appears to make no visible change to the geometry despite subdividing the mesh with Dyntopo enabled. See attached GIFs for comparison:Exact steps for others to reproduce the error
dyntopo_stroke.blend
Draw
brushI'm not certain if this is related, but replicating on a build with asserts enabled and attempting to replicate this trips the following assert:EDIT: Ignore this assert failure - I'm fairly certain that this is an entirely separate issue from the main regression being tracked here now.
Been trying to bisect this to try and find where the change could be I think I've narrowed it to the range ofc9dd5ce4cc1
~2c85561fc31
EDIT: Was mislead by trying to track down the previously mentioned assert failure.
Hi, thanks for the report. Can confirm. Broke between
d0359d066db9 - f4e52f447aa0
Intermediate builds are crashing during sculpt so bit hard to bisect.
Possibly caused by
c78a0f3aa6
Will check
c78a0f3aa6
is still fine, will check furtherAt least Blob, Crease, Draw are affected.
Caused by
bb080140c0
Above commit made the result of
SCULPT_pbvh_calc_area_normal
andSCULPT_calc_area_normal
optional.Previously,
SCULPT_pbvh_calc_area_normal
would work on the formerr_area_no
even if it would eventually return false (this happens e.g. when the first of two methods is used -- see comment below) and not all usages of these functions would actually check "success" (if the formerly returnedany_vertex_sampled
was true or false). It seemscalc_area_normal_and_center_task
can return an area normal based on two very different methods, see this comment:and callers of
SCULPT_pbvh_calc_area_normal
could then decide to use or not use the returned normal (if it comes from a sampled vertex or the "other" method) and even use some other "third" method then, callers ofSCULPT_calc_area_normal
didnt care at all and just used the normal no matter which method this was based on.So we could probably untangle this further by splitting the two "methods" of
calc_area_normal_and_center_task
out into different functions (making it more clear what actually happens, what is used), for now though, we could also just go back to the way it was before... (since this was definitely not just a cleanup commit...)@HooglyBoogly : what do you think?
Sculpt: Draw brush doesn't work when dyntopo is enabledto Sculpt: Some brushes dont work when dyntopo is enabledI got this stack trace:
EDIT: Is the same stack trace as #118014 (comment)
I wouldnt be surprised if this fix causes other issues (like I said, not sure if callers of
SCULPT_pbvh_calc_area_normal
actually relied on the behaviour of the "first method" ofcalc_area_normal_and_center_task
returning false... but I am happily/hopefully proven wrong over time...)