New Color Picker and Color Balance #118153

New Issue

Andrea Monzini · 2024-02-12T19:43:30+01:00

Andrea Monzini commented

2024-02-12 19:43:30 +01:00

System Information
Operating system: Linux-6.6.9-200.fc39.x86_64-x86_64-with-glibc2.38 64 Bits, WAYLAND UI
Graphics card: AMD Radeon RX 580 Series (radeonsi, polaris10, LLVM 17.0.6, DRM 3.54, 6.6.9-200.fc39.x86_64) AMD 4.6 (Core Profile) Mesa 23.3.2

Blender Version
Broken: version: 4.1.0 Beta, branch: blender-v4.1-release, commit date: 2024-02-11 06:16, hash: 835651cfddcb
Worked: 4.0 ( "old" Color Picker ).

Short description of error
with the new color picker, the circle preview selection of the the color wheel appears as a big whitish circle and it is difficult to select visually the right colors using the Color Balance of the VSE and Compositor.
The color selected is correct but the expecting result of the new color picker is different: #113753

The new Color Picker appears correct in other color selections but not in the "Color Balance" of the VSE and Compositor.

Exact steps for others to reproduce the error

In the VSE add the Color Balance strip modifier, increase the color "value" to underline the problem and try to select colors: a big whitish circle selection instead of the nicer colored circle preview:

In the compositor add the Color Balance node, increase the color "value" to underline the problem and try to select colors: a big whitish circle selection instead of the nicer colored circle preview:

As reference the correct new color picker in 4.1 ( different from Color Balance in VSE e Compositor):

**System Information** Operating system: Linux-6.6.9-200.fc39.x86_64-x86_64-with-glibc2.38 64 Bits, WAYLAND UI Graphics card: AMD Radeon RX 580 Series (radeonsi, polaris10, LLVM 17.0.6, DRM 3.54, 6.6.9-200.fc39.x86_64) AMD 4.6 (Core Profile) Mesa 23.3.2 **Blender Version** Broken: version: 4.1.0 Beta, branch: blender-v4.1-release, commit date: 2024-02-11 06:16, hash: `835651cfddcb` Worked: 4.0 ( "old" Color Picker ). **Short description of error** with the new color picker, the circle preview selection of the the color wheel appears as a big whitish circle and it is difficult to select visually the right colors using the Color Balance of the VSE and Compositor. The color selected is correct but the expecting result of the new color picker is different: https://projects.blender.org/blender/blender/pulls/113753 The new Color Picker appears correct in other color selections but not in the "Color Balance" of the VSE and Compositor. **Exact steps for others to reproduce the error** - In the VSE add the Color Balance strip modifier, increase the color "value" to underline the problem and try to select colors: a big whitish circle selection instead of the nicer colored circle preview: ![color_balance_VSE](https://projects.blender.org/attachments/787533b0-6419-4e47-961b-e83e01999b56) - In the compositor add the Color Balance node, increase the color "value" to underline the problem and try to select colors: a big whitish circle selection instead of the nicer colored circle preview: ![color_balance_compositor](https://projects.blender.org/attachments/94ea81cb-4676-4885-a39f-59917236ee02) - As reference the correct new color picker in 4.1 ( different from Color Balance in VSE e Compositor): ![New_Color_Picker](https://projects.blender.org/attachments/162d9f56-75c2-4416-8d7e-2cbb196edf8f)

Screenshot from 2024-02-12 18-47-59.png

172 KiB

Screenshot from 2024-02-12 19-31-37.png

334 KiB

Screenshot from 2024-02-12 20-39-54.png

71 KiB

Andrea Monzini added the

labels 2024-02-12 19:43:31 +01:00

Andrea Monzini changed title from ~~New color Picker and Color Balance~~ to New Color Picker and Color Balance

2024-02-12 19:58:28 +01:00

Harley Acheson commented

2024-02-12 23:21:33 +01:00

Just to clear, this bad behavior only occurs when the HSV "Value" amount is greater than 1.0?

What would you consider to be best behavior in that case? The values could be clamped perhaps:

Or the circle could just be made transparent so you see through it. That would get a bit weird at the edges though:

Just to clear, this bad behavior only occurs when the HSV "Value" amount is greater than 1.0? What would you consider to be best behavior in that case? The values could be clamped perhaps: ![image](/attachments/d52803a4-b769-4749-8fcd-bbfa682880fe) Or the circle could just be made transparent so you see through it. That would get a bit weird at the edges though: ![image](/attachments/96170a81-507c-48a4-9756-86575d419ead)

image.png

69 KiB

image.png

29 KiB

Andrea Monzini commented

2024-02-13 00:23:33 +01:00

thank you for the quick answer.

Just to clear, this bad behavior only occurs when the HSV "Value" amount is greater than 1.0?

The problem is more evident When the HSV "Value" amount is greater than 1.0 but present even under 1.0

What would you consider to be best behavior in that case?

if possible i would prefer the same behavior of the color picker of other color selections:

Otherwise a smaller transparent circle, or the "old" smaller circle/point.
To keep in mind that the "preview" color balance wheels are smaller also, the wheels are bigger only after we open the pop up window clicking on the color "bar" so the selection circle is quite big in relation to the smaller wheels.

Is the code different for Color Balance ?

Another issue with color balance is that the HSV "Value" is changing while i select just the colors in the color wheel ( i loaded a video screen recording file )

thank you for the quick answer. > Just to clear, this bad behavior only occurs when the HSV "Value" amount is greater than 1.0? The problem is more evident When the HSV "Value" amount is greater than 1.0 but present even under 1.0 > What would you consider to be best behavior in that case? if possible i would prefer the same behavior of the color picker of other color selections: ![color_wheel](https://projects.blender.org/attachments/09e1c6db-4dde-4b1f-8d7a-301ecab9ae90) Otherwise a smaller transparent circle, or the "old" smaller circle/point. To keep in mind that the "preview" color balance wheels are smaller also, the wheels are bigger only after we open the pop up window clicking on the color "bar" so the selection circle is quite big in relation to the smaller wheels. Is the code different for Color Balance ? Another issue with color balance is that the HSV "Value" is changing while i select just the colors in the color wheel ( i loaded a video screen recording file )

Screenshot from 2024-02-13 00-14-32.png

75 KiB

screencast.webm

626 KiB

Harley Acheson commented

2024-02-13 01:23:55 +01:00

@AndreaMonzini - Is the code different for Color Balance ?

There code is the same, there is only one color picker.

The problem is more evident When the HSV "Value" amount is greater than 1.0 but present even under 1.0

I'm not seeing that. Can you show examples of it acting different when the value is 1.0 or less?

if possible i would prefer the same behavior of the color picker of other color selections

If I select the same color as your example in Lift then it looks exactly the same:

> @AndreaMonzini - Is the code different for Color Balance ? There code is the same, there is only one color picker. > The problem is more evident When the HSV "Value" amount is greater than 1.0 but present even under 1.0 I'm not seeing that. Can you show examples of it acting different when the value is 1.0 or less? > if possible i would prefer the same behavior of the color picker of other color selections If I select the same color as your example in Lift then it looks exactly the same: ![image](/attachments/923bff11-5603-4bbb-a7a0-09a2da2528a3)

image.png

93 KiB

Andrea Monzini commented

2024-02-13 01:40:46 +01:00

after a lot of tinkering for a solution these are my proposals:

1 - not changing the color wheel background colors at all.
now when we decrease the HSV value it is difficult to see color because the wheels become darker and darker.
while with the HSV greater than 1.0 the color wheel background do not change and create problems with the new circle selection system.
So i suggest to keep the color wheel backgrounds like the is values fixed at 1.0.
And color selection would be visually nicer and consistent all the time as the paradigm of hue and saturation selection.

2 - or increase the HSV value of the background wheel colors over 1.0 even if it will clipping white. Like in the square color picker type HS + v background that it is clipping over 1.0.
In this case the selection circle would have the correspondence with the wheel background.

in any case i would keep the selection circle smaller for the color balance lift/gamma/gaincolor wheels ( that are smaller than the pop up window ) or i will not enable the circle zoom when clicking the mouse/pen.

after a lot of tinkering for a solution these are my proposals: 1 - not changing the color wheel background colors at all. now when we decrease the HSV value it is difficult to see color because the wheels become darker and darker. while with the HSV greater than 1.0 the color wheel background do not change and create problems with the new circle selection system. So i suggest to keep the color wheel backgrounds like the is values fixed at 1.0. And color selection would be visually nicer and consistent all the time as the paradigm of hue and saturation selection. 2 - or increase the HSV value of the background wheel colors over 1.0 even if it will clipping white. Like in the square color picker type HS + v background that it is clipping over 1.0. In this case the selection circle would have the correspondence with the wheel background. - in any case i would keep the selection circle smaller for the color balance lift/gamma/gaincolor wheels ( that are smaller than the pop up window ) or i will not enable the circle zoom when clicking the mouse/pen.

Andrea Monzini commented

2024-02-13 01:58:34 +01:00

I'm not seeing that. Can you show examples of it acting different when the value is 1.0 or less?

here the HSV value is 0.9 and the selection circle in the smaller lift/gamma/gain wheel is lighter, different color respect the color of the smaller background wheel.
In the pop up window it is ok but you have to click the color bar to open the pop up.
with Color Balance usually i work with the smaller lift/gamma/gain/wheels without opening the pop up window.

> I'm not seeing that. Can you show examples of it acting different when the value is 1.0 or less? here the HSV value is 0.9 and the selection circle in the smaller lift/gamma/gain wheel is lighter, different color respect the color of the smaller background wheel. In the pop up window it is ok but you have to click the color bar to open the pop up. with Color Balance usually i work with the smaller lift/gamma/gain/wheels without opening the pop up window. ![](https://projects.blender.org/attachments/e55adb10-6da8-4288-8fc4-9667c423419a)

Screenshot from 2024-02-13 01-55-46.png

182 KiB

Andrea Monzini commented

2024-02-13 02:17:27 +01:00

another problem with the lift/gamma/gain color picker ( both VSE and compositor ) is when i select colors of "gamma" and "gain" the HSV "value" is shifting up and down even if i click only the the color wheel ( not for the "lift" )
this does not happen with the bigger color wheel in the pop up window.

another problem with the lift/gamma/gain color picker ( both VSE and compositor ) is when i select colors of "gamma" and "gain" the HSV "value" is shifting up and down even if i click only the the color wheel ( not for the "lift" ) this does not happen with the bigger color wheel in the pop up window. ![](https://projects.blender.org/attachments/28cd3268-da43-4c43-8737-665db2c27d80)

screen.gif

429 KiB

Harley Acheson commented

2024-02-13 02:18:41 +01:00

In your capture above I see the exact same color value in the circle in the large popup as the circle in the smaller "Lift" one below it and to the right.

In your capture above I see the exact same color value in the circle in the large popup as the circle in the smaller "Lift" one below it and to the right. ![image](/attachments/b5bd8e68-e1c3-41c0-9b94-20435a0b26d3)

image.png

44 KiB

Andrea Monzini commented

2024-02-13 02:28:47 +01:00

and the are problems also for the Offset/Power/Slope color circle selection.
the color selection circle and background colors are different in the smaller color wheels.
While the colors are on in the pop up window.

and the are problems also for the Offset/Power/Slope color circle selection. the color selection circle and background colors are different in the smaller color wheels. While the colors are on in the pop up window. ![](https://projects.blender.org/attachments/159cde14-6d61-4a1c-9b5a-541dc764df51)

Screenshot from 2024-02-13 02-26-57.png

561 KiB

Andrea Monzini commented

2024-02-13 02:29:37 +01:00

In your capture above I see the exact same color value in the circle in the large popup as the circle in the smaller "Lift" one below it and to the right.

yes but the background wheel color is different.
in the pop window there is a correspondence between the selection circle color and background color.
while in the smaller lift/gamma/gain wheel the background color wheel is different.

> In your capture above I see the exact same color value in the circle in the large popup as the circle in the smaller "Lift" one below it and to the right. > > ![image](/attachments/b5bd8e68-e1c3-41c0-9b94-20435a0b26d3) yes but the background wheel color is different. in the pop window there is a correspondence between the selection circle color and background color. while in the smaller lift/gamma/gain wheel the background color wheel is different. ![](https://projects.blender.org/attachments/fc599c22-df3b-4a7b-883e-1efc9e509a0e)

Screenshot from 2024-02-13 02-44-09.png

100 KiB

Andrea Monzini commented

2024-02-13 03:02:27 +01:00

If I select the same color as your example in Lift then it looks exactly the same:

the problem is with smaller color balance wheels.
Even with HSV value at 1.0 but with less saturation the color wheel background is different in the smaller lift/gamma/gain wheel ( there is not the same color correspondence between the selection circle and the background )

> If I select the same color as your example in Lift then it looks exactly the same: the problem is with smaller color balance wheels. Even with HSV value at 1.0 but with less saturation the color wheel background is different in the smaller lift/gamma/gain wheel ( there is not the same color correspondence between the selection circle and the background ) ![](https://projects.blender.org/attachments/4e37975f-899c-4043-a9e3-acef9bbe19e7)

Screenshot from 2024-02-13 02-59-59.png

529 KiB

Pratik Borhade commented

2024-02-13 07:58:57 +01:00

I can confirm when value > 1

Pratik Borhade added

and removed