UI: Color Picker Position Indication #113753

Harley Acheson · 2023-10-16T00:45:09+02:00

Harley Acheson commented

2023-10-16 00:45:09 +02:00

Changes to how the current positions in the color picker are shown.

The color pickers currently show the current selected positions as little white squarish markers. These markers actually cover the actual color you are selecting:

This PR changes the main color selection to a circle that contains the current color (as if that one dot were blown up to the size of the indicator), which enlarges while your mouse button is held down. For the vertical selector it uses a rectangular bar, the background of which is the current level. For each there is an outline of white and of black to ensure contrast:

The square versions works similarly, although the horizontal area uses a rectangular bar with a transparent background:

Yes, the GIF images crush the colors, but you should still be able to see what is going on. I hope.

Changes to how the current positions in the color picker are shown. --- The color pickers currently show the current selected positions as little white squarish markers. These markers actually cover the actual color you are selecting: ![PickerNow.gif](/attachments/5be85c49-08e1-416b-8aa7-a5d100ab5a9e) This PR changes the main color selection to a circle that contains the current color (as if that one dot were blown up to the size of the indicator), which enlarges while your mouse button is held down. For the vertical selector it uses a rectangular bar, the background of which is the current level. For each there is an outline of white and of black to ensure contrast: ![PRRound.gif](/attachments/cece534e-b8ee-4f85-8572-d29185dd672b) The square versions works similarly, although the horizontal area uses a rectangular bar with a transparent background: ![PRSquare.gif](/attachments/ba12e531-6932-4cd5-8df5-ebc48de829db) Yes, the GIF images crush the colors, but you should still be able to see what is going on. I hope.

Picker1.gif

744 KiB

Picker2.gif

604 KiB

PickerNow.gif

230 KiB

👍 9 ❤️ 4

Harley Acheson added 1 commit 2023-10-16 00:45:20 +02:00

abf3f6b88a WIP: UI: Color Picker Position Indication

Changes to how the current positions in the color picker are shown.

Harley Acheson added this to the User Interface project 2023-10-16 00:46:30 +02:00

Harley Acheson requested review from Pablo Vazquez 2023-10-16 00:46:40 +02:00

Harley Acheson changed title from ~~WIP: UI: Color Picker Position Indication~~ to UI: Color Picker Position Indication

2023-10-20 00:17:35 +02:00

Harley Acheson added 1 commit 2023-11-12 18:00:03 +01:00

6c543ec352 Merge branch 'main' of projects.blender.org:blender/blender into PickerPos

Harley Acheson added 2 commits 2023-11-16 19:34:31 +01:00

ddcaa32321 Merge branch 'main' of projects.blender.org:blender/blender into PickerPos

81e79b63ea Add active state changes

Harley Acheson commented

2023-11-16 19:56:19 +01:00

@pablovazquez

As we discussed this PR now gives active state feedback. The selected color circle gets larger while you have your mouse held down. It does make feel much more responsive.

@pablovazquez As we discussed this PR now gives active state feedback. The selected color circle gets larger while you have your mouse held down. It does make feel much more responsive.

Pablo Vazquez approved these changes 2023-11-17 13:49:00 +01:00

Pablo Vazquez left a comment

Much nicer! Thanks!

Harley Acheson added 2 commits 2023-11-17 17:38:30 +01:00

66d908c8f5 Merge branch 'main' of projects.blender.org:blender/blender into PickerPos

buildbot/vexp-code-patch-coordinator Build done. Details

c3343398d8 Comment changes. Const vars.

Harley Acheson commented

2023-11-17 17:44:56 +01:00

@blender-bot build

Harley Acheson added 1 commit 2023-11-17 18:38:42 +01:00