Crash - Outliner: Enter edit mode dot CTRL click #119384

New Issue

Daniel Gryningstjerna · 2024-03-12T15:43:54+01:00

2024-03-12 15:43:54 +01:00

Blender Version
Broken: version: 4.2.0 Alpha, branch: main, commit date: 2024-03-12 10:25, hash: 6a016ce25599
Worked: broken in 4.0 also, not sure if it every worked

Short description of error
Ctrl clicking the instanced meshes in the outliner crahes blender if one of the instances already is in edit mode.

Exact steps for others to reproduce the error
Ctrl click the dot on the Suzanne.001

**Blender Version** Broken: version: 4.2.0 Alpha, branch: main, commit date: 2024-03-12 10:25, hash: `6a016ce25599` Worked: broken in 4.0 also, not sure if it every worked **Short description of error** Ctrl clicking the instanced meshes in the outliner crahes blender if one of the instances already is in edit mode. **Exact steps for others to reproduce the error** Ctrl click the dot on the Suzanne.001 ![image](/attachments/d2f3f20b-1d23-4dad-851f-1e38e1eecc51)

Bug_Ctrl_Enter_Edit_Mode.blend

933 KiB

image.png

15 KiB

Daniel Gryningstjerna added the

labels 2024-03-12 15:43:55 +01:00

Daniel Gryningstjerna changed title from ~~Outliner: Enter edit mode dot CTRL click Crash~~ to Crash - Outliner: Enter edit mode dot CTRL click

2024-03-12 15:45:22 +01:00

Philipp Oeser commented

2024-03-12 16:07:12 +01:00

Can confirm, will check

Philipp Oeser added

and removed

labels 2024-03-12 16:07:34 +01:00

Philipp Oeser commented

2024-03-12 16:32:04 +01:00

The dot should probably not show in the first place, will put on my desk

❤️ 1

Philipp Oeser self-assigned this 2024-03-12 16:32:11 +01:00

Philipp Oeser referenced a pull request that will close this issue

2024-03-13 11:54:20 +01:00

Fix #119384: Outliner crash extend mode toggle on objects sharing data #119416

Philipp Oeser commented

2024-03-13 11:56:00 +01:00

Fix is up, see !119416 , will actually set to High prio since it is a crasher

❤️ 1

Philipp Oeser added

and removed

labels 2024-03-13 11:56:16 +01:00

Philipp Oeser commented

2024-03-14 11:09:30 +01:00

!119416 is apparently not the right solution, will step down for now...

Philipp Oeser removed their assignment 2024-03-14 11:09:39 +01:00

Harley Acheson commented

2024-03-18 21:35:28 +01:00

@JulianEisel There are many different states and corner cases in here that I am probably just missing something.

But in Outliner the item in question makes it through various checks in outliner_draw_mode_column_toggle and gets to the end, where everything gets a mode toggle. In this case it is seen as NOT currently in edit mode so it gets that DOT icon.

But it is in edit mode, so when you click the button we get to do_outliner_item_editmode_toggle and we then try to exit edit mode. So seems like one area of code is thinking this is not in edit mode while another thinks otherwise. So the simplest (but possibly wrong) way to avoid this is just this:

diff --git a/source/blender/editors/space_outliner/outliner_draw.cc b/source/blender/editors/space_outliner/outliner_draw.cc
index 5b56a5cb62d..b8addb626fc 100644
--- a/source/blender/editors/space_outliner/outliner_draw.cc
+++ b/source/blender/editors/space_outliner/outliner_draw.cc
@@ -2178,20 +2178,23 @@ static void outliner_draw_mode_column_toggle(uiBlock *block,
   const bool object_data_shared = (ob->data == ob_active->data);
   draw_active_icon = draw_active_icon || object_data_shared;
 
   int icon;
   const char *tip;
   if (draw_active_icon) {
     icon = UI_icon_from_object_mode(ob_active->mode);
     tip = object_data_shared ? TIP_("Change the object in the current mode") :
                                TIP_("Remove from the current mode");
   }
+  else if (BKE_object_is_in_editmode(ob)) {
+    return;
+  }
   else {
     icon = ICON_DOT;
     tip = TIP_(
         "Change the object in the current mode\n"
         "* Ctrl to add to the current mode");
   }
   UI_block_emboss_set(block, UI_EMBOSS_NONE_OR_STATUS);
   uiBut *but = uiDefIconBut(block,
                             UI_BTYPE_ICON_TOGGLE,
                             0,

@JulianEisel There are many different states and corner cases in here that I am probably just missing something. But in Outliner the item in question makes it through various checks in `outliner_draw_mode_column_toggle` and gets to the end, where everything gets a mode toggle. In this case it is seen as NOT currently in edit mode so it gets that DOT icon. But it **is** in edit mode, so when you click the button we get to `do_outliner_item_editmode_toggle` and we then try to exit edit mode. So seems like one area of code is thinking this is not in edit mode while another thinks otherwise. So the simplest (but possibly wrong) way to avoid this is just this: ```Diff diff --git a/source/blender/editors/space_outliner/outliner_draw.cc b/source/blender/editors/space_outliner/outliner_draw.cc index 5b56a5cb62d..b8addb626fc 100644 --- a/source/blender/editors/space_outliner/outliner_draw.cc +++ b/source/blender/editors/space_outliner/outliner_draw.cc @@ -2178,20 +2178,23 @@ static void outliner_draw_mode_column_toggle(uiBlock *block, const bool object_data_shared = (ob->data == ob_active->data); draw_active_icon = draw_active_icon || object_data_shared; int icon; const char *tip; if (draw_active_icon) { icon = UI_icon_from_object_mode(ob_active->mode); tip = object_data_shared ? TIP_("Change the object in the current mode") : TIP_("Remove from the current mode"); } + else if (BKE_object_is_in_editmode(ob)) { + return; + } else { icon = ICON_DOT; tip = TIP_( "Change the object in the current mode\n" "* Ctrl to add to the current mode"); } UI_block_emboss_set(block, UI_EMBOSS_NONE_OR_STATUS); uiBut *but = uiDefIconBut(block, UI_BTYPE_ICON_TOGGLE, 0, ```

Harley Acheson referenced a pull request that will close this issue

2024-03-20 16:59:06 +01:00

Fix #119384: Outliner Edit Mode Toggle When Data is Shared #119704

Philipp Oeser referenced this issue

2024-03-21 10:01:04 +01:00

Fix #119384: Outliner Edit Mode Toggle When Data is Shared #119704

Hans Goudey referenced a pull request that will close this issue

2024-03-21 14:47:11 +01:00

Fix #119384: Outliner mode column crash with shared object data #119745

Hans Goudey added

Type

Bug