Fix #119384: Outliner Edit Mode Toggle When Data is Shared #119704
No reviewers
Hans Goudey
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#119704
Loading…
Reference in New Issue
No description provided.
Delete Branch "Harley/blender:fix119384"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This report includes a file that demonstrates a crash when ctrl-
clicking the "dot" icon to add to the objects in edit mode. This is
because the object has a mesh shared with another object that is
already in edit mode. This PR allows editing only one object at a
time between objects that share data.
In the following, "Suzanne" and "Suzanne.001" share the same mesh. You can bring either into the edit set by ctrl-clicking, but only one at a time with the others looking disabled. Those have a hint of "Shared data already in edit mode"
@lichtwerk
You were looking at this problem last week. This PR springs from your "The dot should probably not show in the first place" comment. Are you able to take a look at this?
What I actually meant was that instead of the dot it should show the mode icon.
With this PR we now have to rather inconsistent situation that
I mean of course this is better then crashing and of course it is better than having the "wrong" icon for it (and just for that sake it would probably like to see this in 4.1), but it is not what I actually meant with my comment in #119384 :)
Lets see what Hans thinks...
Oh, and this is not only about editmode [checking
BKE_object_is_in_editmode], it could be other modes as well, so this is also something that is not totally right in this PR.Submitted an alternative fix here: #119745
Fix #119384: Outliner Edit Mode Toggle When Instancedto Fix #119384: Outliner Edit Mode Toggle When Data is Shared328c637282toe5a27192e7@blender-bot build
@lichtwerk
This PR is still dead-simple but I think you will like the result now. It will now show the "dot" or "edit" icon properly when appropriate. But the "edit" will look disabled if the object has a shared mesh that another object is already editing. I updated the first comment and added an animated gif to show it off.
Just one small cleanup comment. Looks good.
Longer term maybe we'd want clicking on an object with shared data to take the other objects using that data out of edit mode and putting the new object in edit mode. But for now this is a nice safer approach.
@ -2192,0 +2196,4 @@/* Another object has our (shared) data in edit mode, so nothing we can change. */icon = UI_icon_from_object_mode(ob_active->mode);tip = TIP_("Shared data already in edit mode");uiBut *but = uiDefIconBut(block,To avoid the need to reuse
iconandtipand move their declarations higher upIt would still be nice to have this for e.g. Armatures posemode as well (otoh, these dont crash with Ctrl-clicking the "wrong" dot...)
But this seems to be the best we have so far