Fix #118137: Symmetry buttons on-click state change #118508

Merged
Harley Acheson merged 4 commits from HamilcarR/blender:editor-118137-symmetry_toolbar_sync into main 2024-03-19 18:49:49 +01:00
Contributor

Buttons for mesh symmetry on the toolbar , and other buttons of the same functionality located in other areas of the window , weren't updated when clicking on them.

Buttons for mesh symmetry on the toolbar , and other buttons of the same functionality located in other areas of the window , weren't updated when clicking on them.
Amine Bensalem added 1 commit 2024-02-20 14:34:25 +01:00
Axis symmetry buttons on the toolbar didn't update their state when
their equivalent buttons on other areas were clicked.
Amine Bensalem added 1 commit 2024-02-20 14:36:47 +01:00
Pratik Borhade requested changes 2024-03-15 11:41:55 +01:00
Pratik Borhade left a comment
Member

Hi, thanks for the PR. Looks correct apart from one change :)
I'll add module member for the review (@Harley )

Hi, thanks for the PR. Looks correct apart from one change :) I'll add module member for the review (@Harley )
@ -726,6 +726,7 @@ static void buttons_area_listener(const wmSpaceTypeListenerParams *params)
buttons_area_redraw(area, BCONTEXT_PHYSICS);
/* Needed to refresh context path when changing active particle system index. */
buttons_area_redraw(area, BCONTEXT_PARTICLE);
ED_area_tag_redraw(area);
Member

maybe use buttons_area_redraw(area, BCONTEXT_TOOL);

maybe use `buttons_area_redraw(area, BCONTEXT_TOOL);`
Harley marked this conversation as resolved
Pratik Borhade requested review from Harley Acheson 2024-03-15 11:42:09 +01:00
Pratik Borhade added the
Module
User Interface
label 2024-03-15 11:42:19 +01:00
Member

Yes, this is correct. As long as Pratik's change is made. That buttons_area_redraw is specifically designed for this in that the area will only be redraw if that section is showing.

Yes, this is correct. As long as Pratik's change is made. That `buttons_area_redraw` is specifically designed for this in that the area will only be redraw if that section is showing.
Harley Acheson added 2 commits 2024-03-19 18:46:54 +01:00
Harley Acheson approved these changes 2024-03-19 18:48:03 +01:00
Harley Acheson left a comment
Member

Thanks for working on this!

Thanks for working on this!
Harley Acheson merged commit 1e478cf169 into main 2024-03-19 18:49:49 +01:00
Member

Thanks Harley for updating and merging :)
I'll add this in 3.3/3.6 LTS list

Thanks Harley for updating and merging :) I'll add this in 3.3/3.6 LTS list
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
FBX
Interest
Freestyle
Interest
Geometry Nodes
Interest
glTF
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#118508
No description provided.