blender
/
blender
136
408
Fork 591
Code Issues 6.3k Pull Requests 775 Projects 19 Wiki Activity

EEVEE: Overscan/Border mixed resolution rendering #119524

Merged
Jeroen Bakker merged 5 commits from Jeroen-Bakker/blender:eevee-next/mixed-resolution-rendering-render-border into main 2024-03-18 16:03:09 +01:00
Conversation 0 Commits 5 Files Changed 4 +17 -12
Jeroen Bakker commented 2024-03-15 15:50:02 +01:00
Member
Copy Link

Mixed resolution rendering had some issues with overscan and border
rendering. This PR will fix the issues.

  • render_offset was in display space and not in render space. Is
    now replaced by the overscan_extent.
  • overscan_extent introduced that stored the overscan of the render
    extent.
  • Fixed issues to determine the film sample weight when scaling_factor
    was used. It didn't match decompose the actual offset making the
    length of the same to large, what blurred the final samples.

NOTE: there are some other issues related to border rendering which was
already in main before mixed resolution rendering was added. I assume
that viewport render image in camera view still adds an additional
offset, which should be ignored.

image

Fix #119510
Fix #119511

Mixed resolution rendering had some issues with overscan and border rendering. This PR will fix the issues. - `render_offset` was in display space and not in render space. Is now replaced by the `overscan_extent`. - `overscan_extent` introduced that stored the overscan of the render extent. - Fixed issues to determine the film sample weight when `scaling_factor` was used. It didn't match decompose the actual offset making the length of the same to large, what blurred the final samples. NOTE: there are some other issues related to border rendering which was already in main before mixed resolution rendering was added. I assume that viewport render image in camera view still adds an additional offset, which should be ignored. ![image](/attachments/f0d8c283-bfa9-483d-9fd0-003ea01fdbc3) Fix #119510 Fix #119511
image.png
1.4 MiB
Jeroen Bakker added this to the 4.2 LTS milestone 2024-03-15 15:50:02 +01:00
Jeroen Bakker added the
Interest
EEVEE
Module
EEVEE & Viewport
 labels 2024-03-15 15:50:02 +01:00
Jeroen Bakker self-assigned this 2024-03-15 15:50:02 +01:00
Jeroen Bakker added 1 commit 2024-03-15 15:50:11 +01:00
e76d8670c5 EEVEE-Next: Mixed resolution rendering with render border 
When using mixed resolution rendering with render border the image was
showing incorrect results. This because the source pixels was read
without the border offset.

Fix #119510
Jeroen Bakker added this to the EEVEE & Viewport project 2024-03-15 15:50:16 +01:00
Jeroen Bakker added 1 commit 2024-03-18 09:45:29 +01:00
50fdce9f2c EEVEE: Overscan/Border mixed resolution rendering 
Mixed resolution rendering had some issues with overscan and border
rendering. This PR will fix the issues.

- `render_offset` was in display space and not in render space. Is
  now replaced by the `overscan_extent`.
- `overscan_extent` introduced that stored the overscan of the render
  extent.
- Fixed issues to determine the film sample weight when `scaling_factor`
  was used. It didn't match decompose the actual offset making the
  length of the same to large, what blurred the final samples.

NOTE: there are some other issues related to border rendering which was
already in main before mixed resolution rendering was added. I assume
that viewport render image in camera view still adds an additional
offset, which should be ignored.
Jeroen Bakker changed title from WIP: EEVEE-Next: Mixed resolution rendering with render border to EEVEE: Overscan/Border mixed resolution rendering 2024-03-18 09:46:34 +01:00
Jeroen Bakker requested review from Clément Foucault 2024-03-18 09:47:07 +01:00
Jeroen Bakker changed title from EEVEE: Overscan/Border mixed resolution rendering to WIP: EEVEE: Overscan/Border mixed resolution rendering 2024-03-18 09:53:47 +01:00
Jeroen Bakker added 2 commits 2024-03-18 10:50:01 +01:00
8229f22268 Fix GLSL compiler issue 
Compiler seems to generate bad code...
Jeroen Bakker changed title from WIP: EEVEE: Overscan/Border mixed resolution rendering to EEVEE: Overscan/Border mixed resolution rendering 2024-03-18 10:50:58 +01:00
Clément Foucault approved these changes 2024-03-18 15:00:56 +01:00
Clément Foucault left a comment
Member
Copy Link

LGTM. Just added some nitpick notes.

LGTM. Just added some nitpick notes.
source/blender/draw/engines/eevee_next/eevee_shader_shared.hh Outdated
@ -264,8 +264,8 @@ struct FilmData {
int2 offset;
/** Size of the render buffers when rendering the main views, in pixels. */
Clément Foucault commented 2024-03-18 15:00:23 +01:00
Member
Copy Link

I would add a comment saying that this includes overscan.

I would add a comment saying that this includes overscan.
Jeroen-Bakker marked this conversation as resolved
source/blender/draw/engines/eevee_next/eevee_shader_shared.hh Outdated
@ -266,3 +266,2 @@
int2 render_extent;
/** Offset to convert from Film space to Render space, in pixels. */
int2 render_offset;
/** Extent of overscan inside the render_extent near each corner. */
Clément Foucault commented 2024-03-18 14:59:59 +01:00
Member
Copy Link

Number of bordering pixels inside the render_extent that do not contribute to the final image

`Number of bordering pixels inside the render_extent that do not contribute to the final image`
Jeroen-Bakker marked this conversation as resolved
source/blender/draw/engines/eevee_next/eevee_shader_shared.hh Outdated
@ -267,2 +267,2 @@
/** Offset to convert from Film space to Render space, in pixels. */
int2 render_offset;
/** Extent of overscan inside the render_extent near each corner. */
int2 overscan_extent;
Clément Foucault commented 2024-03-18 14:58:12 +01:00
Member
Copy Link

This is confusing that overscan is int2 instead of int. I would clean that up before landing this.

This is confusing that overscan is `int2` instead of `int`. I would clean that up before landing this.
Jeroen-Bakker marked this conversation as resolved
Jeroen Bakker added 1 commit 2024-03-18 16:01:51 +01:00
Jeroen Bakker merged commit 8945b29762 into main 2024-03-18 16:03:09 +01:00
Jeroen Bakker deleted branch eevee-next/mixed-resolution-rendering-render-border 2024-03-18 16:03:15 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Clément Foucault
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
4.2 LTS
Projects
Clear projects
No project
EEVEE & Viewport
Assignees
Clear assignees
No Assignees
Jeroen Bakker
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#119524
No description provided.
Delete Branch "Jeroen-Bakker/blender:eevee-next/mixed-resolution-rendering-render-border"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?