Select Handles operator doesn't remember preferences from previous call #119487

New Issue

Closed

opened 2024-03-14 21:30:33 +01:00 by Nika Kutsniashvili · 9 comments

Nika Kutsniashvili commented

2024-03-14 21:30:33 +01:00

Contributor

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1650/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 551.23

Blender Version
Broken: version: 4.0.2, branch: blender-v4.0-release, commit date: 2023-12-05 07:41, hash: 9be62e85b727
Worked: (newest version of Blender that worked as expected)

Short description of error
Operator preferences in Blender are saved after first use. You can change them in redo panel and next time you call that operator it uses those settings.

This doesn't work on Select Handles operator in Graph Editor. Every time it's called it resets properties and you have to change them again. It's impossible to set it to always only select right handles and depend on it.

Exact steps for others to reproduce the error

Select all keys in graph editor
Call "Select Handles" operator
In redo panel change properties so that only right handles are selected and keys and left deselected
Deselect and try calling the operator again

It will ignore your settings and will revert to default.

**System Information** Operating system: Windows-10-10.0.19043-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1650/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 551.23 **Blender Version** Broken: version: 4.0.2, branch: blender-v4.0-release, commit date: 2023-12-05 07:41, hash: `9be62e85b727` Worked: (newest version of Blender that worked as expected) **Short description of error** Operator preferences in Blender are saved after first use. You can change them in redo panel and next time you call that operator it uses those settings. This doesn't work on Select Handles operator in Graph Editor. Every time it's called it resets properties and you have to change them again. It's impossible to set it to always only select right handles and depend on it. **Exact steps for others to reproduce the error** 1. Select all keys in graph editor 2. Call "Select Handles" operator 3. In redo panel change properties so that only right handles are selected and keys and left deselected 4. Deselect and try calling the operator again It will ignore your settings and will revert to default.

Nika Kutsniashvili added the

labels 2024-03-14 21:30:34 +01:00

Pratik Borhade commented

2024-03-15 05:54:55 +01:00

Member

Thanks for the report. Can confirm.

Thanks for the report. Can confirm.

Pratik Borhade added

Animation & Rigging

and removed

labels 2024-03-15 05:55:15 +01:00

Pratik Borhade commented

2024-03-15 06:15:08 +01:00

Member

Actually for "select handles" and "select keys", these properties are hardcoded: https://projects.blender.org/blender/blender/src/branch/main/scripts/startup/bl_ui/space_graph.py#L229-L230

We can remove them for "select handles" at least

Actually for "select handles" and "select keys", these properties are hardcoded: https://projects.blender.org/blender/blender/src/branch/main/scripts/startup/bl_ui/space_graph.py#L229-L230 We can remove them for "select handles" at least

Pratik Borhade self-assigned this 2024-03-15 06:16:01 +01:00

Pratik Borhade removed their assignment 2024-03-15 06:16:40 +01:00

Pratik Borhade commented

2024-03-15 06:22:08 +01:00

Member

We can remove them for "select handles" at least

This will cause some noise in following case:
If you call "select keys", it will set both handles to deselect. After this, calling "select handle" won't select either of the handle.
So perhaps make sense to keep the current behavior intact.

One way to fix this is make separate operator for "select keys"

cc @nathanvegdahl @ChrisLend

> We can remove them for "select handles" at least This will cause some noise in following case: If you call "select keys", it will set both handles to `deselect`. After this, calling "select handle" won't select either of the handle. So perhaps make sense to keep the current behavior intact. One way to fix this is make separate operator for "select keys" cc @nathanvegdahl @ChrisLend

Pratik Borhade added

Needs Info from Developers

and removed

labels 2024-03-15 06:22:21 +01:00

Nika Kutsniashvili commented

2024-03-15 09:56:50 +01:00

Author

Contributor

@PratikPB2123 Indeed most logical would be to decouple those two operators, so that case you mentioned doesn't happen in practice. Otherwise current behavior isn't too practical. For mograph work I constantly needed to select right handles and deselect everything and it's quite difficult.

@PratikPB2123 Indeed most logical would be to decouple those two operators, so that case you mentioned doesn't happen in practice. Otherwise current behavior isn't too practical. For mograph work I constantly needed to select right handles and deselect everything and it's quite difficult.

Pratik Borhade commented

2024-03-15 10:07:24 +01:00

Member

Right. For now you can use keymap like this as workaround:

Right. For now you can use keymap like this as workaround: ![image](/attachments/be53da62-544e-42f8-b480-e23d049fde27)

22 KiB

Nathan Vegdahl commented

2024-04-11 10:16:14 +02:00

Member

Sorry for the delayed response on this!

So the issue is basically that there is a single operator Select Key / Handles that is quite flexible, and then the menu items Select Handles and Select Keys use that operator to create hard-coded actions. Conceptually, those menu entries are supposed to only do one thing, and they're just exploiting the existence of this more flexible operator to do that one thing.

If you want different behavior, you can call the main Select Key / Handles operator directly, or make hot keys for it as suggested by @PratikPB2123

This does make me think, however, that we should put the main Select Key / Handles operator itself in the menu as well.

Sorry for the delayed response on this! So the issue is basically that there is a single operator `Select Key / Handles` that is quite flexible, and then the menu items `Select Handles` and `Select Keys` use that operator to create hard-coded actions. Conceptually, those menu entries are supposed to only do one thing, and they're just exploiting the existence of this more flexible operator to do that one thing. If you want different behavior, you can call the main `Select Key / Handles` operator directly, or make hot keys for it as suggested by @PratikPB2123 This does make me think, however, that we should put the main `Select Key / Handles` operator itself in the menu as well.

Nathan Vegdahl commented

2024-04-11 10:33:52 +02:00

Member

To expand on what I said above:

One of my assumptions in the design of this operator is that doing these sorts of quick-select actions is something that people will want quick hotkeys for, rather than calling an operator and then adjusting its parameters every time. So the intention was to create an operator that was flexible enough for people to create whatever behaviors they want for their own hot keys, etc., for the selection actions they do most often.

So if someone does "select left/right handles" often, they would use this operator to create hotkeys for those actions, rather than call Select Handles and adjust the parameters for left/right every time.

I do acknowledge, however, that this isn't great if a user instead wants e.g. menu items for their specific custom actions, since it's a lot more involved for a user to create menu items than hot keys.

To expand on what I said above: One of my assumptions in the design of this operator is that doing these sorts of quick-select actions is something that people will want quick hotkeys for, rather than calling an operator and then adjusting its parameters every time. So the intention was to create an operator that was flexible enough for people to create whatever behaviors they want for their own hot keys, etc., for the selection actions they do most often. So if someone does "select left/right handles" often, they would use this operator to create hotkeys for those actions, rather than call `Select Handles` and adjust the parameters for left/right every time. I do acknowledge, however, that this isn't great if a user instead wants e.g. menu items for their specific custom actions, since it's a lot more involved for a user to create menu items than hot keys.

Pratik Borhade commented

2024-04-11 10:39:07 +02:00

Member

Yes, make sense to create custom keymap entry for different "handle/key selection" combination.

I think we can close this report.

Yes, make sense to create custom keymap entry for different "handle/key selection" combination. I think we can close this report.

Nathan Vegdahl commented

2024-04-11 10:45:44 +02:00

Member

Yeah, I think it's fine to close the report, since this isn't a bug per se and is working as designed.

Nevertheless, I think the feedback here from @nickberckley is valuable, and suggests there may be usage patterns we aren't accommodating well enough yet. So it's definitely something to keep in mind for the future.

Yeah, I think it's fine to close the report, since this isn't a bug per se and is working as designed. Nevertheless, I think the feedback here from @nickberckley is valuable, and suggests there may be usage patterns we aren't accommodating well enough yet. So it's definitely something to keep in mind for the future.

Nathan Vegdahl closed this issue

2024-04-11 10:45:48 +02:00

Blender Bot added

and removed

Needs Info from Developers

labels 2024-04-11 10:45:50 +02:00

Pratik Borhade referenced this issue

2024-04-13 07:45:28 +02:00

Anim: Add 'Select Left' and 'Select Right Handles' entries in Graph Editor #120570

Nika Kutsniashvili referenced this issue

2024-04-14 15:45:28 +02:00

Anim: Add 'Select Left' and 'Select Right Handles' entries in Graph Editor #120570

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#119487

No description provided.