File rename fails on Mac with certain filesystems #119966

New Issue

Maurice-Boone · 2024-03-27T15:14:09+01:00

Maurice-Boone commented

2024-03-27 15:14:09 +01:00

System Information
MAC OS Sonoma 14.3.1
M3 MAX

Blender Version
Broken: 4.1
Worked: 4.0.2

Short description of error
Can't rename output folder when saving to a SanDisk SSD external hard drive. Renaming works when saving directly to computer or a different hard drive. Seems to only be an issue with the SanDisk SSDs. But older versions of Blender worked fine on these external drives.

**System Information** MAC OS Sonoma 14.3.1 M3 MAX **Blender Version** Broken: 4.1 Worked: 4.0.2 **Short description of error** Can't rename output folder when saving to a SanDisk SSD external hard drive. Renaming works when saving directly to computer or a different hard drive. Seems to only be an issue with the SanDisk SSDs. But older versions of Blender worked fine on these external drives.

Maurice-Boone added the

labels 2024-03-27 15:14:10 +01:00

YimingWu commented

2024-03-28 04:24:37 +01:00

Hi @Maurice-Boone , we are not sure about the exact set up of your external hard drive, it could likely be a user permission issue.

Could you check the terminal output and see whether there's a Could not rename: xxx message when you do that?

Hi @Maurice-Boone , we are not sure about the exact set up of your external hard drive, it could likely be a user permission issue. Could you check the terminal output and see whether there's a `Could not rename: xxx` message when you do that?

YimingWu added

Status

Needs Information from User

and removed

Status

Needs Triage

labels 2024-03-28 04:24:58 +01:00

Maurice-Boone commented

2024-03-28 13:54:11 +01:00

Yes. The message says "Could not rename. Operation not supported".

Richard Antalik commented

2024-03-28 17:52:20 +01:00

Looking at the code, this message comes from low level implementation, so it should be legit. Can you rename folder in other file browser (I guess finder on mac)?

Also you mention, that this works with 4.0 version - does it mean, that it worked with 4.0 at some point, or did you check after 4.1 version failed? Asking just to be sure and exclude outside influences...

Looking at the code, this message comes from low level implementation, so it should be legit. Can you rename folder in other file browser (I guess finder on mac)? Also you mention, that this works with 4.0 version - does it mean, that it worked with 4.0 at some point, or did you check after 4.1 version failed? Asking just to be sure and exclude outside influences...

Maurice-Boone commented

2024-03-28 18:16:22 +01:00

I can rename a folder in my finder on mac. I can even rename it on other external hard drives that I have. It's just the SanDisk Extreme SSD that's not renaming folders on. I have two of those hard drives and it doesn't work on either one. I did go back and check on 4.0 and it does work.

Richard Antalik commented

2024-03-28 19:26:09 +01:00

That is interesting... The code calls renamex_np pretty much directly, which is OS system call, so I would assume this to not work in finder as well. Unless there is file/folder with same name already, but then errno should not be set.

First of all, please check, whether another file/folder with name you are assigning already exsists, in such case failure would be expected. Also please check if the file is possibly used by another application.

Notable recent changes in code :

b5c8505f5a
And trio 050d48edfc, b4610f8fc0, 91895bf806

So it is quite possible that this actually is a bug on our side, but we need to know why this happens.

What you can do is check if renaming works from terminal for example with mv command, provide flags of this folder - you can run ls -l where this folder is located, and it would be nice to see how is this drive mounted to the system. Not entirely sure how to do it on Mac, mount command should work I guess. Not sure if there is anything else, but this would be good starting point.

Alternatively, which may be more precise, you could bisect builds to see what commit introduced this issue, but you would have to setup build environment to build Blender from sources, which would take a while to do (see https://developer.blender.org/docs/handbook/building_blender/mac/). Also bisecting in a branch may need a bit of explaining, but it's relatively easy.

CC @ZedDB, @mont29, @ideasman42

That is interesting... The code calls `renamex_np` pretty much directly, which is OS system call, so I would assume this to not work in finder as well. Unless there is file/folder with same name already, but then `errno` should not be set. First of all, please check, whether another file/folder with name you are assigning already exsists, in such case failure would be expected. Also please check if the file is possibly used by another application. Notable recent changes in code : - b5c8505f5a78527511053988408308bad07f6eef - And trio 050d48edfca279249b52dc14e49eff3438f1e8c3, b4610f8fc01cdf781d93f26f34ca4138e6eca0b1, 91895bf8060f7fd120e2cfbdc7a4c46e96d3ab3d So it is quite possible that this actually is a bug on our side, but we need to know why this happens. What you can do is check if renaming works from terminal for example with `mv` command, provide flags of this folder - you can run `ls -l` where this folder is located, and it would be nice to see how is this drive mounted to the system. Not entirely sure how to do it on Mac, `mount` command should work I guess. Not sure if there is anything else, but this would be good starting point. Alternatively, which may be more precise, you could bisect builds to see what commit introduced this issue, but you would have to setup build environment to build Blender from sources, which would take a while to do (see https://developer.blender.org/docs/handbook/building_blender/mac/). Also bisecting in a branch may need a bit of explaining, but it's relatively easy. CC @ZedDB, @mont29, @ideasman42

Sebastian Parborg referenced a pull request that will close this issue

2024-03-28 21:20:29 +01:00

Fix #119966: File rename fails on Mac with certain filesystems #120037

Sebastian Parborg commented

2024-03-28 21:52:21 +01:00

@Maurice-Boone can you try the build from here and see if this solves the issue for you?
https://builder.blender.org/download/patch/PR120037/

@Maurice-Boone can you try the build from here and see if this solves the issue for you? https://builder.blender.org/download/patch/PR120037/

Maurice-Boone commented

2024-03-28 22:38:24 +01:00

I'm a little inexperienced with the terminal commands but I'll give that build a try and report back.

Maurice-Boone commented

2024-03-28 22:46:48 +01:00

I just tried out the 4.2 build and it's the same. It still won't allow me to to rename on the Sandisk hard drive.

Sebastian Parborg commented

2024-03-28 23:32:57 +01:00

Can you check what file system you have on the Sandisk drive?

Maurice-Boone commented

2024-03-28 23:42:51 +01:00

Yes. The SanDisk is formatted as "ExFat". So I went through some older hard drives and the ones that are formatted as ExFat won't let me rename the folders. But the ones formatted as " Mac OS Extended (Journaled)" do.

👀 1

Sebastian Parborg commented

2024-03-29 00:20:39 +01:00

I noticed that I made a mistake in my patch. I've updated it and kicked the build bot. You should be able to download the updated build from the previous URL in about 25 min

Maurice-Boone commented

2024-03-29 00:47:12 +01:00

Got it. Thanks!

Maurice-Boone commented

2024-03-29 01:04:56 +01:00

I can confirm that his build works. Will this patch be applied to 4.1?

Sebastian Parborg commented

2024-03-29 18:00:18 +01:00

I think this might make it into the 4.1.1 corrective release. But I will have to confirm with the release managers

Sebastian Parborg referenced this issue

2024-03-29 18:44:49 +01:00

4.1: Candidates for corrective releases #119631

Sebastian Parborg added

Status

Confirmed

and removed

Status

Needs Information from User

labels 2024-03-29 18:45:15 +01:00

Philipp Oeser changed title from ~~Can't rename folders on SanDisk SSD external hard drive~~ to File rename fails on Mac with certain filesystems

2024-04-02 11:04:53 +02:00

Philipp Oeser added the

Platform

macOS

Module

Platforms, Builds & Tests

labels 2024-04-02 11:05:24 +02:00

Sebastian Parborg referenced this issue from a commit

2024-04-02 12:27:47 +02:00

Fix #119966: File rename fails on Mac with certain filesystems

Sebastian Parborg closed this issue

2024-04-02 12:27:48 +02:00