macOS: Abnormal termination on exit after playback #121015

New Issue

Sergey Sharybin · 2024-04-24T11:59:51+02:00

Sergey Sharybin commented

2024-04-24 11:59:51 +02:00

System Information
Operating system: macOS-14.4.1-arm64-arm-64bit 64 Bits
Graphics card: Metal API Apple M2 Ultra 1.2

Blender Version
Broken: version: 4.2.0 Alpha, branch: main, commit date: 2024-04-23 21:08, hash: ce768d43a121
Worked: Prior 43307b667d

Short description of error

Blender aborts on exit due to incorrect deinitialization in the OpenCloseDevice(). Note the STL documentation of std::thread: If *this has an associated thread (joinable() == true), std::terminate() is called.

There is no code which guarantees that OpenCloseDevice::m_delayed_close_thread is not joinable upon ~OpenCloseDevice(), which leads to the termination, as per the std::thread documentation.

Exact steps for others to reproduce the error

Run blender --factory-startup
Start playback (space bar)
After a bit stop playback
Quit Blender
Observe the message in the terminal

P.S. It is also not fully clear why audio device is created in this case, as there is no audio in the scene. Ideally the audio sub-system is to be initialized if really needed. But this is a bit of a separate issue from this one. (NOTE: The Sync is set to Play Every Frame, so it is not due to the A/V Sync).

**System Information** Operating system: macOS-14.4.1-arm64-arm-64bit 64 Bits Graphics card: Metal API Apple M2 Ultra 1.2 **Blender Version** Broken: version: 4.2.0 Alpha, branch: main, commit date: 2024-04-23 21:08, hash: `ce768d43a121` Worked: Prior 43307b667d9 **Short description of error** Blender aborts on exit due to incorrect deinitialization in the `OpenCloseDevice()`. Note the STL [documentation](https://en.cppreference.com/w/cpp/thread/thread/%7Ethread) of `std::thread`: If `*this` has an associated thread (`joinable() == true`), `std::terminate()` is called. There is no code which guarantees that `OpenCloseDevice::m_delayed_close_thread` is not joinable upon `~OpenCloseDevice()`, which leads to the termination, as per the `std::thread` documentation. **Exact steps for others to reproduce the error** * Run `blender --factory-startup` * Start playback (space bar) * After a bit stop playback * Quit Blender * Observe the message in the terminal P.S. It is also not fully clear why audio device is created in this case, as there is no audio in the scene. Ideally the audio sub-system is to be initialized if really needed. But this is a bit of a separate issue from this one. (NOTE: The Sync is set to `Play Every Frame`, so it is not due to the A/V Sync).

Sergey Sharybin added the

labels 2024-04-24 11:59:52 +02:00

Alaska commented

2024-04-24 12:09:02 +02:00

Confirming issue because I ran into similar issues with a debug builds of Blender earlier this week.

Alaska added

and removed

labels 2024-04-24 12:09:39 +02:00

Richard Antalik commented

2024-04-25 04:12:43 +02:00

Can reproduce, will check

👍 1

Aras Pranckevicius commented

2024-04-26 10:43:03 +02:00

Ah looks like the same I ran into also two days ago: #107607 (comment)

Ah looks like the same I ran into also two days ago: https://projects.blender.org/blender/blender/pulls/107607#issuecomment-1174883

Richard Antalik commented

2024-04-30 05:24:14 +02:00

I have created PR #121242, but will create also one upstream. I can use some review though, since I had to avoid calling virtual function in destructor, which makes this rather ugly IMO.

Sergey Sharybin referenced a pull request that will close this issue

2024-05-01 10:08:54 +02:00

Fix #121015: Abnormal termination on exit after playback on MacOS #121242

Sergey Sharybin referenced this issue

2024-05-03 15:04:59 +02:00

OSX Blender quit unexpectedly #121350

Sign in to join this conversation.