Ctrl-clicking in Outliner to toggle selection has an unresponsive delay/speed limit #121075

New Issue

Albert-OShea · 2024-04-25T14:48:15+02:00

Albert-OShea commented

2024-04-25 14:48:15 +02:00

System Information
Operating system: Windows-10-10.0.22621-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 536.99

Blender Version
Broken: version: 4.1.1, branch: blender-v4.1-release, commit date: 2024-04-15 15:11, hash: e1743a0317bc

Short description of error
Holding Ctrl and clicking things in the outliner seems to have a speed limit that prevents you from performing successive ctrl-clicks.

Exact steps for others to reproduce the error

Have some objects in the outliner.
Ctrl-click some objects on the label, it should select those objects.
Ctrl-click on a selected label to deselect the object, and quickly click it to select again.
It doesn't select, need to wait a little bit for it to be able to be selected again.

In the default startup file, use any object in the outliner to test. Ctrl-click multiple times rapidly on an object label to toggle the selection off and on. You will notice that some clicks are not being registered. It seems to be a limit of about half a second per response. This feels sluggish and unresponsive. As far as I can tell, it is inconsistent with every other selection toggling behavior. For example, rapidly shift-clicking on an object in the 3D viewport will, for the most part, match the speed of your clicks.

**System Information** Operating system: Windows-10-10.0.22621-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 536.99 **Blender Version** Broken: version: 4.1.1, branch: blender-v4.1-release, commit date: 2024-04-15 15:11, hash: `e1743a0317bc` **Short description of error** Holding Ctrl and clicking things in the outliner seems to have a speed limit that prevents you from performing successive ctrl-clicks. **Exact steps for others to reproduce the error** - Have some objects in the outliner. - Ctrl-click some objects on the label, it should select those objects. - Ctrl-click on a selected label to deselect the object, and quickly click it to select again. - It doesn't select, need to wait a little bit for it to be able to be selected again. In the default startup file, use any object in the outliner to test. Ctrl-click multiple times rapidly on an object label to toggle the selection off and on. You will notice that some clicks are not being registered. It seems to be a limit of about half a second per response. This feels sluggish and unresponsive. As far as I can tell, it is inconsistent with every other selection toggling behavior. For example, rapidly shift-clicking on an object in the 3D viewport will, for the most part, match the speed of your clicks.

Albert-OShea added the

labels 2024-04-25 14:48:15 +02:00

YimingWu commented

2024-04-25 15:43:03 +02:00

I would consider this as a bug. I believe this is caused by the double click tolerance. Since double click on icon triggers "select child" operation, the outliner might be waiting for double click. However it should not do this when mouse is hovering the label.

You are probably experiencing this when trying to deselect? Since if I'm selecting it's working fine and responsive no matter how quickly I click.

@pablovazquez what do you think? cc @nathanvegdahl @JulianEisel

I would consider this as a bug. I believe this is caused by the double click tolerance. Since double click on icon triggers "select child" operation, the outliner might be waiting for double click. However it should not do this when mouse is hovering the label. You are probably experiencing this when trying to deselect? Since if I'm selecting it's working fine and responsive no matter how quickly I click. @pablovazquez what do you think? cc @nathanvegdahl @JulianEisel

YimingWu added

Module

User Interface

Status

Needs Info from Developers

and removed

Status

Needs Triage

labels 2024-04-25 15:43:55 +02:00

Albert-OShea commented

2024-04-25 15:48:05 +02:00

Selecting different items with Ctrl-click has no limit, but re-selecting the same item that was just deselected has the limit.

YimingWu commented

2024-04-25 15:52:56 +02:00

Can reproduce as such. Will put it in top description.

Nathan Vegdahl commented

2024-04-26 13:55:39 +02:00

My initial reaction is that if the behavior assigned to double-click only works when double-clicking on the icon and not the label (as seems to be the case), then the double-click event shouldn't be recognized/swallowed by the label in the first place. In that sense this seems buggy to me.

I can imagine that might be difficult to fix, though, since presumably(?) the branching on icon vs label is happening inside the operator after it's already been triggered.

(Speaking as a complete layman here (not my area of the code), I would think that in the future if we want to maintain the icon vs label distinction, that should happen at the keymap level with at least optionally separate bindings for icon vs label, which could then resolve this. But if that's even feasible/sensible to do, it wouldn't be an immediate fix for right now anyway.)

My initial reaction is that if the behavior assigned to double-click only works when double-clicking on the icon and not the label (as seems to be the case), then the double-click event shouldn't be recognized/swallowed by the label in the first place. In that sense this seems buggy to me. I can imagine that might be difficult to fix, though, since presumably(?) the branching on icon vs label is happening inside the operator after it's already been triggered. (Speaking as a complete layman here (not my area of the code), I would think that in the future if we want to maintain the icon vs label distinction, that should happen at the keymap level with at least optionally separate bindings for icon vs label, which could then resolve this. But if that's even feasible/sensible to do, it wouldn't be an immediate fix for right now anyway.)

Philipp Oeser commented

2024-04-26 14:50:53 +02:00

Seems we just need to pass through (OPERATOR_PASS_THROUGH) in a particular case in outliner_item_do_activate_from_cursor so the operator can run again without the recurse option:

diff --git a/source/blender/editors/space_outliner/outliner_select.cc b/source/blender/editors/space_outliner/outliner_select.cc
index b81a9d78ce8..299664bd20c 100644
--- a/source/blender/editors/space_outliner/outliner_select.cc
+++ b/source/blender/editors/space_outliner/outliner_select.cc
@@ -1846,7 +1846,7 @@ static int outliner_item_do_activate_from_cursor(bContext *C,
         }
         else {
           /* Double-clicked, but it wasn't on the icon. */
-          return OPERATOR_CANCELLED;
+          return OPERATOR_CANCELLED | OPERATOR_PASS_THROUGH;
         }
       }
       else {

Seems we just need to pass through (OPERATOR_PASS_THROUGH) in a particular case in `outliner_item_do_activate_from_cursor` so the operator can run again without the `recurse` option: ```diff diff --git a/source/blender/editors/space_outliner/outliner_select.cc b/source/blender/editors/space_outliner/outliner_select.cc index b81a9d78ce8..299664bd20c 100644 --- a/source/blender/editors/space_outliner/outliner_select.cc +++ b/source/blender/editors/space_outliner/outliner_select.cc @@ -1846,7 +1846,7 @@ static int outliner_item_do_activate_from_cursor(bContext *C, } else { /* Double-clicked, but it wasn't on the icon. */ - return OPERATOR_CANCELLED; + return OPERATOR_CANCELLED | OPERATOR_PASS_THROUGH; } } else { ```

Philipp Oeser referenced a pull request that will close this issue

2024-04-26 15:02:18 +02:00

Fix #121075: Outliner Ctrl-clicking to toggle selection has speed limit #121130

Philipp Oeser self-assigned this 2024-04-26 15:04:35 +02:00

Sign in to join this conversation.