Regression: Weight paint with brush tool does not work #121155

New Issue

Andrea-Lanaro · 2024-04-27T09:02:03+02:00

Andrea-Lanaro commented

2024-04-27 09:02:03 +02:00

System Information
Operating system: Windows-10-10.0.17763-SP0
Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 | 4.6.0 NVIDIA 551.86

Blender Version
Broken: 4.2.0 (2024-04-26) d11c6962b0
Worked: 4.2.0 (2024-04-25) 1b04a0d494
Caused by 4d49c78e74

Short description of error
Weight paint with brush tool does not work on anything except starting cube.
Gradient and sample weight still function.

Exact steps for others to reproduce the error

Default start up.
Add mesh object.
Enter weight paint mode.
Paint with brush tool.

**System Information** Operating system: Windows-10-10.0.17763-SP0 Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 | 4.6.0 NVIDIA 551.86 **Blender Version** Broken: 4.2.0 (2024-04-26) d11c6962b099 Worked: 4.2.0 (2024-04-25) 1b04a0d4949d Caused by 4d49c78e74f0b53b348111a487eece05b3e7e5ab **Short description of error** Weight paint with brush tool does not work on anything except starting cube. Gradient and sample weight still function. **Exact steps for others to reproduce the error** 1. Default start up. 2. Add mesh object. 3. Enter weight paint mode. 4. Paint with brush tool.

Andrea-Lanaro added the

labels 2024-04-27 09:02:03 +02:00

Iliya Katushenock changed title from ~~Weight paint with brush tool does not work~~ to Regression: Weight paint with brush tool does not work

2024-04-27 15:47:24 +02:00

Richard Antalik commented

2024-04-28 05:40:11 +02:00

Can confirm. Will bisect.

🎉 1

Richard Antalik commented

2024-04-28 05:56:14 +02:00

Cased by 4d49c78e74, CC @lichtwerk

Cased by 4d49c78e74f0b53b348111a487eece05b3e7e5ab, CC @lichtwerk

Richard Antalik added

Module

Sculpt, Paint & Texture

and removed

labels 2024-04-28 05:56:38 +02:00

Philipp Oeser referenced this issue from a commit

2024-04-28 11:37:09 +02:00

revert 4d49c78e74f0b53b348111a487eece05b3e7e5ab

Philipp Oeser commented

2024-04-28 11:40:10 +02:00

Reverted 4d49c78e74 for now, see 0bf4568abd.
Will do a proper fix on Monday, but this report here should be solved with the revert.

Reverted 4d49c78e74 for now, see 0bf4568abdd607f1bcbc9359eebddfcfb2827f32. Will do a proper fix on Monday, but this report here should be solved with the revert.

Philipp Oeser closed this issue

2024-04-28 11:40:14 +02:00

Blender Bot added

and removed

labels 2024-04-28 11:40:25 +02:00

Philipp Oeser commented

2024-04-29 10:13:21 +02:00

FYI, the problem was caused by the fact that for weightpaint, we also have the setting Mirror Vertex Groups.

If that is enabled, and that is a default for new meshes -- not for the default cube though (not sure why that is [possibly an oversight in fa9b05149c @zeddb]) -- so if that is enabled, then the whole symmetry handling was skipped.

I could easily tweak !120931 so that is considered, but there is a bit of confusion (at least on my end) now:
fa9b05149c also disabled radial symmetry from the UI even though it is still executed and also mirrored to the "other" vertexgroup just fine

col.active = not obj.data.use_mirror_vertex_groups
col.prop(vpaint, "radial_symmetry", text="Radial")

Maybe @ZedDB , @dr.sybren or @JulienKaspar could clarify what the intention here is? I assume the above code snippet is just wrong, radial symmetry could/should be done with mirroring (no matter if Mirror Vertex Groups is used or not). This would have an impact on a second version of !120931.

FYI, the problem was caused by the fact that for weightpaint, we also have the setting `Mirror Vertex Groups`. If that is enabled, and that is a default for new meshes -- not for the default cube though (not sure why that is [possibly an oversight in fa9b05149c2c @zeddb]) -- so if that is enabled, then the whole symmetry handling was skipped. I could easily tweak !120931 so that is considered, but there is a bit of confusion (at least on my end) now: fa9b05149c2c also disabled radial symmetry from the UI even though it is still executed and also mirrored to the "other" vertexgroup just fine ``` col.active = not obj.data.use_mirror_vertex_groups col.prop(vpaint, "radial_symmetry", text="Radial") ``` Maybe @ZedDB , @dr.sybren or @JulienKaspar could clarify what the intention here is? I assume the above code snippet is just wrong, radial symmetry could/should be done with mirroring (no matter if `Mirror Vertex Groups` is used or not). This would have an impact on a second version of !120931.

Sebastian Parborg commented

2024-04-29 11:31:12 +02:00

If that is enabled, and that is a default for new meshes -- not for the default cube though (not sure why that is [possibly an oversight

I would say that we overlooked this, yes.
Symmetry shouldn't be on per default on new meshes.

also disabled radial symmetry from the UI even though it is still executed and also mirrored to the "other" vertexgroup just fine

IIRC, this was done as Julian reported that radial mirroring wasn't working in weight paint.
I could remember this incorrectly though.

> If that is enabled, and that is a default for new meshes -- not for the default cube though (not sure why that is [possibly an oversight I would say that we overlooked this, yes. Symmetry shouldn't be on per default on new meshes. > also disabled radial symmetry from the UI even though it is still executed and also mirrored to the "other" vertexgroup just fine > IIRC, this was done as Julian reported that radial mirroring wasn't working in weight paint. I could remember this incorrectly though.

Philipp Oeser commented

2024-04-29 11:53:35 +02:00

If that is enabled, and that is a default for new meshes -- not for the default cube though (not sure why that is [possibly an oversight

I would say that we overlooked this, yes.
Symmetry shouldn't be on per default on new meshes.

We should then remove .editflag = ME_EDIT_MIRROR_VERTEX_GROUPS \ ?

also disabled radial symmetry from the UI even though it is still executed and also mirrored to the "other" vertexgroup just fine

IIRC, this was done as Julian reported that radial mirroring wasn't working in weight paint.
I could remember this incorrectly though.

Would be interesting to know where this was not working @JulienKaspar , if really broken, we should then do

diff --git a/source/blender/editors/sculpt_paint/paint_weight.cc b/source/blender/editors/sculpt_paint/paint_weight.cc
index bfe86145c1d..46873cc2731 100644
--- a/source/blender/editors/sculpt_paint/paint_weight.cc
+++ b/source/blender/editors/sculpt_paint/paint_weight.cc
@@ -1733,9 +1733,6 @@ static void wpaint_do_symmetrical_brush_actions(
   /* initial stroke */
   cache->mirror_symmetry_pass = ePaintSymmetryFlags(0);
   wpaint_do_paint(C, ob, wp, sd, wpd, wpi, mesh, brush, ePaintSymmetryFlags(0), 'X', 0, 0);
-  wpaint_do_radial_symmetry(C, ob, wp, sd, wpd, wpi, mesh, brush, ePaintSymmetryFlags(0), 'X');
-  wpaint_do_radial_symmetry(C, ob, wp, sd, wpd, wpi, mesh, brush, ePaintSymmetryFlags(0), 'Y');
-  wpaint_do_radial_symmetry(C, ob, wp, sd, wpd, wpi, mesh, brush, ePaintSymmetryFlags(0), 'Z');
 
   cache->symmetry = symm;

> > If that is enabled, and that is a default for new meshes -- not for the default cube though (not sure why that is [possibly an oversight > > I would say that we overlooked this, yes. > Symmetry shouldn't be on per default on new meshes. We should then remove `.editflag = ME_EDIT_MIRROR_VERTEX_GROUPS \` ? > > also disabled radial symmetry from the UI even though it is still executed and also mirrored to the "other" vertexgroup just fine > > > > IIRC, this was done as Julian reported that radial mirroring wasn't working in weight paint. > I could remember this incorrectly though. Would be interesting to know where this was not working @JulienKaspar , if really broken, we should then do ```diff diff --git a/source/blender/editors/sculpt_paint/paint_weight.cc b/source/blender/editors/sculpt_paint/paint_weight.cc index bfe86145c1d..46873cc2731 100644 --- a/source/blender/editors/sculpt_paint/paint_weight.cc +++ b/source/blender/editors/sculpt_paint/paint_weight.cc @@ -1733,9 +1733,6 @@ static void wpaint_do_symmetrical_brush_actions( /* initial stroke */ cache->mirror_symmetry_pass = ePaintSymmetryFlags(0); wpaint_do_paint(C, ob, wp, sd, wpd, wpi, mesh, brush, ePaintSymmetryFlags(0), 'X', 0, 0); - wpaint_do_radial_symmetry(C, ob, wp, sd, wpd, wpi, mesh, brush, ePaintSymmetryFlags(0), 'X'); - wpaint_do_radial_symmetry(C, ob, wp, sd, wpd, wpi, mesh, brush, ePaintSymmetryFlags(0), 'Y'); - wpaint_do_radial_symmetry(C, ob, wp, sd, wpd, wpi, mesh, brush, ePaintSymmetryFlags(0), 'Z'); cache->symmetry = symm; ```

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Regression: Weight paint with brush tool does not work #121155