Fix: weight and vertex paint radial symmetry wrong with mirror #120931

Philipp Oeser · 2024-04-22T14:14:07+02:00

Philipp Oeser commented

2024-04-22 14:14:07 +02:00

Both vertexpaint and weightpaint would only apply all of radial symmetry
for the "initial stroke".
When going over the combinations of symmetry axis, some of radial
symmetry would be skipped, e.g. when mirroring from right to left with
Mirror X turned ON, a dab on the right would have radial symmetry from
that point, and an additional dab on the left from mirroring (but the
mirrored dab would not have radial symmetry on its own).

This does not lead to symmetric results at all, sculptmode also does not
behave that way (there, radial symmetry is performed on the mirror axis
as well).

Now do the same thing as in sculptmode to get symmetric results when
using mirror and radial symmetry together.
Also use the utility function to skip invalid symmetry iterations.

Stumbled over this when looking into #120843

Both vertexpaint and weightpaint would only apply all of radial symmetry for the "initial stroke". When going over the combinations of symmetry axis, some of radial symmetry would be skipped, e.g. when mirroring from right to left with `Mirror X` turned ON, a dab on the right would have radial symmetry from that point, and an additional dab on the left from mirroring (but the mirrored dab would not have radial symmetry on its own). This does not lead to symmetric results at all, sculptmode also does not behave that way (there, radial symmetry is performed on the mirror axis as well). Now do the same thing as in sculptmode to get symmetric results when using mirror and radial symmetry together. Also use the utility function to skip invalid symmetry iterations. Stumbled over this when looking into #120843

Philipp Oeser added 1 commit 2024-04-22 14:14:17 +02:00

c7f32525b2 Fix: weight and vertex paint radial symmetry wrong with mirror

Both vertexpaint and weightpaint would only apply all of radial symmetry
for the "initial stroke".
When going over the combinations of symmetry axis, some of radial
symmetry would be skipped, e.g. when mirroring from right to left with
`Mirror X` turned ON, a dab on the right would have radial symmetry from
that point, and an additional dab on the left from mirroring (but the
mirrored dab would not have radial symmetry on its own).

This does not lead to symmetric results at all, sculptmode also does not
behave that way (there, radial symmetry is performed on the mirror axis
as well).

Now do the same thing as in sculptmode to get symmetric results when
using mirror and radial symmetry together.
Also use the utility function to skip invalid symmetry iterations.

Stumbled over this when looking into #120843

Philipp Oeser added this to the Sculpt, Paint & Texture project 2024-04-22 14:16:37 +02:00

Philipp Oeser requested review from Julien Kaspar 2024-04-22 14:16:47 +02:00

Philipp Oeser requested review from Campbell Barton 2024-04-22 14:16:57 +02:00

Campbell Barton approved these changes 2024-04-24 12:14:26 +02:00

Campbell Barton left a comment

Since this is copied and I assume you tested well, I don't see a problem with it, however I think it's worth cross referencing do_symmetrical_brush_actions sculpt <-> vertex paint - in code-comments. So this doesn't get out of sync again.

Since this is copied and I assume you tested well, I don't see a problem with it, however I think it's worth cross referencing `do_symmetrical_brush_actions` sculpt <-> vertex paint - in code-comments. So this doesn't get out of sync again.

Philipp Oeser added 1 commit 2024-04-26 07:46:12 +02:00

dd791cdc66 improve cooments

Philipp Oeser merged commit 4d49c78e74 into main

2024-04-26 07:51:22 +02:00

Philipp Oeser referenced this issue from a commit

2024-04-26 07:51:23 +02:00

Fix: weight and vertex paint radial symmetry wrong with mirror

Philipp Oeser deleted branch 120843_b

2024-04-26 07:51:25 +02:00

Philipp Oeser referenced this issue from a commit

2024-04-28 11:37:09 +02:00

revert 4d49c78e74f0b53b348111a487eece05b3e7e5ab