Grease Pencil merge tasks #54893

New Issue

Joshua Leung · 2018-04-30T10:12:16+02:00

Joshua Leung commented

2018-04-30 10:12:16 +02:00

Parent task to keep track of all GP branch merge related tasks.

Differential (mega-patch) task, with more links: D2889

Blocking Subtasks / Changes required before merge

~~Migrate Palettes and Palette Colors to Materials.~~ - Needs code review. Some UI design issues remain (#54896)
~~Solve Depsgraph issues adding multiple GP Objects.~~
Enable depsgraph relationships with Materials.
~~Rename Array modifier.~~ - Is now known as the "Instance" modifier 7a5747d5596
~~Convert operators to COW. - In progress.~~
- ~~Set up API for accessing COW evaluated GP data~~ 356ce71a5f2 [Joshua]
- ~~Tag GP datablocks as needing updates~~ [Antonio]
- ~~Check operators to know that COW data in appropriate operators is configured~~ [Joshua/Antonio]
~~Refactor of UI, using new toolbars.~~ [Postponed till after after merge. See #54896 for design decisions]
~~Disable temporarily VFX modifiers.~~ - These are now removed from the branch. A replacement design can be worked on after the merge (as a more general system)
~~Fix issues (naming, DNA/draw-api/ID-handling, etc.) identified during code review~~ (#55002)
~~Fix vertex group data storage issues identified during code review~~ (#55002)

Postponed Issues

Convert Modifiers to use COW. [Too complex to get working before during codequest / before 2.8 DNA lockdown/Spring deadline]
- Recode evaluation internals to occur in DEG callback instead of in draw manager + Remove current ghash-cache [Joshua]
- Update modifiers [Joshua/Antonio]
~~Annotations support - i.e. "basic" GP features - as in 2.75/6, for non-3D view, workflow non-art use cases~~ (#55455)

Other Todo's

Updated design docs (on wiki)
User documentation

Parent task to keep track of all GP branch merge related tasks. Differential (mega-patch) task, with more links: [D2889](https://archive.blender.org/developer/D2889) # Blocking Subtasks / Changes required before merge - ~~Migrate Palettes and Palette Colors to Materials.~~ - Needs code review. Some UI design issues remain (#54896) - ~~Solve Depsgraph issues adding multiple GP Objects.~~ - Enable depsgraph relationships with Materials. - ~~Rename Array modifier.~~ - Is now known as the "Instance" modifier 7a5747d5596 - ~~Convert operators to COW. - In progress.~~ - ~~Set up API for accessing COW evaluated GP data~~ 356ce71a5f2 [Joshua] - ~~Tag GP datablocks as needing updates~~ [Antonio] - ~~Check operators to know that COW data in appropriate operators is configured~~ [Joshua/Antonio] - ~~Refactor of UI, using new toolbars.~~ [Postponed till after after merge. See #54896 for design decisions] - ~~Disable temporarily VFX modifiers.~~ - These are now removed from the branch. A replacement design can be worked on after the merge (as a more general system) - ~~Fix issues (naming, DNA/draw-api/ID-handling, etc.) identified during code review~~ (#55002) - ~~Fix vertex group data storage issues identified during code review~~ (#55002) ## Postponed Issues - Convert Modifiers to use COW. [**Too complex to get working before during codequest / before 2.8 DNA lockdown/Spring deadline**] - Recode evaluation internals to occur in DEG callback instead of in draw manager + Remove current ghash-cache [Joshua] - Update modifiers [Joshua/Antonio] - ~~Annotations support - i.e. "basic" GP features - as in 2.75/6, for non-3D view, workflow non-art use cases~~ (#55455) # Other Todo's * Updated design docs (on wiki) * User documentation

Joshua Leung self-assigned this 2018-04-30 10:12:16 +02:00

Joshua Leung commented

2018-04-30 10:12:16 +02:00

Added subscriber: @JoshuaLeung

Antonio Vazquez commented

2018-04-30 11:14:23 +02:00

Added subscriber: @antoniov

Antonio Vazquez commented

2018-04-30 11:14:23 +02:00

We have the following subtask:

~~Migrate Palettes and Palette Colors to Materials.~~
~~Solve Depsgraph issues adding multiple GP Objects.~~
~~Enable depsgraph relationships with Materials.~~
~~Rename Array modifier.~~
Convert Modifiers to use COW. ->After merge
~~Convert operators to COW.~~
Refactor of UI, using new toolbars. ->After merge
~~Disable temporarily VFX modifiers.~~
~~Refactor weight data to use MDeformVert/MDeformWeight structs.~~

@JoshuaLeung do you need add them in phabricator as subtask?

We have the following subtask: - ~~Migrate Palettes and Palette Colors to Materials.~~ - ~~Solve Depsgraph issues adding multiple GP Objects.~~ - ~~Enable depsgraph relationships with Materials.~~ - ~~Rename Array modifier.~~ - Convert Modifiers to use COW. **->After merge** - ~~Convert operators to COW.~~ - Refactor of UI, using new toolbars. **->After merge** - ~~Disable temporarily VFX modifiers.~~ - ~~Refactor weight data to use MDeformVert/MDeformWeight structs.~~ @JoshuaLeung do you need add them in phabricator as subtask?

Joshua Leung commented

2018-04-30 14:28:50 +02:00

Regarding the UI (topbar/toolbar) changes:
After discussing with Campbell, it's probably better that we leave any changes here to after the merge. The toolbar stuff is still very much a moving target, so it's best to let that settle down for a week or so first. But, in the meantime, we can still continue any UI design work in preparation for that point.

Regarding the UI (topbar/toolbar) changes: After discussing with Campbell, it's probably better that we leave any changes here to after the merge. The toolbar stuff is still very much a moving target, so it's best to let that settle down for a week or so first. But, in the meantime, we can still continue any UI design work in preparation for that point.

Antonio Vazquez commented

2018-04-30 17:24:39 +02:00

I have completed the rename of Array modifier to Instance Modifier.

Joshua Leung commented

2018-05-01 12:52:33 +02:00

@antoniov:
If/while you're waiting for other cleanups to do, go through and replace all the BKE_gpencil_batch_cache_dirty(gpd); calls in the GP operator code with DEG_id_tag_update(id, OB_RECALC_OB | OB_RECALC_DATA);

@antoniov: If/while you're waiting for other cleanups to do, go through and replace all the `BKE_gpencil_batch_cache_dirty(gpd);` calls in the GP operator code with `DEG_id_tag_update(id, OB_RECALC_OB | OB_RECALC_DATA);`

Antonio Vazquez commented

2018-05-01 12:53:48 +02:00

@JoshuaLeung Ok, I'm going to change BKE_gpencil_batch_cache_dirty(gpd).

Antonio Vazquez commented

2018-05-01 12:56:10 +02:00

@JoshuaLeung I guess you mean:

DEG_id_tag_update(gpd->id, OB_RECALC_OB | OB_RECALC_DATA);

@JoshuaLeung I guess you mean: ``` DEG_id_tag_update(gpd->id, OB_RECALC_OB | OB_RECALC_DATA); ```

Antonio Vazquez commented

2018-05-01 13:53:30 +02:00

@JoshuaLeung I think this is what you wanted: 8098dc3d108c

Let me know if I need change it (specially anim_channels_defines.c, I was not totally sure about this).

@JoshuaLeung I think this is what you wanted: 8098dc3d108c Let me know if I need change it (specially **anim_channels_defines.c**, I was not totally sure about this).

Joshua Leung commented

2018-05-04 16:07:58 +02:00

I've just done a merge of 2.8 into the branch. We should now be up to date again, to keep working in sync, until the upcoming collections changes break things again.

Antonio Vazquez commented

2018-05-07 19:08:20 +02:00

@JoshuaLeung I have tested:

Depsgraph issues adding multiple GP Objects

With last 2.8 merge works, so we can set task as done.

@JoshuaLeung I have tested: > Depsgraph issues adding multiple GP Objects With last 2.8 merge works, so we can set task as done.

Adrian commented

2018-05-15 01:17:48 +02:00

Added subscriber: @AdrianCabrera

Antonio Vazquez commented

2018-05-16 17:59:00 +02:00

Added subscriber: @ideasman42

Antonio Vazquez commented

2018-05-16 17:59:00 +02:00

After receive the feedback from @ideasman42 and @JoshuaLeung I have moved the weights data from the points from bGPDspoint struct to bGPDstroke and I have created a separated array of MDeformVert (and MDeformWeight). Now the weighst use the same logic used for Meshes and Lattice.

I had to make a lot of changes in memory allocation, so this big refactor could produce some bug. We will test during next days to fix any issue.

This change has broken a little more the compatibility with Hero open movie files, but as we had a lot of breaks already, this is only one more.

After receive the feedback from @ideasman42 and @JoshuaLeung I have moved the weights data from the points from bGPDspoint struct to bGPDstroke and I have created a separated array of MDeformVert (and MDeformWeight). Now the weighst use the same logic used for Meshes and Lattice. I had to make a lot of changes in memory allocation, so this big refactor could produce some bug. We will test during next days to fix any issue. This change has broken a little more the compatibility with Hero open movie files, but as we had a lot of breaks already, this is only one more.

Antonio Vazquez commented

2018-05-30 10:35:19 +02:00

ToDo tasks:

· Review Keymaps conflicts ( see #55162)
· Review mode switching with new keymaps

There are conflicts with some keymaps, like brush change, with the new mode change keymaps. (Some were removed here aa722e8193a6)

We need adapt the shared modes (for example 5 key) to switch to GP draw mode for OB_GPENCIL Objects.

ToDo tasks: · Review Keymaps conflicts ( see #55162) · Review mode switching with new keymaps There are conflicts with some keymaps, like brush change, with the new mode change keymaps. (Some were removed here aa722e8193a6) We need adapt the shared modes (for example 5 key) to switch to GP draw mode for OB_GPENCIL Objects.

gobb_blend commented

2018-06-30 23:14:38 +02:00

Added subscriber: @gobb_blend

Brecht Van Lommel changed title from ~~Grease Pencil Branch Merge (Parent Task)~~ to Grease Pencil Tasks

2018-08-13 11:34:10 +02:00

Brecht Van Lommel changed title from ~~Grease Pencil Tasks~~ to Grease Pencil (parent task)

2018-08-13 11:36:28 +02:00

gobb_blend commented

2018-11-19 13:45:23 +01:00

Removed subscriber: @gobb_blend

Brecht Van Lommel changed title from ~~Grease Pencil (parent task)~~ to Grease Pencil merge tasks

2018-11-19 14:23:24 +01:00

Antonio Vazquez commented

2019-05-28 17:17:02 +02:00

Changed status from 'Open' to: 'Resolved'

Antonio Vazquez closed this issue

2019-05-28 17:17:02 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Grease Pencil merge tasks #54893

Blocking Subtasks / Changes required before merge

Postponed Issues

Other Todo's