Keyframing one transform option reset other transforms #58721

New Issue

Alexander Otto · 2018-12-04T16:49:08+01:00

Alexander Otto commented

2018-12-04 16:49:08 +01:00

System Information
Operating system: Windows 10
Graphics card: 2x 1080 Ti

Blender Version
Broken: 2.80, 1b6a394d86, 2018-12-03 23:39

Short description of error
If you have an animated object, lets say location and rotation have keyframes, and you animate (not keyframe) both location and rotation further down the line, and then decide to keyframe location by Shortcut I -> Location or Right Click on the property, the other property gets reset to the last known value.
Yes I could keyframe both properties at the same time but that behavior is still odd.

Exact steps for others to reproduce the error
Based on the default startup or an attached .blend file (as simple as possible).

**System Information** Operating system: Windows 10 Graphics card: 2x 1080 Ti **Blender Version** Broken: 2.80, 1b6a394d862, 2018-12-03 23:39 **Short description of error** If you have an animated object, lets say location and rotation have keyframes, and you animate (not keyframe) both location and rotation further down the line, and then decide to keyframe location by Shortcut I -> Location or Right Click on the property, the other property gets reset to the last known value. Yes I could keyframe both properties at the same time but that behavior is still odd. **Exact steps for others to reproduce the error** Based on the default startup or an attached .blend file (as simple as possible).

Alexander Otto commented

2018-12-04 16:49:08 +01:00

Added subscriber: @AlexanderOtto

blender-admin commented

2018-12-04 16:49:08 +01:00

#62453 was marked as duplicate of this issue

blender-admin commented

2018-12-04 16:49:08 +01:00

#62344 was marked as duplicate of this issue

blender-admin commented

2018-12-04 16:49:08 +01:00

#61173 was marked as duplicate of this issue

blender-admin commented

2018-12-04 16:49:08 +01:00

#62082 was marked as duplicate of this issue

blender-admin commented

2018-12-04 16:49:08 +01:00

#62054 was marked as duplicate of this issue

blender-admin commented

2018-12-04 16:49:08 +01:00

#61812 was marked as duplicate of this issue

blender-admin commented

2018-12-04 16:49:08 +01:00

#59820 was marked as duplicate of this issue

Sebastian Parborg commented

2018-12-14 18:36:17 +01:00

Added subscriber: @ZedDB

Joshua Leung was assigned by Sebastian Parborg

2018-12-14 18:36:17 +01:00

Sebastian Parborg commented

2018-12-14 18:36:17 +01:00

This did not happen in 2.79. So this is a regression.

Sebastian Parborg commented

2018-12-28 13:16:40 +01:00

Added subscriber: @user1

Sebastian Parborg commented

2019-02-22 11:14:17 +01:00

Added subscribers: @jefrau, @Mets

Sebastian Parborg commented

2019-02-22 11:16:14 +01:00

This also happens with multiple keyed bones #61812.

Jacques Lucke commented

2019-02-28 17:48:40 +01:00

Added subscriber: @Rado.N

Jacques Lucke commented

2019-02-28 17:49:58 +01:00

Added subscriber: @JacquesLucke

Jacques Lucke commented

2019-02-28 17:49:58 +01:00

@Rado.N, feel free to post that video here again, thanks for that.

Radoslav Nedyalkov commented

2019-02-28 19:23:24 +01:00

Posting the video of the problem as suggested by @JacquesLucke.
Just to clarify this is not limited to location only.

Rep 01.mp4

Posting the video of the problem as suggested by @JacquesLucke. Just to clarify this is not limited to location only. [Rep 01.mp4](https://archive.blender.org/developer/F6731778/Rep_01.mp4)

Joshua Leung commented

2019-03-01 14:16:51 +01:00

Added subscriber: @ShunsukeSaito

Joshua Leung commented

2019-03-01 14:24:13 +01:00

Added subscribers: @CultLess, @JoshuaLeung, @s.barbieri, @ditos, @brecht

Joshua Leung commented

2019-03-08 12:34:38 +01:00

Added subscribers: @netricsa, @MarcinTwarowski, @WilliamReynish

Brecht Van Lommel commented

2019-03-11 16:16:51 +01:00

Added subscriber: @larsdd_b

Brecht Van Lommel commented

2019-03-13 01:37:36 +01:00

Added subscriber: @Sergey

Brecht Van Lommel commented

2019-03-13 01:37:36 +01:00

#61173#628747 has some analysis of the problem.

Animation is being evaluated after inserting a keyframe, since 06357b23a2. I think we need a way to DEG tag an action datablock to say that it needs copy-on-write without evaluating animation, and use that for inserting and deleting keyframes. For other cases like graph editor keyframe editing we still need to tag for both copy-on-write and animation evaluation.

CC @Sergey

#61173#628747 has some analysis of the problem. Animation is being evaluated after inserting a keyframe, since 06357b23a2. I think we need a way to DEG tag an action datablock to say that it needs copy-on-write without evaluating animation, and use that for inserting and deleting keyframes. For other cases like graph editor keyframe editing we still need to tag for both copy-on-write and animation evaluation. CC @Sergey

Sergey Sharybin commented

2019-03-13 11:53:51 +01:00

@brecht, think proper solution is something like this P937

Short description:

Don't use ID_RECALC_COPY_ON_WRITE unless ABSOLUTELY needed. There are better suitable flags, and tagging should not really depend on a specifics of dependency graph behavior.
Introduce recalc flag ID_RECALC_ANIMATION_BLOCK which internally does Copy-on-Write,making sure all datablocks are a relevant state, but does not force animation to be evaluated.
Used in aniomation edits which are adding/removing f-curves, without affecting on the current value of corresponding property.
Use ID_RECALC_ANIMATION when animation is to be re-evaluated. For example, when adding/removing f-curve modifier.

I did my best updating the tagging in animation editor folder, but don't mind if someone else have a second look at the changes.

@brecht, think proper solution is something like this [P937](https://archive.blender.org/developer/P937.txt) Short description: - Don't use `ID_RECALC_COPY_ON_WRITE` unless ABSOLUTELY needed. There are better suitable flags, and tagging should not really depend on a specifics of dependency graph behavior. - Introduce recalc flag `ID_RECALC_ANIMATION_BLOCK` which internally does Copy-on-Write,making sure all datablocks are a relevant state, but does not force animation to be evaluated. Used in aniomation edits which are adding/removing f-curves, without affecting on the current value of corresponding property. - Use `ID_RECALC_ANIMATION` when animation is to be re-evaluated. For example, when adding/removing f-curve modifier. I did my best updating the tagging in animation editor folder, but don't mind if someone else have a second look at the changes.

Brecht Van Lommel commented

2019-03-13 12:57:10 +01:00

Seems reasonable.

Perhaps ID_RECALC_ANIMATION_BLOCK can be renamed to ID_RECALC_ANIMATION_COPY_ONLY or ID_RECALC_ANIMATION_NO_EVAL? The BLOCK name doesn't really tell me anything.

I think the DEG_id_tag calls in rna_fcurve.c and rna_action.c need to be updated still?

Seems reasonable. Perhaps `ID_RECALC_ANIMATION_BLOCK` can be renamed to `ID_RECALC_ANIMATION_COPY_ONLY` or `ID_RECALC_ANIMATION_NO_EVAL`? The `BLOCK` name doesn't really tell me anything. I think the `DEG_id_tag` calls in `rna_fcurve.c` and `rna_action.c` need to be updated still?

blender-admin commented

2019-03-13 15:38:45 +01:00

This issue was referenced by 0e9ea707b5

This issue was referenced by 0e9ea707b5e5be2a38dd29dded3dd6c25a5e1992

Sergey Sharybin commented

2019-03-13 15:55:55 +01:00

Changed status from 'Open' to: 'Resolved'

Sergey Sharybin closed this issue

2019-03-13 15:55:55 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Keyframing one transform option reset other transforms #58721