Quick Favorites: add support for property enums #59244

New Issue

Peter Baintner · 2018-12-12T15:01:47+01:00

Peter Baintner commented

2018-12-12 15:01:47 +01:00

System Information
Operating system: Windows 10
Graphics card: Nvidia GTX1080

Blender Version
Broken: 2.80, 16fc62e15f, blender2.8, 2018-12-12
Worked: 3d92afca7e

Short description of error
The Set origin menu is not possible to put into quic favourites.
(operator enums like these are now supported, see 04d50f4b23)
Property enums such as Rotation Mode could be supported though

Exact steps for others to reproduce the error
Object Properties -> Transform -> Right click on "Rotation Mode..." -> empty menu.

**System Information** Operating system: Windows 10 Graphics card: Nvidia GTX1080 **Blender Version** Broken: 2.80, 16fc62e15f0, blender2.8, 2018-12-12 Worked: 3d92afca7eb **Short description of error** The Set origin menu is not possible to put into quic favourites. (operator enums like these are now supported, see 04d50f4b239f4b3a27e0ea376803db5680a43f1b) Property enums such as `Rotation Mode` could be supported though **Exact steps for others to reproduce the error** Object Properties -> Transform -> Right click on "Rotation Mode..." -> empty menu.

Peter Baintner commented

2018-12-12 15:01:47 +01:00

Added subscriber: @PeterBaintner

blender-admin commented

2018-12-12 15:01:47 +01:00

#84552 was marked as duplicate of this issue

blender-admin commented

2018-12-12 15:01:47 +01:00

#83682 was marked as duplicate of this issue

blender-admin commented

2018-12-12 15:01:47 +01:00

#79471 was marked as duplicate of this issue

blender-admin commented

2018-12-12 15:01:47 +01:00

#70486 was marked as duplicate of this issue

blender-admin commented

2018-12-12 15:01:47 +01:00

#69922 was marked as duplicate of this issue

blender-admin commented

2018-12-12 15:01:47 +01:00

#69919 was marked as duplicate of this issue

blender-admin commented

2018-12-12 15:01:47 +01:00

#68094 was marked as duplicate of this issue

blender-admin commented

2018-12-12 15:01:47 +01:00

#66623 was marked as duplicate of this issue

blender-admin commented

2018-12-12 15:01:47 +01:00

#66618 was marked as duplicate of this issue

blender-admin commented

2018-12-12 15:01:47 +01:00

#65113 was marked as duplicate of this issue

blender-admin commented

2018-12-12 15:01:47 +01:00

#64614 was marked as duplicate of this issue

blender-admin commented

2018-12-12 15:01:47 +01:00

#64597 was marked as duplicate of this issue

blender-admin commented

2018-12-12 15:01:47 +01:00

#60290 was marked as duplicate of this issue

Jacques Lucke commented

2018-12-12 15:26:06 +01:00

Added subscriber: @JacquesLucke

Jacques Lucke commented

2018-12-12 15:26:06 +01:00

Can confirm.

I see two problems here:

Right clicking on operator_menu_enum brings up an empty menu.
Right clicking on a menu entry while the menu is open, does not open the right-click-menu at all.

Can confirm. I see two problems here: - Right clicking on `operator_menu_enum` brings up an empty menu. - Right clicking on a menu entry while the menu is open, does not open the right-click-menu at all.

Philipp Oeser commented

2018-12-20 11:45:24 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2018-12-20 11:45:24 +01:00

Changed status from 'Open' to: 'Resolved'

Philipp Oeser closed this issue

2018-12-20 11:45:24 +01:00

Philipp Oeser self-assigned this 2018-12-20 11:45:24 +01:00

Philipp Oeser commented

2018-12-20 11:45:24 +01:00

This seems to be fixed, no?

Havent hunted down the relating commit, but as of today I am getting the menu (and choosing the entry will add it to the favorites OK)

Closing (but feel free to comment again/reopen if issues persist...)

This seems to be fixed, no? Havent hunted down the relating commit, but as of today I am getting the menu (and choosing the entry will add it to the favorites OK) ![#59244.png](https://archive.blender.org/developer/F6015072/T59244.png) Closing (but feel free to comment again/reopen if issues persist...)

Jacques Lucke commented

2018-12-20 11:49:13 +01:00

I thought it's about this menu, which does not seem to be fixed yet:

I thought it's about this menu, which does not seem to be fixed yet: ![Screenshot from 2018-12-20 11-48-16.png](https://archive.blender.org/developer/F6015113/Screenshot_from_2018-12-20_11-48-16.png)

Philipp Oeser commented

2018-12-20 11:55:16 +01:00

Changed status from 'Resolved' to: 'Open'

Philipp Oeser reopened this issue

2018-12-20 11:55:16 +01:00

Philipp Oeser commented

2018-12-20 11:55:16 +01:00

Ah, OK, will check on this, too...

Philipp Oeser commented

2019-01-08 10:56:56 +01:00

Added subscriber: @Awesome_Vindicator

Philipp Oeser changed title from ~~Set origin command not possible to put in quick favourites~~ to Quick Favorites: operator/prop enums (e.g. "Set origin") cannot be added

2019-01-08 11:02:18 +01:00

Lee Gowans commented

2019-01-12 01:24:19 +01:00

As merged from a report I previously made was relating to a slightly different though closely related issue.

some screenshots;-

these are missing in 2019-01-11 - 1c7695b848 and all previously downloaded versions.

As merged from a report I previously made was relating to a slightly different though closely related issue. some screenshots;- ![blender issue report.jpg](https://archive.blender.org/developer/F6259988/blender_issue_report.jpg) ![blender issue report 2.jpg](https://archive.blender.org/developer/F6259987/blender_issue_report_2.jpg) these are missing in 2019-01-11 - 1c7695b8483d and all previously downloaded versions.

Philipp Oeser commented

2019-05-09 09:30:56 +02:00

Added subscribers: @WilliamReynish, @ideasman42, @brecht

Philipp Oeser commented

2019-05-09 09:30:56 +02:00

@ideasman42, @WilliamReynish, @brecht: just checking if this would be a priority for 2.80 [also see #59661]?

Campbell Barton changed title from ~~Quick Favorites: operator/prop enums (e.g. "Set origin") cannot be added~~ to Quick Favorites: add support for operator/prop enums (e.g. "Set origin")

2019-05-09 09:51:09 +02:00

Campbell Barton commented

2019-05-09 09:53:19 +02:00

Support for this can be added but this is more of a TODO, added to #63726 (User Interface Module )

Philipp Oeser commented

2019-05-14 13:58:43 +02:00

Added subscriber: @Phigon

Philipp Oeser commented

2019-05-14 19:25:42 +02:00

Added subscribers: @DiegoSG, @Gvgeo-1

George Vogiatzis commented

2019-05-26 09:09:18 +02:00

Added subscriber: @denis_russkih

Philipp Oeser commented

2019-07-09 20:23:55 +02:00

Added subscriber: @AndreyRusnak

Philipp Oeser commented

2019-07-09 21:14:41 +02:00

Added subscriber: @MikeP.Sanchez

Philipp Oeser commented

2019-08-02 09:49:10 +02:00

Added subscriber: @SethTooQuick

Seth Quick commented

2019-08-05 02:45:05 +02:00

Super sorry for adding yet another duplicate to this list. I did check for it but I guess not good enough.

Philipp Oeser commented

2019-08-07 14:56:16 +02:00

I hear you, hope to get to it soon...

Ovionis commented

2019-08-07 19:59:32 +02:00

Removed subscriber: @Phigon

Fabian commented

2019-08-09 14:01:03 +02:00

Added subscriber: @fabman

Himanshi Kalra commented

2019-08-31 10:48:00 +02:00

Added subscriber: @Calra

Himanshi Kalra commented

2019-08-31 10:48:00 +02:00

Hi I would like to contribute towards this I have narrowed down the files to interface_context_menu.c and interface_handlers.c , at least I believe these are to be modified, what I don't understand is when we right-click on any of the options what function is called or is it generic that on right-clicking "Add/remove Quick favorites" will appear ? Like it working for "Transform" and all the others in the Add menu, where should I start looking, any hints or suggestions would be great. Thanks

Philipp Oeser commented

2019-08-31 11:19:07 +02:00

will get back to you Monday (I am away over the WE)

Himanshi Kalra commented

2019-09-02 10:59:16 +02:00

Hi @lichtwerk could you look into this now ?

Philipp Oeser removed their assignment 2019-09-02 13:42:26 +02:00

Philipp Oeser commented

2019-09-02 13:42:26 +02:00

Atm. Quick Favorites only works for:

rna boolean properties USER_MENU_TYPE_PROP
operators USER_MENU_TYPE_OPERATOR
and 'real' menus (https://docs.blender.org/api/master/bpy.types.Menu.html) USER_MENU_TYPE_MENU

What we are looking for is a way to handle operator enum menus.
These are just not covered by current design (see above), and quite some stuff need to be added [even then I am not sure if all would work out fine -- this is just quick speculation how this could work]:

would probably need something new like bUserMenuItem_OpEnumMenu [next to existing bUserMenuItem_Prop, bUserMenuItem_Menu, bUserMenuItem_Op] that needs to store at least op_idname (maybe more, would needto check more...)
incorporate this into ui_but_is_user_menu_compatible (so it doesnt get skipped in ui_popup_context_menu_for_button)
(atm. UI_but_menutype_get does this for 'real' menus, would need something like UI_but_openummenu_ok or something like that)
(investigation of ui_item_menutype_func vs. menu_item_enum_opname_menu and UI_BTYPE_BUT_MENU vs. UI_BTYPE_PULLDOWN might also help)
now onto actual insertion into bUserMenu (!warning! gets even more speculative):
- happens in popup_user_menu_add_or_replace_func / ui_but_user_menu_add
- ED_screen_user_menu_item_add_menu does this for 'real' menus, would need something doing this based on the new bUserMenuItem_OpEnumMenu
now if that is sucessfully stored bUserMenu
- add another - new - case in screen_user_menu_draw which correctly generates the menu to click on here
also note: above new struct would also need to be taken care of in write_userdef (I assume)

@Calra: this is not the easiest task to pick up, I am still willing to look at this myself (but triaging the tracker unfortunately takes all of my time atm. so help is definitely appreciated)
(please also take all of the above with a grain of salt, there might be other/better ways to do this -- this is just how I had it lying around in my head for a while...)
I will also step down as a assignee from this task (as we moved from assignments to people in favor of having the modules look at the corresponding bugs...)

Atm. Quick Favorites only works for: - rna boolean properties `USER_MENU_TYPE_PROP` - operators `USER_MENU_TYPE_OPERATOR` - and 'real' menus (https://docs.blender.org/api/master/bpy.types.Menu.html) `USER_MENU_TYPE_MENU` What we are looking for is a way to handle operator enum menus. These are just not covered by current design (see above), and quite some stuff need to be added [even then I am not sure if all would work out fine -- this is just quick speculation how this **could** work]: - would probably need something new like `bUserMenuItem_OpEnumMenu` [next to existing `bUserMenuItem_Prop`, `bUserMenuItem_Menu`, `bUserMenuItem_Op`] that needs to store at least op_idname (maybe more, would needto check more...) - incorporate this into `ui_but_is_user_menu_compatible` (so it doesnt get skipped in `ui_popup_context_menu_for_button`) - (atm. `UI_but_menutype_get` does this for 'real' menus, would need something like `UI_but_openummenu_ok` or something like that) - (investigation of ui_item_menutype_func vs. `menu_item_enum_opname_menu` and `UI_BTYPE_BUT_MENU` vs. `UI_BTYPE_PULLDOWN` might also help) - now onto actual insertion into `bUserMenu` (!warning! gets even more speculative): - happens in `popup_user_menu_add_or_replace_func` / `ui_but_user_menu_add` - `ED_screen_user_menu_item_add_menu` does this for 'real' menus, would need something doing this based on the new `bUserMenuItem_OpEnumMenu` - now if that is sucessfully stored bUserMenu - add another - new - case in `screen_user_menu_draw` which correctly generates the menu to click on here - also note: above new struct would also need to be taken care of in `write_userdef` (I assume) @Calra: this is not the easiest task to pick up, I am still willing to look at this myself (but triaging the tracker unfortunately takes all of my time atm. so help is definitely appreciated) (please also take all of the above with a grain of salt, there might be other/better ways to do this -- this is just how I had it lying around in my head for a while...) I will also step down as a assignee from this task (as we moved from assignments to people in favor of having the modules look at the corresponding bugs...)

Himanshi Kalra commented

2019-09-02 19:44:05 +02:00

Thanks @lichtwerk for the input, I will look into it for some time and will let you know if I have any success, from a holistic view I speculated that this and #64365 would be related, as the problem seemed similar. To be honest currently some of the stuff is bouncing off, I can try for some time to implement what you suggested.