Texture Coordinates Node output crash in blender 2.8 in Lookdev Mode even with Cycles renderer. #63524

New Issue

Jerr Soundripper · 2019-04-12T09:40:44+02:00

Jerr Soundripper commented

2019-04-12 09:40:44 +02:00

System Information
Operating system: Darwin-17.7.0-x86_64-i386-64bit 64 Bits
Graphics card: NVIDIA GeForce GTX 780 OpenGL Engine NVIDIA Corporation 4.1 NVIDIA-10.33.0 387.10.10.10.40.113

Blender Version
Broken: version: 2.80 (sub 55), branch: blender2.7, commit date: 2019-04-11 17:43, hash: d1cda823e0
Worked: (optional)

Short description of error
Texture Coordinates Node output crashes blender 2.8 in Lookdev Mode even with Cycles renderer.
Forced to use cycles render preview and never swap back to lookdev, making the texture coordinates node unusable.

Exact steps for others to reproduce the error

Select Cycles renderer and cycles preview mode
Keep default cube
Edit cube shading
Add Image Texture, Ctrl+T, select object in the Object dropdown on the Texture Coordinates node.
Switch to Lookdev or Eevee rendering mode
Crash

**System Information** Operating system: Darwin-17.7.0-x86_64-i386-64bit 64 Bits Graphics card: NVIDIA GeForce GTX 780 OpenGL Engine NVIDIA Corporation 4.1 NVIDIA-10.33.0 387.10.10.10.40.113 **Blender Version** Broken: version: 2.80 (sub 55), branch: blender2.7, commit date: 2019-04-11 17:43, hash: `d1cda823e0` Worked: (optional) **Short description of error** Texture Coordinates Node output crashes blender 2.8 in Lookdev Mode even with Cycles renderer. Forced to use cycles render preview and never swap back to lookdev, making the texture coordinates node unusable. **Exact steps for others to reproduce the error** - Select Cycles renderer and cycles preview mode - Keep default cube - Edit cube shading - Add Image Texture, Ctrl+T, select object in the Object dropdown on the Texture Coordinates node. - Switch to Lookdev or Eevee rendering mode - > Crash

blender-admin commented

2019-04-12 09:40:44 +02:00

#63425 was marked as duplicate of this issue

blender-admin commented

2019-04-12 09:40:44 +02:00

#63826 was marked as duplicate of this issue

blender-admin commented

2019-04-12 09:40:44 +02:00

#63858 was marked as duplicate of this issue

Jerr Soundripper commented

2019-04-12 09:40:45 +02:00

Added subscriber: @jerrsoundripper

Philipp Oeser commented

2019-04-12 10:03:45 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2019-04-12 10:03:45 +02:00

Cannot reproduce here. [fedora29, 970m, 418.56 drivers]

Sebastian Parborg commented

2019-04-12 18:30:47 +02:00

Added subscribers: @WilliamReynish, @ZedDB

Sebastian Parborg commented

2019-04-12 18:30:47 +02:00

@WilliamReynish can you reproduce this?

Jerr Soundripper commented

2019-04-15 09:15:18 +02:00

I can reproduce this on every Mac OSX High sierra Blender 2.8 (Mac pros and MacBooks) with factory settings. Haven't tried on Linux or Windows.

Jerr Soundripper commented

2019-04-17 10:20:09 +02:00

I tested on windows and there is no crash ! I can only reproduce this on OSX High sierra 10.13.6.

William Reynish commented

2019-04-17 10:42:55 +02:00

Cannot reproduce in macOS 10.14 Mojave.

Jerr Soundripper commented

2019-04-17 12:03:30 +02:00

I updated Cuda from 410.130 to 418.105 and I have the same issue. Could this be Nvidia related ?
I (and many 3d artists) won't update to Mojave because of Nvidia compatibility issues ...?
I hope it can be solved or at least reproduced by someone.
I also unchecked Cuda in Blender preferences but it doesn't change anything

I updated Cuda from 410.130 to 418.105 and I have the same issue. Could this be Nvidia related ? I (and many 3d artists) won't update to Mojave because of Nvidia compatibility issues ...? I hope it can be solved or at least reproduced by someone. I also unchecked Cuda in Blender preferences but it doesn't change anything

Brecht Van Lommel commented

2019-04-17 12:42:10 +02:00

Added subscriber: @brecht

Brecht Van Lommel commented

2019-04-17 12:42:10 +02:00

LookDev mode is using Eevee regardless of the render engine, so this would not be related to CUDA drivers.

I guess Ctrl+T means you are using the Node Wrangler add-on?

Does it still happen with the latest builds? There were some recent fixes related to this.

LookDev mode is using Eevee regardless of the render engine, so this would not be related to CUDA drivers. I guess Ctrl+T means you are using the Node Wrangler add-on? Does it still happen with the latest builds? There were some recent fixes related to this.

Jerr Soundripper commented

2019-04-17 13:58:34 +02:00

Yes Ctrl+T is node wrangler. Deactivating it won't solve the problem.
I always download the most recent build. (Every morning ;)
I am reproducing the crash with blender 2.8 beta build of April the 16th.

Off topic but : Keep up the good work you have a truly fantastic developper team and community. (I have been using blender for more than decades)
You are the open source heroes... I hope blender will continue to exist on Mac ;)

Yes Ctrl+T is node wrangler. Deactivating it won't solve the problem. I always download the most recent build. (Every morning ;) I am reproducing the crash with blender 2.8 beta build of April the 16th. Off topic but : Keep up the good work you have a truly fantastic developper team and community. (I have been using blender for more than decades) You are the open source heroes... I hope blender will continue to exist on Mac ;)

Jerr Soundripper commented

2019-04-18 09:24:24 +02:00

Same crash with today's 2.8 beta build.

Jerr Soundripper commented

2019-04-18 14:55:34 +02:00

It crashes in lookdev preview mode and Eevee renderer mode. No problem with wireframe, solid or cycles preview modes. So I agree it is eevee related.

Jerr Soundripper commented

2019-04-18 14:58:20 +02:00

This comment was removed by @jerrsoundripper

*This comment was removed by @jerrsoundripper*

Jerr Soundripper commented

2019-04-19 09:24:57 +02:00

Same crash with today's 2.8 beta build on High Sierra Macpro and macbook pro.
Tell me if I have to report this crash every 2.8 daily build or if I should stay quiet and not bother you with that.

Same crash with today's 2.8 beta build on High Sierra Macpro and macbook pro. Tell me if I have to report this crash every 2.8 daily build or if I should stay quiet and not bother you with that.

Jerr Soundripper commented

2019-04-19 11:20:01 +02:00

CrashReport.rtf

[CrashReport.rtf](https://archive.blender.org/developer/F6959158/CrashReport.rtf)

Jerr Soundripper commented

2019-04-19 11:20:32 +02:00

The "crash report" file is from osx if it can help

Brecht Van Lommel commented

2019-04-19 11:25:36 +02:00

Thanks for the crash report. It's not needed to test the build every day.

Jerr Soundripper commented

2019-04-24 09:07:04 +02:00

It seems to be the same bug in "#63826: Crashing file."

Brecht Van Lommel commented

2019-04-24 20:27:04 +02:00

I can't make it crash on Linux but valgrind does show me errors.

==13253== Invalid read of size 8
==13253==    at 0x24EDAD9: codegen_call_functions (blender/source/blender/gpu/intern/gpu_codegen.c:0)
==13253==    by 0x24EDAD9: code_generate_fragment (blender/source/blender/gpu/intern/gpu_codegen.c:903)
==13253==    by 0x24EDAD9: GPU_generate_pass (blender/source/blender/gpu/intern/gpu_codegen.c:1949)
==13253==    by 0x24FB0D9: GPU_material_from_nodetree (blender/source/blender/gpu/intern/gpu_material.c:695)
==13253==    by 0x184D54F: DRW_shader_create_from_material (blender/source/blender/draw/intern/draw_manager_shader.c:429)
==13253==    by 0x180E438: EEVEE_material_mesh_get (blender/source/blender/draw/engines/eevee/eevee_materials.c:781)
==13253==    by 0x180F5B4: material_opaque (blender/source/blender/draw/engines/eevee/eevee_materials.c:1278)
==13253==    by 0x180F5B4: EEVEE_materials_cache_populate (blender/source/blender/draw/engines/eevee/eevee_materials.c:1670)
==13253==    by 0x1803121: EEVEE_cache_populate (blender/source/blender/draw/engines/eevee/eevee_engine.c:130)
==13253==    by 0x17E6F3F: drw_engines_cache_populate (blender/source/blender/draw/intern/draw_manager.c:1095)
==13253==    by 0x17E6F3F: DRW_draw_render_loop_ex (blender/source/blender/draw/intern/draw_manager.c:1569)
==13253==    by 0x1AA98B7: view3d_draw_view (blender/source/blender/editors/space_view3d/view3d_draw.c:1431)
==13253==    by 0x1AA98B7: view3d_main_region_draw (blender/source/blender/editors/space_view3d/view3d_draw.c:1452)
==13253==    by 0x1B14611: ED_region_do_draw (blender/source/blender/editors/screen/area.c:558)
==13253==    by 0x10A64A5: wm_draw_window_offscreen (blender/source/blender/windowmanager/intern/wm_draw.c:596)
==13253==    by 0x10A64A5: wm_draw_window (blender/source/blender/windowmanager/intern/wm_draw.c:732)
==13253==    by 0x10A64A5: wm_draw_update (blender/source/blender/windowmanager/intern/wm_draw.c:895)
==13253==    by 0x10A426F: WM_main (blender/source/blender/windowmanager/intern/wm.c:424)
==13253==    by 0xC62A9A: main (blender/source/creator/creator.c:500)
==13253==  Address 0xc5ad1e8 is 8 bytes inside a block of size 32 free'd
==13253==    at 0x7835CB0: free (vg_replace_malloc.c:530)
==13253==    by 0xE35DD5: BLI_freelistN (blender/source/blender/blenlib/intern/listbase.c:533)
==13253==    by 0x24ED82E: codegen_process_uniforms_functions (blender/source/blender/gpu/intern/gpu_codegen.c:717)
==13253==    by 0x24ED82E: code_generate_fragment (blender/source/blender/gpu/intern/gpu_codegen.c:847)
==13253==    by 0x24ED82E: GPU_generate_pass (blender/source/blender/gpu/intern/gpu_codegen.c:1949)
==13253==    by 0x24FB0D9: GPU_material_from_nodetree (blender/source/blender/gpu/intern/gpu_material.c:695)
==13253==    by 0x184D54F: DRW_shader_create_from_material (blender/source/blender/draw/intern/draw_manager_shader.c:429)
==13253==    by 0x180E438: EEVEE_material_mesh_get (blender/source/blender/draw/engines/eevee/eevee_materials.c:781)
==13253==    by 0x180F5B4: material_opaque (blender/source/blender/draw/engines/eevee/eevee_materials.c:1278)
==13253==    by 0x180F5B4: EEVEE_materials_cache_populate (blender/source/blender/draw/engines/eevee/eevee_materials.c:1670)
==13253==    by 0x1803121: EEVEE_cache_populate (blender/source/blender/draw/engines/eevee/eevee_engine.c:130)
==13253==    by 0x17E6F3F: drw_engines_cache_populate (blender/source/blender/draw/intern/draw_manager.c:1095)
==13253==    by 0x17E6F3F: DRW_draw_render_loop_ex (blender/source/blender/draw/intern/draw_manager.c:1569)
==13253==    by 0x1AA98B7: view3d_draw_view (blender/source/blender/editors/space_view3d/view3d_draw.c:1431)
==13253==    by 0x1AA98B7: view3d_main_region_draw (blender/source/blender/editors/space_view3d/view3d_draw.c:1452)
==13253==    by 0x1B14611: ED_region_do_draw (blender/source/blender/editors/screen/area.c:558)
==13253==    by 0x10A64A5: wm_draw_window_offscreen (blender/source/blender/windowmanager/intern/wm_draw.c:596)
==13253==    by 0x10A64A5: wm_draw_window (blender/source/blender/windowmanager/intern/wm_draw.c:732)
==13253==    by 0x10A64A5: wm_draw_update (blender/source/blender/windowmanager/intern/wm_draw.c:895)
==13253==  Block was alloc'd at
==13253==    at 0x7836948: calloc (vg_replace_malloc.c:711)
==13253==    by 0xF27190: MEM_lockfree_callocN (blender/intern/guardedalloc/intern/mallocn_lockfree_impl.c:267)
==13253==    by 0xE3633D: BLI_genericNodeN (blender/source/blender/blenlib/intern/listbase.c:911)
==13253==    by 0x24ED513: codegen_process_uniforms_functions (blender/source/blender/gpu/intern/gpu_codegen.c:689)
==13253==    by 0x24ED513: code_generate_fragment (blender/source/blender/gpu/intern/gpu_codegen.c:847)
==13253==    by 0x24ED513: GPU_generate_pass (blender/source/blender/gpu/intern/gpu_codegen.c:1949)
==13253==    by 0x24FB0D9: GPU_material_from_nodetree (blender/source/blender/gpu/intern/gpu_material.c:695)
==13253==    by 0x184D54F: DRW_shader_create_from_material (blender/source/blender/draw/intern/draw_manager_shader.c:429)
==13253==    by 0x180E438: EEVEE_material_mesh_get (blender/source/blender/draw/engines/eevee/eevee_materials.c:781)
==13253==    by 0x180F5B4: material_opaque (blender/source/blender/draw/engines/eevee/eevee_materials.c:1278)
==13253==    by 0x180F5B4: EEVEE_materials_cache_populate (blender/source/blender/draw/engines/eevee/eevee_materials.c:1670)
==13253==    by 0x1803121: EEVEE_cache_populate (blender/source/blender/draw/engines/eevee/eevee_engine.c:130)
==13253==    by 0x17E6F3F: drw_engines_cache_populate (blender/source/blender/draw/intern/draw_manager.c:1095)
==13253==    by 0x17E6F3F: DRW_draw_render_loop_ex (blender/source/blender/draw/intern/draw_manager.c:1569)
==13253==    by 0x1AA98B7: view3d_draw_view (blender/source/blender/editors/space_view3d/view3d_draw.c:1431)
==13253==    by 0x1AA98B7: view3d_main_region_draw (blender/source/blender/editors/space_view3d/view3d_draw.c:1452)
==13253==    by 0x1B14611: ED_region_do_draw (blender/source/blender/editors/screen/area.c:558)

I can't make it crash on Linux but valgrind does show me errors. ```lines=5 ==13253== Invalid read of size 8 ==13253== at 0x24EDAD9: codegen_call_functions (blender/source/blender/gpu/intern/gpu_codegen.c:0) ==13253== by 0x24EDAD9: code_generate_fragment (blender/source/blender/gpu/intern/gpu_codegen.c:903) ==13253== by 0x24EDAD9: GPU_generate_pass (blender/source/blender/gpu/intern/gpu_codegen.c:1949) ==13253== by 0x24FB0D9: GPU_material_from_nodetree (blender/source/blender/gpu/intern/gpu_material.c:695) ==13253== by 0x184D54F: DRW_shader_create_from_material (blender/source/blender/draw/intern/draw_manager_shader.c:429) ==13253== by 0x180E438: EEVEE_material_mesh_get (blender/source/blender/draw/engines/eevee/eevee_materials.c:781) ==13253== by 0x180F5B4: material_opaque (blender/source/blender/draw/engines/eevee/eevee_materials.c:1278) ==13253== by 0x180F5B4: EEVEE_materials_cache_populate (blender/source/blender/draw/engines/eevee/eevee_materials.c:1670) ==13253== by 0x1803121: EEVEE_cache_populate (blender/source/blender/draw/engines/eevee/eevee_engine.c:130) ==13253== by 0x17E6F3F: drw_engines_cache_populate (blender/source/blender/draw/intern/draw_manager.c:1095) ==13253== by 0x17E6F3F: DRW_draw_render_loop_ex (blender/source/blender/draw/intern/draw_manager.c:1569) ==13253== by 0x1AA98B7: view3d_draw_view (blender/source/blender/editors/space_view3d/view3d_draw.c:1431) ==13253== by 0x1AA98B7: view3d_main_region_draw (blender/source/blender/editors/space_view3d/view3d_draw.c:1452) ==13253== by 0x1B14611: ED_region_do_draw (blender/source/blender/editors/screen/area.c:558) ==13253== by 0x10A64A5: wm_draw_window_offscreen (blender/source/blender/windowmanager/intern/wm_draw.c:596) ==13253== by 0x10A64A5: wm_draw_window (blender/source/blender/windowmanager/intern/wm_draw.c:732) ==13253== by 0x10A64A5: wm_draw_update (blender/source/blender/windowmanager/intern/wm_draw.c:895) ==13253== by 0x10A426F: WM_main (blender/source/blender/windowmanager/intern/wm.c:424) ==13253== by 0xC62A9A: main (blender/source/creator/creator.c:500) ==13253== Address 0xc5ad1e8 is 8 bytes inside a block of size 32 free'd ==13253== at 0x7835CB0: free (vg_replace_malloc.c:530) ==13253== by 0xE35DD5: BLI_freelistN (blender/source/blender/blenlib/intern/listbase.c:533) ==13253== by 0x24ED82E: codegen_process_uniforms_functions (blender/source/blender/gpu/intern/gpu_codegen.c:717) ==13253== by 0x24ED82E: code_generate_fragment (blender/source/blender/gpu/intern/gpu_codegen.c:847) ==13253== by 0x24ED82E: GPU_generate_pass (blender/source/blender/gpu/intern/gpu_codegen.c:1949) ==13253== by 0x24FB0D9: GPU_material_from_nodetree (blender/source/blender/gpu/intern/gpu_material.c:695) ==13253== by 0x184D54F: DRW_shader_create_from_material (blender/source/blender/draw/intern/draw_manager_shader.c:429) ==13253== by 0x180E438: EEVEE_material_mesh_get (blender/source/blender/draw/engines/eevee/eevee_materials.c:781) ==13253== by 0x180F5B4: material_opaque (blender/source/blender/draw/engines/eevee/eevee_materials.c:1278) ==13253== by 0x180F5B4: EEVEE_materials_cache_populate (blender/source/blender/draw/engines/eevee/eevee_materials.c:1670) ==13253== by 0x1803121: EEVEE_cache_populate (blender/source/blender/draw/engines/eevee/eevee_engine.c:130) ==13253== by 0x17E6F3F: drw_engines_cache_populate (blender/source/blender/draw/intern/draw_manager.c:1095) ==13253== by 0x17E6F3F: DRW_draw_render_loop_ex (blender/source/blender/draw/intern/draw_manager.c:1569) ==13253== by 0x1AA98B7: view3d_draw_view (blender/source/blender/editors/space_view3d/view3d_draw.c:1431) ==13253== by 0x1AA98B7: view3d_main_region_draw (blender/source/blender/editors/space_view3d/view3d_draw.c:1452) ==13253== by 0x1B14611: ED_region_do_draw (blender/source/blender/editors/screen/area.c:558) ==13253== by 0x10A64A5: wm_draw_window_offscreen (blender/source/blender/windowmanager/intern/wm_draw.c:596) ==13253== by 0x10A64A5: wm_draw_window (blender/source/blender/windowmanager/intern/wm_draw.c:732) ==13253== by 0x10A64A5: wm_draw_update (blender/source/blender/windowmanager/intern/wm_draw.c:895) ==13253== Block was alloc'd at ==13253== at 0x7836948: calloc (vg_replace_malloc.c:711) ==13253== by 0xF27190: MEM_lockfree_callocN (blender/intern/guardedalloc/intern/mallocn_lockfree_impl.c:267) ==13253== by 0xE3633D: BLI_genericNodeN (blender/source/blender/blenlib/intern/listbase.c:911) ==13253== by 0x24ED513: codegen_process_uniforms_functions (blender/source/blender/gpu/intern/gpu_codegen.c:689) ==13253== by 0x24ED513: code_generate_fragment (blender/source/blender/gpu/intern/gpu_codegen.c:847) ==13253== by 0x24ED513: GPU_generate_pass (blender/source/blender/gpu/intern/gpu_codegen.c:1949) ==13253== by 0x24FB0D9: GPU_material_from_nodetree (blender/source/blender/gpu/intern/gpu_material.c:695) ==13253== by 0x184D54F: DRW_shader_create_from_material (blender/source/blender/draw/intern/draw_manager_shader.c:429) ==13253== by 0x180E438: EEVEE_material_mesh_get (blender/source/blender/draw/engines/eevee/eevee_materials.c:781) ==13253== by 0x180F5B4: material_opaque (blender/source/blender/draw/engines/eevee/eevee_materials.c:1278) ==13253== by 0x180F5B4: EEVEE_materials_cache_populate (blender/source/blender/draw/engines/eevee/eevee_materials.c:1670) ==13253== by 0x1803121: EEVEE_cache_populate (blender/source/blender/draw/engines/eevee/eevee_engine.c:130) ==13253== by 0x17E6F3F: drw_engines_cache_populate (blender/source/blender/draw/intern/draw_manager.c:1095) ==13253== by 0x17E6F3F: DRW_draw_render_loop_ex (blender/source/blender/draw/intern/draw_manager.c:1569) ==13253== by 0x1AA98B7: view3d_draw_view (blender/source/blender/editors/space_view3d/view3d_draw.c:1431) ==13253== by 0x1AA98B7: view3d_main_region_draw (blender/source/blender/editors/space_view3d/view3d_draw.c:1452) ==13253== by 0x1B14611: ED_region_do_draw (blender/source/blender/editors/screen/area.c:558) ```

Brecht Van Lommel commented

2019-04-24 20:27:28 +02:00

Added subscribers: @StephenF, @sebastian_k

Brecht Van Lommel commented

2019-04-24 20:27:37 +02:00

Added subscriber: @JacquesLucke

Brecht Van Lommel commented

2019-04-25 01:25:47 +02:00

That valgrind message is wrong, probably due to stack corruption. This is what asan shows:

/home/brecht/dev/blender/source/blender/gpu/intern/gpu_uniformbuffer.c:275:20: runtime error: index 16 out of bounds for type 'LinkData *[5]'
/home/brecht/dev/blender/source/blender/gpu/intern/gpu_uniformbuffer.c:275:34: runtime error: store to address 0x7fffffffc290 with insufficient space for an object of type 'struct LinkData *'

That valgrind message is wrong, probably due to stack corruption. This is what asan shows: ``` /home/brecht/dev/blender/source/blender/gpu/intern/gpu_uniformbuffer.c:275:20: runtime error: index 16 out of bounds for type 'LinkData *[5]' /home/brecht/dev/blender/source/blender/gpu/intern/gpu_uniformbuffer.c:275:34: runtime error: store to address 0x7fffffffc290 with insufficient space for an object of type 'struct LinkData *' ```

Clément Foucault was assigned by Brecht Van Lommel

2019-04-25 01:58:05 +02:00

Brecht Van Lommel commented

2019-04-25 01:58:05 +02:00

Added subscriber: @fclem

Brecht Van Lommel commented

2019-04-25 01:58:05 +02:00

@fclem, this seems to work. Basically adding support for mat4 in UBOs, and raising assert if unsupported types are used. Supporting mat3 alignment requires bigger changes to the code I think, so I didn't bother with that.
P961: (An Untitled Masterwork)

diff --git a/source/blender/gpu/intern/gpu_uniformbuffer.c b/source/blender/gpu/intern/gpu_uniformbuffer.c
index 651e3c1..6b2c903 100644
--- a/source/blender/gpu/intern/gpu_uniformbuffer.c
+++ b/source/blender/gpu/intern/gpu_uniformbuffer.c
@@ -65,7 +65,7 @@ static void gpu_uniformbuffer_inputs_sort(struct ListBase *inputs);
 
 /* Only support up to this type, if you want to extend it, make sure the
  * padding logic is correct for the new types. */
-#define MAX_UBO_GPU_TYPE GPU_VEC4
+#define MAX_UBO_GPU_TYPE GPU_MAT4
 
 static void gpu_uniformbuffer_initialize(GPUUniformBuffer *ubo, const void *data)
 {
@@ -255,11 +255,11 @@ static int inputs_cmp(const void *a, const void *b)
 
 /**
  * Make sure we respect the expected alignment of UBOs.
- * vec4, pad vec3 as vec4, then vec2, then floats.
+ * mat4, vec4, pad vec3 as vec4, then vec2, then floats.
  */
 static void gpu_uniformbuffer_inputs_sort(ListBase *inputs)
 {
-  /* Order them as vec4, vec3, vec2, float. */
+  /* Order them as mat4, vec4, vec3, vec2, float. */
   BLI_listbase_sort(inputs, inputs_cmp);
 
   /* Creates a lookup table for the different types; */
@@ -268,6 +268,17 @@ static void gpu_uniformbuffer_inputs_sort(ListBase *inputs)
 
   for (LinkData *link = inputs->first; link; link = link->next) {
     GPUInput *input = link->data;
+
+    if (input->type == GPU_MAT3) {
+      /* Alignment for mat3 is not handled currently, so not supported */
+      BLI_assert(!"mat3 not supported in UBO");
+      continue;
+    }
+    else if (input->type > MAX_UBO_GPU_TYPE) {
+      BLI_assert(!"GPU type not supported in UBO");
+      continue;
+    }
+
     if (input->type == cur_type) {
       continue;
     }

@fclem, this seems to work. Basically adding support for mat4 in UBOs, and raising assert if unsupported types are used. Supporting `mat3` alignment requires bigger changes to the code I think, so I didn't bother with that. [P961: (An Untitled Masterwork)](https://archive.blender.org/developer/P961.txt) ``` diff --git a/source/blender/gpu/intern/gpu_uniformbuffer.c b/source/blender/gpu/intern/gpu_uniformbuffer.c index 651e3c1..6b2c903 100644 --- a/source/blender/gpu/intern/gpu_uniformbuffer.c +++ b/source/blender/gpu/intern/gpu_uniformbuffer.c @@ -65,7 +65,7 @@ static void gpu_uniformbuffer_inputs_sort(struct ListBase *inputs); /* Only support up to this type, if you want to extend it, make sure the * padding logic is correct for the new types. */ -#define MAX_UBO_GPU_TYPE GPU_VEC4 +#define MAX_UBO_GPU_TYPE GPU_MAT4 static void gpu_uniformbuffer_initialize(GPUUniformBuffer *ubo, const void *data) { @@ -255,11 +255,11 @@ static int inputs_cmp(const void *a, const void *b) /** * Make sure we respect the expected alignment of UBOs. - * vec4, pad vec3 as vec4, then vec2, then floats. + * mat4, vec4, pad vec3 as vec4, then vec2, then floats. */ static void gpu_uniformbuffer_inputs_sort(ListBase *inputs) { - /* Order them as vec4, vec3, vec2, float. */ + /* Order them as mat4, vec4, vec3, vec2, float. */ BLI_listbase_sort(inputs, inputs_cmp); /* Creates a lookup table for the different types; */ @@ -268,6 +268,17 @@ static void gpu_uniformbuffer_inputs_sort(ListBase *inputs) for (LinkData *link = inputs->first; link; link = link->next) { GPUInput *input = link->data; + + if (input->type == GPU_MAT3) { + /* Alignment for mat3 is not handled currently, so not supported */ + BLI_assert(!"mat3 not supported in UBO"); + continue; + } + else if (input->type > MAX_UBO_GPU_TYPE) { + BLI_assert(!"GPU type not supported in UBO"); + continue; + } + if (input->type == cur_type) { continue; } ```

Clément Foucault commented

2019-04-25 11:18:21 +02:00

@brecht +1 this should work correctly.

blender-admin commented

2019-04-25 12:11:55 +02:00

This issue was referenced by 7e18aa4250

This issue was referenced by 7e18aa4250ffc8ec6c475fb90fc5549e6a4d5de6

Brecht Van Lommel commented

2019-04-25 12:14:29 +02:00

Changed status from 'Open' to: 'Resolved'

Brecht Van Lommel closed this issue

2019-04-25 12:14:29 +02:00

Isaac Freeman commented

2019-04-29 20:56:01 +02:00

Thanks so much for the fix! It now works for me without crashing. Unfortunately the texture still does not update in eevee when you transform the object that is being referenced for texture coordinates. I'm not sure if this is a bug or just a current limitation of eevee?

Clément Foucault commented

2019-04-30 00:25:36 +02:00

Added subscribers: @Josephbburg, @StephenSwaney

Jerr Soundripper commented

2019-05-02 09:47:08 +02:00

Thank you for the bug fix too ! As Isaac Freeman said, it seems that the texture projection from an object doesn't refresh in lookdev. I have to go to cycles render to see it. I would like to know if it's an Eevee limitation too.

Clément Foucault commented

2019-05-02 11:24:57 +02:00

I would like to know if it's an Eevee limitation too.

It is a depsgraph issue, see #57489

> I would like to know if it's an Eevee limitation too. It is a depsgraph issue, see #57489

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Texture Coordinates Node output crash in blender 2.8 in Lookdev Mode even with Cycles renderer. #63524