Cycles adaptive sampling gives noisy denoising shadow pass #75618

Closed
opened 2020-04-11 14:56:02 +02:00 by Jac PETIT-JEAN-BORET · 11 comments

System Information
Operating system: Windows-7-6.1.7601-SP1 64 Bits
Graphics card: GeForce GTX 970/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 426.00

Blender Version
Broken: version: 2.83 (sub 13), branch: master, commit date: 2020-04-08 21:23, hash: 1239cab11f
Worked: 2.82a

Short description of error
Dots in denoised render.

Exact steps for others to reproduce the error
Try to render the file in 2.82a (no dots) and in 2.83 (dots) as seen on this pic (I made it lighter in pshop to emphasize the difference)..denoise-change.png It seems it comes from the lighting because if I suppress any light source, the problem disappears.
I am aware that it's not a "big" bug and it is very peculiar to these lights, but nevertheless I keep you informed.
denoise2.blend

**System Information** Operating system: Windows-7-6.1.7601-SP1 64 Bits Graphics card: GeForce GTX 970/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 426.00 **Blender Version** Broken: version: 2.83 (sub 13), branch: master, commit date: 2020-04-08 21:23, hash: `1239cab11f` Worked: 2.82a **Short description of error** Dots in denoised render. **Exact steps for others to reproduce the error** Try to render the file in 2.82a (no dots) and in 2.83 (dots) as seen on this pic (I made it lighter in pshop to emphasize the difference)..![denoise-change.png](https://archive.blender.org/developer/F8464641/denoise-change.png) It seems it comes from the lighting because if I suppress any light source, the problem disappears. I am aware that it's not a "big" bug and it is very peculiar to these lights, but nevertheless I keep you informed. [denoise2.blend](https://archive.blender.org/developer/F8464646/denoise2.blend)

Added subscriber: @rimpotche

Added subscriber: @rimpotche
Member

Added subscriber: @Alaska

Added subscriber: @Alaska
Member

The issue actually branches from adaptive sampling. If you turn this feature off, the issue will go away. You could also try increasing the "minimum samples" setting (20 worked for me) or increase your overall sample count (128 fixed it for me). It should be noted that increasing your overall sample count also increases your minimum sample count ( if it's set to 0/auto) which is why it works.

However, this is still a bug, so I'll leave this thread open for the developers to review.

The issue actually branches from adaptive sampling. If you turn this feature off, the issue will go away. You could also try increasing the "minimum samples" setting (20 worked for me) or increase your overall sample count (128 fixed it for me). It should be noted that increasing your overall sample count also increases your minimum sample count ( if it's set to 0/auto) which is why it works. However, this is still a bug, so I'll leave this thread open for the developers to review.

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Brecht Van Lommel changed title from Normal Denoise 2.83 faulty to Cycles adaptive sampling gives noisy denoising shadow pass 2020-05-14 01:17:33 +02:00

Added subscribers: @Stefan_Werner, @brecht

Added subscribers: @Stefan_Werner, @brecht

Both adaptive sampling and the denoising shadow pass use even/odd samples, maybe there is some conflict.

Both adaptive sampling and the denoising shadow pass use even/odd samples, maybe there is some conflict.
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Other reports relating Denoise and AS:
#79190 (Cycles PMJ adaptive sampling working poorly with many bounces)
#82383 ((Denoising) Artifacts on Adaptive Sampling)

Other reports relating Denoise and AS: #79190 (Cycles PMJ adaptive sampling working poorly with many bounces) #82383 ((Denoising) Artifacts on Adaptive Sampling)
Member

#81261 (Viewport render better than final render)

#81261 (Viewport render better than final render)

Changed status from 'Confirmed' to: 'Archived'

Changed status from 'Confirmed' to: 'Archived'

NLM was removed in 3.0, there is no more denoising shadow pass.

NLM was removed in 3.0, there is no more denoising shadow pass.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#75618
No description provided.