(Denoising) Artifacts on Adaptive Sampling #82383

Closed
opened 2020-11-03 22:46:37 +01:00 by Chloe Isabelle Bläker · 9 comments

System Information
Windows 10 (10.0.19042) 64-bit

Blender Version
2.90.1 Public

Short description or error
Using denoising (Intel Open-Denoise and OptiX Denoise) with adaptive sampling can produce weird artifacts around high noise/high contrast sites.
adaptive_denoised.png no_adaptive_denoised.png
The noise pattern using adaptive sampling is clearly altered and creates splotchy spots of dark so this seems to be a problem on the adaptive sampling side not the denoising specifically.
Non denoised adaptive sampling output:
adaptive_noisy.png

Exact steps for others to reproduce the error
Open the project attached to this task.
Toggle adaptive sampling on and off, start the render, wait for the denoiser to show the results
Optionally mute denoiser node in compositor to observe changed noise pattern.
volume.blend

**System Information** Windows 10 (10.0.19042) 64-bit **Blender Version** 2.90.1 Public **Short description or error** Using denoising (Intel Open-Denoise and OptiX Denoise) with adaptive sampling can produce weird artifacts around high noise/high contrast sites. ![adaptive_denoised.png](https://archive.blender.org/developer/F9185953/adaptive_denoised.png) ![no_adaptive_denoised.png](https://archive.blender.org/developer/F9185958/no_adaptive_denoised.png) The noise pattern using adaptive sampling is clearly altered and creates splotchy spots of dark so this seems to be a problem on the adaptive sampling side not the denoising specifically. Non denoised adaptive sampling output: ![adaptive_noisy.png](https://archive.blender.org/developer/F9185996/adaptive_noisy.png) **Exact steps for others to reproduce the error** Open the project attached to this task. Toggle adaptive sampling on and off, start the render, wait for the denoiser to show the results Optionally mute denoiser node in compositor to observe changed noise pattern. [volume.blend](https://archive.blender.org/developer/F9185974/volume.blend)

Added subscriber: @chloe055

Added subscriber: @chloe055
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Duplicate of {#79190}?

Duplicate of {#79190}?
Member

#75618 (Cycles adaptive sampling gives noisy denoising shadow pass) might also be a duplicate

#75618 (Cycles adaptive sampling gives noisy denoising shadow pass) might also be a duplicate

In #82383#1048194, @lichtwerk wrote:
Duplicate of {#79190}?

I didn't see that, could be although I didn't get any of the square tile artifacts, if you think it's the same cause then this is closed already

> In #82383#1048194, @lichtwerk wrote: > Duplicate of {#79190}? I didn't see that, could be although I didn't get any of the square tile artifacts, if you think it's the same cause then this is closed already

Added subscriber: @brecht

Added subscriber: @brecht

Changed status from 'Needs Triage' to: 'Archived'

Changed status from 'Needs Triage' to: 'Archived'

When adaptive sampling is unable to detect the noise early enough, that's leads to structured artifacts. The solution then is to increase the minimum number of samples.

While we will work on improving adaptive sampling to reduce the cases where this happens, this interaction between denoising and adaptive sampling is not a bug, but an indication we can improve our adaptive sampling algorithms further.

When adaptive sampling is unable to detect the noise early enough, that's leads to structured artifacts. The solution then is to increase the minimum number of samples. While we will work on improving adaptive sampling to reduce the cases where this happens, this interaction between denoising and adaptive sampling is not a bug, but an indication we can improve our adaptive sampling algorithms further.

Adaptive sampling improvements are tracked in #74581 (Cycles: adaptive sampling improvements).

Adaptive sampling improvements are tracked in #74581 (Cycles: adaptive sampling improvements).
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#82383
No description provided.