The alternate rows in the Sequencer are green (macOS) #83094

New Issue

Yevgeny Makarov · 2020-11-27T09:45:50+01:00

Yevgeny Makarov commented

2020-11-27 09:45:50 +01:00

System Information
Operating system: Darwin-19.6.0-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon Pro 455 OpenGL Engine ATI Technologies Inc. 4.1 ATI-3.10.18

Blender Version
Broken: version: 2.92.0 Alpha
After f7223d5f72

Short description of error
The alternate rows in the Sequencer are green.

Similar to #81827 (MacOS lines that should be thick are green instead)

**System Information** Operating system: Darwin-19.6.0-x86_64-i386-64bit 64 Bits Graphics card: AMD Radeon Pro 455 OpenGL Engine ATI Technologies Inc. 4.1 ATI-3.10.18 **Blender Version** Broken: version: 2.92.0 Alpha After f7223d5f72 **Short description of error** The alternate rows in the Sequencer are green. ![alternate_row_sequencer.png](https://archive.blender.org/developer/F9388050/alternate_row_sequencer.png) Similar to #81827 (MacOS lines that should be thick are green instead)

Yevgeny Makarov commented

2020-11-27 09:45:50 +01:00

Added subscriber: @jenkm

blender-admin commented

2020-11-27 09:45:50 +01:00

#83825 was marked as duplicate of this issue

Clément Foucault was assigned by Yevgeny Makarov

2020-11-27 09:46:57 +01:00

Yevgeny Makarov commented

2020-11-27 09:46:57 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Erik Abrahamsson commented

2020-11-27 13:43:40 +01:00

Added subscriber: @erik85

Erik Abrahamsson commented

2020-11-27 13:46:15 +01:00

Maybe it would help to blend the colors then set the alpha back to 1.0 again... But I have no way of testing it on macOS.

Robert Guetzkow commented

2020-12-16 10:09:50 +01:00

Added subscriber: @fsiddi

Robert Guetzkow commented

2020-12-16 10:12:26 +01:00

Added subscriber: @rjg

Robert Guetzkow commented

2020-12-16 10:12:26 +01:00

There are also glitches on Linux that I could reproduce with a Intel Haswell (#83318). At the time I wasn't sure if this was caused by Blender or the driver, but given that glitches also happen on macOS this seems to be a bug in Blender.

Dalai Felinto commented

2020-12-17 15:01:29 +01:00

Added subscribers: @HooglyBoogly, @fclem, @dfelinto

Clément Foucault was unassigned by Dalai Felinto

2020-12-17 15:01:29 +01:00

Dalai Felinto commented

2020-12-17 15:01:29 +01:00

@jenkm thanks for the help triaging, but when something is marked as confirmed, it has to be fully triaged. In other words, the module responsible for it should be tagged, not assigning developers. See https://wiki.blender.org/wiki/Process/A_Bugs_Life

Otherwise it doesn't show up in the corresponding module workboard.

@HooglyBoogly since this was introduced with your commit, mind checking it?

@jenkm thanks for the help triaging, but when something is marked as confirmed, it has to be fully triaged. In other words, the module responsible for it should be tagged, not assigning developers. See https://wiki.blender.org/wiki/Process/A_Bugs_Life Otherwise it doesn't show up in the corresponding module workboard. @HooglyBoogly since this was introduced with your commit, mind checking it?

Yevgeny Makarov commented

2020-12-18 10:07:29 +01:00

This for "UI" and "EEVEE & Viewport" projects, not "VFX & Video", "Video Sequencer".
It is related to the gpu shader.

@erik85 - Maybe it would help to blend the colors then set the alpha back to 1.0 again.

Yes, the similar code for file browser used immUniformThemeColorBlend(), so something like the code below will work.
But you will need to adjust the other colors too.

lang=c
    if (i & 1) {
      immUniformThemeColorBlend(TH_BACK, TH_ROW_ALTERNATE, col_alternating[3]);
    }
    else {
      immUniformThemeColor(TH_BACK);
    }

Also I would try using TH_GRID in the UI_view2d_constant_grid_draw(), this color doesn't seem to be used right now.

This for "UI" and "EEVEE & Viewport" projects, not "VFX & Video", "Video Sequencer". It is related to the gpu shader. *** > @erik85 - Maybe it would help to blend the colors then set the alpha back to 1.0 again. Yes, the similar code for file browser used `immUniformThemeColorBlend()`, so something like the code below will work. But you will need to adjust the other colors too. ``` lang=c if (i & 1) { immUniformThemeColorBlend(TH_BACK, TH_ROW_ALTERNATE, col_alternating[3]); } else { immUniformThemeColor(TH_BACK); } ``` Also I would try using `TH_GRID` in the UI_view2d_constant_grid_draw(), this color doesn't seem to be used right now.

Yevgeny Makarov commented

2020-12-23 14:05:32 +01:00

Okay, I think there's just a mistake in UI_GetThemeColorBlendShade4fv().

The offset (shading) should not be applied to alpha, similar to how it is in UI_GetThemeColorShade4fv.

There is no any background under these stripes, so we have a semi-transparent stripe and nothing under it to blend in with.

Okay, I think there's just a mistake in `UI_GetThemeColorBlendShade4fv()`. The `offset` (shading) should not be applied to `alpha`, similar to how it is in `UI_GetThemeColorShade4fv`. *** There is no any background under these stripes, so we have a semi-transparent stripe and nothing under it to blend in with.

blender-admin commented

2021-01-05 21:21:54 +01:00

This issue was referenced by 5424b4821d

This issue was referenced by 5424b4821d28c4ea42b4f195869de1e1620e6889

Hans Goudey commented

2021-01-05 21:23:09 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Hans Goudey closed this issue

2021-01-05 21:23:09 +01:00

Hans Goudey self-assigned this 2021-01-05 21:23:09 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

The alternate rows in the Sequencer are green (macOS) #83094