EEVEE 2.93 Incorrect glossy values #85908

New Issue

I did must have done it · 2021-02-23T04:02:42+01:00

2021-02-23 04:02:42 +01:00

System Information
Operating system: win 10
Graphics card: rx 6800

Blender Version
Broken: 2.93
Worked: 2.92

Short description of error

Recent eevee ao refactor looks like it produces inferior results. geometry is clearly less defined and in new implementation you can even notice glossy shading underneath AO something that is not present in old AO

2.92

2.93

untitled.blend

**System Information** Operating system: win 10 Graphics card: rx 6800 **Blender Version** Broken: 2.93 Worked: 2.92 **Short description of error** Recent eevee ao refactor looks like it produces inferior results. geometry is clearly less defined and in new implementation you can even notice glossy shading underneath AO something that is not present in old AO 2.92 ![1.png](https://archive.blender.org/developer/F9829195/1.png) 2.93 ![2.png](https://archive.blender.org/developer/F9829196/2.png) [untitled.blend](https://archive.blender.org/developer/F9811394/untitled.blend)

I did must have done it commented

2021-02-23 04:02:42 +01:00

Added subscriber: @leonardos

I did must have done it commented

2021-02-23 04:16:12 +01:00

https://developer.blender.org/rB64d96f68d6ef0411383bb46d1a95d47769d927e5

I did must have done it commented

2021-02-23 05:12:52 +01:00

Here is a more practical example it looks like there is an issue with more then just AO:

This is 100% exact same scene, only re baked with same settings and everything the same in 2.93 because irradiance from 2.92 doesnt work in 2.93

2.92

2.93

It appears to be a continuation of #85720 and it appears that cd1a083984 commit didnt solve the issue completely therefore #85720 is not resolved properly either.

Here is a more practical example it looks like there is an issue with more then just AO: This is 100% exact same scene, only re baked with same settings and everything the same in 2.93 because irradiance from 2.92 doesnt work in 2.93 2.92 ![a11.png](https://archive.blender.org/developer/F9829388/a11.png) 2.93 ![a2.png](https://archive.blender.org/developer/F9829378/a2.png) It appears to be a continuation of #85720 and it appears that cd1a083984 commit didnt solve the issue completely therefore #85720 is not resolved properly either.

I did must have done it commented

2021-02-23 05:45:39 +01:00

GlossDir 2.92

GlossDir 2.93

GlossCol 2.92

GlossCol 2.93

GlossDir 2.92 ![GlossDir 2.92.png](https://archive.blender.org/developer/F9829488/GlossDir_2.92.png) GlossDir 2.93 ![GlossDir 2.93.png](https://archive.blender.org/developer/F9829487/GlossDir_2.93.png) GlossCol 2.92 ![GlossCol 2.92.png](https://archive.blender.org/developer/F9829484/GlossCol_2.92.png) GlossCol 2.93 ![GlossCol 2.93.png](https://archive.blender.org/developer/F9829486/GlossCol_2.93.png)

I did must have done it changed title from ~~EEVEE AO Refactor produces inferior results~~ to EEVEE 2.93 Incorrect glossy values

2021-02-23 05:47:11 +01:00

Evan Wilson commented

2021-02-23 09:54:15 +01:00

Added subscriber: @EAW

Evan Wilson commented

2021-02-23 09:54:15 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Evan Wilson commented

2021-02-23 09:54:15 +01:00

I am not certain what the result of the AO refactoring is intended to look like. I can confirm however that there is an issue with the glossy passes in EEVEE.

The first issue is that they don’t appear in the viewport when selected from the menu. The shadow pass doesn’t either.

The second issue is how the glossy passes appear in a render. Testing different sample counts, it became clear that the glossy color pass is being divided by the number of samples, while the glossy direct is getting multiplied. The only way to get the values to match the levels from 2.92 and earlier is to render with a single sample.

I am not certain what the result of the AO refactoring is intended to look like. I can confirm however that there is an issue with the glossy passes in EEVEE. The first issue is that they don’t appear in the viewport when selected from the menu. The shadow pass doesn’t either. The second issue is how the glossy passes appear in a render. Testing different sample counts, it became clear that the glossy color pass is being divided by the number of samples, while the glossy direct is getting multiplied. The only way to get the values to match the levels from 2.92 and earlier is to render with a single sample.

Clément Foucault commented

2021-02-23 10:46:34 +01:00

Added subscriber: @fclem

Clément Foucault commented

2021-02-23 10:46:34 +01:00

This is caused by 3 things:

The AO is more correct as it gives less dark values on some regions.
The number of samples was considerably reduced leading to less features for really high radii. This is planned to be fixed.
The thickness heuristic does not yet have a parameter to tweak it. This might reduce shadowing. This is planned to be fixed.

This is caused by 3 things: - The AO is more correct as it gives less dark values on some regions. - The number of samples was considerably reduced leading to less features for really high radii. This is planned to be fixed. - The thickness heuristic does not yet have a parameter to tweak it. This might reduce shadowing. This is planned to be fixed.

I did must have done it commented

2021-02-26 18:26:24 +01:00

In #85908#1117531, @fclem wrote:
This is caused by 3 things:

The AO is more correct as it gives less dark values on some regions.

The number of samples was considerably reduced leading to less features for really high radii. This is planned to be fixed.

The thickness heuristic does not yet have a parameter to tweak it. This might reduce shadowing. This is planned to be fixed.

Ah, great. Is AO then going to be finished for 2.93? What about glossy pass issues? EEVEE is unusable at the moment :/ was really looking forward to test out new AO

> In #85908#1117531, @fclem wrote: > This is caused by 3 things: > - The AO is more correct as it gives less dark values on some regions. > - The number of samples was considerably reduced leading to less features for really high radii. This is planned to be fixed. > - The thickness heuristic does not yet have a parameter to tweak it. This might reduce shadowing. This is planned to be fixed. Ah, great. Is AO then going to be finished for 2.93? What about glossy pass issues? EEVEE is unusable at the moment :/ was really looking forward to test out new AO

Clément Foucault commented

2021-02-26 22:44:26 +01:00

@leonardos Please report the Glossy color pass bug in another report. Do not discuss many issues on one ticket, it makes it hard to follow and manage.

Yes AO is going to be finished for 2.93.

@leonardos Please report the Glossy color pass bug in another report. Do not discuss many issues on one ticket, it makes it hard to follow and manage. Yes AO is going to be finished for 2.93.

Evan Wilson commented

2021-02-27 02:24:47 +01:00

@fclem and @leonardos I’ll create the glossy pass bug report, since I should have split it off before.

Evan Wilson commented

2021-02-27 03:59:44 +01:00

I created #86036 for the Viewport AOV issue, and #86037 for the Rendered AOV issue.

I did must have done it commented

2021-03-07 18:43:15 +01:00

In #85908#1119754, @fclem wrote:
@leonardos Please report the Glossy color pass bug in another report. Do not discuss many issues on one ticket, it makes it hard to follow and manage.

Yes AO is going to be finished for 2.93.

Well issues overlap so first i thought there is somethng wrong with AO because I thought you had fixed the glossy issue by closing #85720 but it turned out it was not fixed. SSR is completely broken and unusable in 2.93 as of now since it gives incorrect results.

> In #85908#1119754, @fclem wrote: > @leonardos Please report the Glossy color pass bug in another report. Do not discuss many issues on one ticket, it makes it hard to follow and manage. > > Yes AO is going to be finished for 2.93. Well issues overlap so first i thought there is somethng wrong with AO because I thought you had fixed the glossy issue by closing #85720 but it turned out it was not fixed. SSR is completely broken and unusable in 2.93 as of now since it gives incorrect results.

Clément Foucault commented

2021-05-19 12:16:17 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Clément Foucault closed this issue

2021-05-19 12:16:17 +02:00

Clément Foucault self-assigned this 2021-05-19 12:16:17 +02:00

Clément Foucault commented

2021-05-19 12:16:17 +02:00

The AO refactor has been finished and the result is now closer to what it was in 2.92.

Thomas Dinges added this to the 2.93 LTS milestone 2023-02-07 18:46:33 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

EEVEE 2.93 Incorrect glossy values #85908