NLA strip's Influence initial keyframe sets to 0 #89339

Open
opened 2021-06-21 23:41:24 +02:00 by Tal Hershkovich · 8 comments

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 398.36

Blender Version
Broken: version: 2.93.0 Beta, branch: master, commit date: 2021-05-19 16:30, hash: 0456223cde
Worked: Never (2.80+)

Short description of error
Influence value is resetting to 0 when adding the initial keyframe to the NLA strip's influence channels. This problem gets worse when adding also keyframes to an active action at the same time. The values of the edited action are changed as well according to the new 0 value of the strip's influence. You can see how the action values change in the sample file's graph editor when adding a keyframe to all channels in the timeline editor.
This problem happens only when keyframing the influence channels in the dopesheet and timeline editor, but the Influence property in general has some more issues, also with updating.

Exact steps for others to reproduce the error
#89339.blend
Add a keyframe in "All channels" in the Timeline editor or a Dopesheet editor on frame 15.
The influence of the NLA strip sets automatically to 0, even if it had a value of 1.

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 398.36 **Blender Version** Broken: version: 2.93.0 Beta, branch: master, commit date: 2021-05-19 16:30, hash: `0456223cde` Worked: Never (2.80+) **Short description of error** Influence value is resetting to 0 when adding the initial keyframe to the NLA strip's influence channels. This problem gets worse when adding also keyframes to an active action at the same time. The values of the edited action are changed as well according to the new 0 value of the strip's influence. You can see how the action values change in the sample file's graph editor when adding a keyframe to all channels in the timeline editor. This problem happens only when keyframing the influence channels in the dopesheet and timeline editor, but the Influence property in general has some more issues, also with updating. **Exact steps for others to reproduce the error** [#89339.blend](https://archive.blender.org/developer/F10187768/T89339.blend) Add a keyframe in "**All channels**" in the Timeline editor or a Dopesheet editor on frame 15. The influence of the NLA strip sets automatically to 0, even if it had a value of 1.

Added subscriber: @TalHershkovich

Added subscriber: @TalHershkovich
Tal Hershkovich changed title from Influence initial keyframe sets to 0 to NLA strip's Influence initial keyframe sets to 0 2021-06-21 23:47:03 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

Added subscriber: @iss

Added subscriber: @iss

@TalHershkovich I am not sure if I understand this:

On top of the NLA there is also an active action with "Add" blend type. You can see in the graph editor that the values of the new keyframes in the active action are modified as well when all the keys are added, it looks like it recalculates and add the values of the current attributes to the active action because of the influence of 0 on the NLA strips.

Feel free to add this to description, but steps to reproduce should be as brief as possible and may contain short description of unexpected outcome.

@TalHershkovich I am not sure if I understand this: > On top of the NLA there is also an **active action** with "Add" blend type. You can see in the graph editor that the values of the new keyframes in the active action are modified as well when all the keys are added, it looks like it recalculates and add the values of the current attributes to the active action because of the influence of 0 on the NLA strips. Feel free to add this to description, but steps to reproduce should be as brief as possible and may contain short description of unexpected outcome.

Added subscriber: @ChrisLend

Added subscriber: @ChrisLend

update to the steps, because it almost made me think it was solved

the bug occurs when the layer incluence receives a key from the graph editor or dope sheet.
With the current demo file, the influence channel is hidden, which means it doesn't get a keyframe so the bug doesn't occur
unhide the channels to get the behaviour

however still an issue in 3.3

update to the steps, because it almost made me think it was solved the bug occurs when the layer incluence receives a key from the graph editor or dope sheet. With the current demo file, the influence channel is hidden, which means it doesn't get a keyframe so the bug doesn't occur unhide the channels to get the behaviour however still an issue in 3.3
Philipp Oeser removed the
Interest
Animation & Rigging
label 2023-02-09 14:35:34 +01:00
Member

Looks like this has been upgraded to a crash. Possibly related to changes in D15003. Will take a look into this.

Looks like this has been upgraded to a crash. Possibly related to changes in [D15003](https://archive.blender.org/developer/D15003). Will take a look into this.
Member

Finding:
There are some major underlying issues with the NLA influence & strip_time properties. These properties never get updates, which allows the value to actually get taken into account, since on evaluation, the rna property to actually get written is the fcurve value

Discussed in 2023-09-14 Animation & Rigging module meeting. Since this has been around for a while (based on 6mo bug triaging rules), we're deprioritizing this from a bug to a known issue.

The new animation system will solve the need for this.

Finding: There are some major underlying issues with the NLA influence & strip_time properties. These [properties](https://projects.blender.org/blender/blender/src/branch/main/source/blender/makesrna/intern/rna_nla.cc#L912) never get updates, which allows the value to actually get taken into account, since on [evaluation](https://projects.blender.org/blender/blender/src/branch/main/source/blender/makesrna/intern/rna_nla.cc#L912), the rna property to actually get written is the [fcurve](https://projects.blender.org/blender/blender/src/branch/main/source/blender/blenkernel/intern/anim_sys.cc#L574) value Discussed in [2023-09-14](https://devtalk.blender.org/t/2023-09-14-animation-rigging-module-meeting-upcoming/31122) Animation & Rigging module meeting. Since this has been around for a while (based on 6mo bug triaging rules), we're deprioritizing this from a bug to a known issue. The [new animation system](https://code.blender.org/2023/07/animation-workshop-june-2023/) will solve the need for this.
Nate Rupsis added
Type
Known Issue
and removed
Type
Report
labels 2023-09-14 18:56:47 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#89339
No description provided.