Circle selection unexpectedly selects whole Fcurve #92883

Closed
opened 2021-11-06 16:13:28 +01:00 by Serge Lyatin · 12 comments

System Information
Operating system: win10
Graphics card: 1050ti

Blender Version
Broken: (3.0 beta)
Worked: (2.79)

Short description of error
Whole curve gets selected if Circle select (C key) is clicked on curve itself and not a keyframe point.
In 2.79 no matter where you've clicked with circle selection: if keyframe isn't inside boundary - nothing will be selected.

Exact steps for others to reproduce the error

  • open file, look at the Graph Editor
  • press C to activate Circle selection

click between keyframes -> all keys are selected

circle_select_fcurve.blend

**System Information** Operating system: win10 Graphics card: 1050ti **Blender Version** Broken: (3.0 beta) Worked: (2.79) **Short description of error** Whole curve gets selected if Circle select (*C* key) is clicked on curve itself and not a keyframe point. In 2.79 no matter where you've clicked with circle selection: if keyframe isn't inside boundary - nothing will be selected. **Exact steps for others to reproduce the error** - open file, look at the *Graph Editor* - press *C* to activate Circle selection # click between keyframes -> all keys are selected [circle_select_fcurve.blend](https://archive.blender.org/developer/F11751399/circle_select_fcurve.blend)
Author

Added subscriber: @SergeL

Added subscriber: @SergeL

#101894 was marked as duplicate of this issue

#101894 was marked as duplicate of this issue

Added subscriber: @mano-wii

Added subscriber: @mano-wii

Changed status from 'Needs Triage' to: 'Archived'

Changed status from 'Needs Triage' to: 'Archived'

Thanks for the report, but this is a new feature implemented in 2246d456aa, discussed and approved in #84901 (Curves Interactions in the Graph Editor).

For requests and feedback, you can try one of this channels: https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests

Thanks for the report, but this is a new feature implemented in 2246d456aa, discussed and approved in #84901 (Curves Interactions in the Graph Editor). For requests and feedback, you can try one of this channels: https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests

Added subscribers: @Dene, @dr.sybren

Added subscribers: @Dene, @dr.sybren

@mano-wii Thanks for merging the duplicate tasks.

Maybe the bug description is not detailed enough. Let me try again:

There are 3 types of Curve Selections: lasso, box, and circle. Their behaviour changed in 3.0. Box and Lasso are good, Circle is broken.

Current behaviour

  • Box selection - it has two types of selection:

    • When the user selects curve points with the box area, he/she selects just the ones inside that box area. One can select different sets of curve points from multiple curves this way
    • If the user selects the curve itself (just the line) without any curve points inside the box area the whole curve with all its curve points will be selected
  • Lasso selection - it has two types of selection similar to the Box selection:

    • When the user selects curve points with the lasso area, he/she selects just the ones inside that lasso area. One can select different sets of curve points from multiple curves this way
    • If the user selects the curve itself (just the line) without any curve points inside the lasso area the whole curve with all its curve points will be selected
  • Circle selection - it is the bugged selection where we have the problem. It's not consistent with the other two selections - Lasso and Box. Instead of having similar two types of selection, it has just one. It either selects all the curve points of the clicked curve. Or randomly switches from selected curve points to all the curve points if you drag your circle selection to the curve line. This behaviour makes the Circle Selection suitable for the selection of only the whole curve which makes no sense for an animator. Use case: cleanup of motion capture animation where animator selects multiple curve points with Circle Selection and interacts with them. Now it's not possible to do.

Expected behaviour of Circle Selection

There should be two selection types as in the other two selections (box, lasso):

  • When the user selects curve points with the Circle Selection, he/she selects just the ones inside that circle area. One can select different sets of curve points from multiple curves this way. It's activated if there is any curve point in the radius of the circle area on click. When dragging the mouse only curve points should be selected within the circle selection radius.
  • When the user selects just the line of the curve without any curve points inside the circle selection radius the whole curve with all its curve points should be selected. It's activated only if there are no curve points in the radius of selection on click.

Thanks.

@mano-wii Thanks for merging the duplicate tasks. Maybe the bug description is not detailed enough. Let me try again: There are 3 types of Curve Selections: lasso, box, and circle. Their behaviour changed in 3.0. Box and Lasso are good, Circle is broken. # Current behaviour - **Box selection** - it has two types of selection: - When the user selects curve points with the box area, he/she selects just the ones inside that box area. One can select different sets of curve points from multiple curves this way - If the user selects the curve itself (just the line) without any curve points inside the box area the whole curve with all its curve points will be selected - **Lasso selection** - it has two types of selection similar to the **Box selection**: - When the user selects curve points with the lasso area, he/she selects just the ones inside that lasso area. One can select different sets of curve points from multiple curves this way - If the user selects the curve itself (just the line) without any curve points inside the lasso area the whole curve with all its curve points will be selected - **Circle selection** - it is the bugged selection where we have the problem. It's not consistent with the other two selections - Lasso and Box. Instead of having similar two types of selection, it has just one. It either selects all the curve points of the clicked curve. Or randomly switches from selected curve points to all the curve points if you drag your circle selection to the curve line. This behaviour makes the Circle Selection suitable for the selection of only the whole curve which makes no sense for an animator. Use case: cleanup of motion capture animation where animator selects multiple curve points with Circle Selection and interacts with them. Now it's not possible to do. # Expected behaviour of Circle Selection There should be two selection types as in the other two selections (box, lasso): - When the user selects curve points with the Circle Selection, he/she selects just the ones inside that circle area. One can select different sets of curve points from multiple curves this way. It's activated if there is any curve point in the radius of the circle area on click. When dragging the mouse only curve points should be selected within the circle selection radius. - When the user selects just the line of the curve without any curve points inside the circle selection radius the whole curve with all its curve points should be selected. It's activated only if there are no curve points in the radius of selection on click. Thanks.

The behavior described for circle selection only happens if you start the selection from the outside (with no point inside) and move towards the curve.
In this case it seems more difficult for a point to be selected before the line. So the curve is more likely to be selected first.
It's a little unpredictable but it doesn't seem like a bug in my opinion.

GIF.gif

The #animation_rigging team can reopen the discussion if it seems necessary.

The behavior described for circle selection only happens if you start the selection from the outside (with no point inside) and move towards the curve. In this case it seems more difficult for a point to be selected before the line. So the curve is more likely to be selected first. It's a little unpredictable but it doesn't seem like a bug in my opinion. ![GIF.gif](https://archive.blender.org/developer/F13707670/GIF.gif) The #animation_rigging team can reopen the discussion if it seems necessary.

@mano-wii

It works in cases like the one you showed. But here is a more real-life example which shows the problem:

Peek 2022-10-18 23-09.gif

And that's just one curve.

@mano-wii It works in cases like the one you showed. But here is a more real-life example which shows the problem: ![Peek 2022-10-18 23-09.gif](https://archive.blender.org/developer/F13707847/Peek_2022-10-18_23-09.gif) And that's just one curve.
Member

Added subscriber: @BClark

Added subscriber: @BClark
Member

In the example Germano posted, it still seems like a bug since one moment it picks the entire curve but then if you drag down, it picks only keys, not the curve.

In the second example, it started to pick just the key, then switches to select the entire curve once moved.

It looks like a bug in that it isn't consistent in what it should be selecting.

In the example Germano posted, it still seems like a bug since one moment it picks the entire curve but then if you drag down, it picks only keys, not the curve. In the second example, it started to pick just the key, then switches to select the entire curve once moved. It looks like a bug in that it isn't consistent in what it should be selecting.
Author

I agree that new behavior feels inconsistent, because one awkward mouse drag and you ruin whole selection already made. Also don't understand what is useful in selecting full fcurve with circle tool, as it can be done by simple double clicking on fcurve's name.

I agree that new behavior feels inconsistent, because one awkward mouse drag and you ruin whole selection already made. Also don't understand what is useful in selecting full fcurve with circle tool, as it can be done by simple double clicking on fcurve's name.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#92883
No description provided.