blender/blender
151
479
Fork 711
Code Issues 6.7k Pull Requests 905 Projects 18 Wiki Activity

Clicking on empty space in editors creates undo step #94080

New Issue
Open
opened 2021-12-14 22:47:34 +01:00 by Garek · 27 comments
Garek commented 2021-12-14 22:47:34 +01:00
Copy Link

Blender Version
Broken: version: 3.0.0, branch: master (modified), commit date: 2021-12-02 18:35, hash: f1cca30557
Broken: version: 2.80
Worked: 2.79b

Short description of error
When clicking in certain Editors (doesn't matter if it's not selecting/doing anything) undo step is created. It does make sense to do in certain cases when selecting objects (for example, when selecting objects via outliner undo to previous selection is logical) but definitely not when there are nothing to select.
Affected Editors/modes:

  • Outliner (3775615aea)
  • Video Sequencer Editor: Sequencer and Sequencer & Preview modes (clicking on image) (5d30c3994e)
  • Dope Sheet: Dope Sheet, Grease Pencil, Mask, Cache File
  • Timeline
  • Graph Editor
  • Drivers: only when clicking on left area,
  • Nonlinear Animation

Where to click:
image.png

Exact steps for others to reproduce the error

  • Open default scene
  • open any editor listed above
  • Click on area of an editor several times (See above image).
  • Notice undo step is created for selection (in reality, we've selected nothing)
**Blender Version** Broken: version: 3.0.0, branch: master (modified), commit date: 2021-12-02 18:35, hash: `f1cca30557` Broken: version: 2.80 Worked: 2.79b **Short description of error** When clicking in certain Editors (doesn't matter if it's not selecting/doing anything) undo step is created. It does make sense to do in certain cases when selecting objects (for example, when selecting objects via outliner undo to previous selection is logical) but definitely not when there are nothing to select. Affected Editors/modes: - [x] Outliner (3775615aea) - [x] Video Sequencer Editor: `Sequencer` and `Sequencer & Preview` modes (clicking on image) (5d30c3994e) - [ ] Dope Sheet: `Dope Sheet`, `Grease Pencil`, `Mask`, `Cache File` - [ ] Timeline - [ ] Graph Editor - [ ] Drivers: only when clicking on left area, - [ ] Nonlinear Animation Where to click: ![image.png](https://archive.blender.org/developer/F12828432/image.png) **Exact steps for others to reproduce the error** - Open default scene - open any editor listed above - Click on area of an editor several times (See above image). - Notice undo step is created for selection (in reality, we've selected nothing)
Garek commented 2021-12-14 22:47:34 +01:00
Author
Copy Link

Added subscriber: @Garek

Added subscriber: @Garek
Germano Cavalcante commented 2021-12-20 21:13:20 +01:00
Member
Copy Link

Added subscriber: @mano-wii

Added subscriber: @mano-wii
Germano Cavalcante commented 2021-12-20 21:13:20 +01:00
Member
Copy Link

Thanks for the report.
This report cannot be resolved in a single commit, as each case mentioned involves a different operator.
Therefore, the ideal would be for them to be mentioned separately :\

Thanks for the report. This report cannot be resolved in a single commit, as each case mentioned involves a different operator. Therefore, the ideal would be for them to be mentioned separately :\
Jesse Yurkovich commented 2021-12-21 12:33:51 +01:00
Member
Copy Link

Added subscriber: @deadpin

Added subscriber: @deadpin
Jesse Yurkovich commented 2021-12-21 12:33:51 +01:00
Member
Copy Link

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Jesse Yurkovich commented 2021-12-21 12:33:51 +01:00
Member
Copy Link

Will mark as confirmed since I can reproduce and there's work being done for it already. I suppose this can be tagged UI for now?

Will mark as confirmed since I can reproduce and there's work being done for it already. I suppose this can be tagged UI for now?
blender-admin commented 2022-01-27 19:30:22 +01:00
Copy Link

This issue was referenced by 3775615aea

This issue was referenced by 3775615aeaf9d7f821053c9c19ee317233e9bd0a
Germano Cavalcante commented 2022-01-27 19:49:11 +01:00
Member
Copy Link

Changed status from 'Confirmed' to: 'Needs User Info'

Changed status from 'Confirmed' to: 'Needs User Info'
Germano Cavalcante commented 2022-01-27 19:49:11 +01:00
Member
Copy Link

The steps only mention the Outliner case, so I'm not sure how to replicate the other cases.

The steps only mention the `Outliner` case, so I'm not sure how to replicate the other cases.
Garek commented 2022-01-27 20:50:26 +01:00
Author
Copy Link

They are the same, only change is affected area.

  1. Select/deselect Cube to create an action you can undo.
  2. Click on working area of an editor several times.
  3. Undo. Notice that your selection/deselection wasn't reverted.

You can see where to click here:
image.png

They are the same, only change is affected area. 1. Select/deselect Cube to create an action you can undo. 2. Click on working area of an editor several times. 3. Undo. Notice that your selection/deselection wasn't reverted. You can see where to click here: ![image.png](https://archive.blender.org/developer/F12828432/image.png)
Germano Cavalcante commented 2022-01-28 14:00:45 +01:00
Member
Copy Link

Changed status from 'Needs User Info' to: 'Confirmed'

Changed status from 'Needs User Info' to: 'Confirmed'
Pratik Borhade commented 2022-02-22 07:00:21 +01:00
Member
Copy Link

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Pratik Borhade commented 2022-11-09 07:49:18 +01:00
Member
Copy Link

@mano-wii hi, can we can move this report under #good_first_issue if you're not planning for remaining changes?
A sample commit(3775615aea) is already available for the reference so I guess it'd be a perfect candidate for new contributors :)

@mano-wii hi, can we can move this report under #good_first_issue if you're not planning for remaining changes? A sample commit(3775615aeaf9) is already available for the reference so I guess it'd be a perfect candidate for new contributors :)
Germano Cavalcante commented 2022-11-09 12:31:10 +01:00
Member
Copy Link

Looks good to me.

Looks good to me.
Suyash Sapkal commented 2023-01-07 19:30:57 +01:00
Copy Link

Added subscriber: @Suyash-Sapkal

Added subscriber: @Suyash-Sapkal
Suyash Sapkal commented 2023-01-07 19:35:54 +01:00
Copy Link

Hi, Can I take this up?
I am new to blender. Can someone guide me on this?

Hi, Can I take this up? I am new to blender. Can someone guide me on this?
Pratik Borhade commented 2023-01-08 05:02:18 +01:00
Member
Copy Link

Hi, sure, feel free to submit the patch.
Similar to 3775615aea you'd need to to do for other editors.
If nothing is selected and state has not changed, then return OPERATOR_CANCELLED in the _exec function (returning this doesn't create undo step).
For example, for timeline editor, start by looking at the actkeys_clickselect_exec function, add breakpoint there. Particularly step into mouse_action_keys() function call.

Hi, sure, feel free to submit the patch. Similar to 3775615aea you'd need to to do for other editors. If nothing is selected and state has not changed, then return `OPERATOR_CANCELLED` in the `_exec` function (returning this doesn't create undo step). For example, for timeline editor, start by looking at the `actkeys_clickselect_exec` function, add breakpoint there. Particularly step into `mouse_action_keys()` function call.
Philipp Oeser removed the
Interest
User Interface
 label 2023-02-10 09:22:38 +01:00
Philipp Oeser added the
Interest
Core
 label 2023-02-10 11:09:24 +01:00
Lucas Tadeu commented 2023-02-22 11:55:08 +01:00
Contributor
Copy Link

@lichtwerk @mano-wii can you update the description here?

I fixed the issue with the Sequencer and the Sequencer Preview in 5d30c3994e

@lichtwerk @mano-wii can you update the description here? I fixed the issue with the Sequencer and the Sequencer Preview in https://projects.blender.org/blender/blender/commit/5d30c3994e6ecf665bfae87d7294216d368f0c59
👍 1
Melissa-Goon commented 2023-03-14 06:22:03 +01:00
Copy Link

Hello! I was wondering if I could contribute to this? I'm new to blender but I'm pretty sure I can figure things out from the previous commits!

Hello! I was wondering if I could contribute to this? I'm new to blender but I'm pretty sure I can figure things out from the previous commits!
Pratik Borhade commented 2023-03-14 06:42:31 +01:00
Member
Copy Link

@Melissa-Goon hi, feel free to work on this. Pick any editor from the list mentioned in the report description.

@Melissa-Goon hi, feel free to work on this. Pick any editor from the list mentioned in the report description.
👍 1
Melissa-Goon commented 2023-03-19 20:18:11 +01:00
Copy Link

Hi! Sorry if I made any mistakes with how I did my pull request but I did this fix on the undo step created when clicking the timeline: 67bf4755c1. Any feedback would be appreciated!

Hi! Sorry if I made any mistakes with how I did my pull request but I did this fix on the undo step created when clicking the timeline: [67bf4755c1](https://projects.blender.org/Melissa-Goon/blender/commit/67bf4755c16c956274c941c246719011e4726b1e). Any feedback would be appreciated!
Pratik Borhade commented 2023-03-20 02:46:46 +01:00
Member
Copy Link

@Melissa-Goon hi, you've commited changes to the main branch of remote repository.
For generating/submitting Pull request, create a branch locally and commit changes to the local branch then push these changes to remote repository.
Refer: https://wiki.blender.org/wiki/Tools/Pull_Requests

@Melissa-Goon hi, you've commited changes to the main branch of remote repository. For generating/submitting Pull request, create a branch locally and commit changes to the local branch then push these changes to remote repository. Refer: https://wiki.blender.org/wiki/Tools/Pull_Requests
Abhiyankar-Shakti commented 2023-03-24 14:01:47 +01:00
Copy Link

Hey @PratikPB2123, can I pick it up as my first issue if no one is working on it?

Hey @PratikPB2123, can I pick it up as my first issue if no one is working on it?
Pratik Borhade commented 2023-03-24 14:12:00 +01:00
Member
Copy Link

@Abhiyankar-Shakti hi, Melissa is working on Timeline. You can choose any from the remaining :)

@Abhiyankar-Shakti hi, Melissa is working on `Timeline`. You can choose any from the remaining :)
sandarm commented 2024-06-21 13:10:19 +02:00
Contributor
Copy Link

Hi @PratikPB2123 and @mano-wii it seems like this problem also happens on the main 3d viewport in Edit Mode although the issue only mentions editor areas like outliner, sequencer, timeline, etc. But on the main 3d viewport the problem can be replicated as:

  1. In 3d viewport select Edit Mode.
  2. Select Vertex of Cube, then deselect it.
  3. Click on any empty area of 3d viewport (any point that doesn't select anything, no other vertex or anything else). Click a few times on empty area of 3d viewport.
  4. Press Ctrl+Z. The Vertex doesn't get re-selected by the undo command. Press Ctrl+Z multiple times again, and the Vertex still doesn't get re-selected (since you clicked on empty area multiple times). Then once you press Ctrl+Z enough times (as many times as you clicked on empty area) then the Vertex gets re-selected.
    Each click on empty area of 3d viewport is creating additional undo steps, although the selection didn't change (nothing selected every time).
    I can see where this is happening in code. Worth adding patch/fix for this on this same issue/bug report, or in a different issue/bug report?
Hi @PratikPB2123 and @mano-wii it seems like this problem also happens on the main 3d viewport in Edit Mode although the issue only mentions editor areas like outliner, sequencer, timeline, etc. But on the main 3d viewport the problem can be replicated as: 1. In 3d viewport select Edit Mode. 1. Select Vertex of Cube, then deselect it. 2. Click on any empty area of 3d viewport (any point that doesn't select anything, no other vertex or anything else). Click a few times on empty area of 3d viewport. 3. Press Ctrl+Z. The Vertex doesn't get re-selected by the undo command. Press Ctrl+Z multiple times again, and the Vertex still doesn't get re-selected (since you clicked on empty area multiple times). Then once you press Ctrl+Z enough times (as many times as you clicked on empty area) then the Vertex gets re-selected. Each click on empty area of 3d viewport is creating additional undo steps, although the selection didn't change (nothing selected every time). I can see where this is happening in code. Worth adding patch/fix for this on this same issue/bug report, or in a different issue/bug report?
Pratik Borhade commented 2024-06-21 13:25:10 +02:00
Member
Copy Link

@SandarM hi, thanks for spotting that. Indeed, make sense to fix this. selection undo step can be skipped when nothing is deselected/selected on click.

Feel free to make PR. Mention this report in commit message.

@SandarM hi, thanks for spotting that. Indeed, make sense to fix this. `selection undo step` can be skipped when nothing is deselected/selected on click. Feel free to make PR. Mention this report in commit message.
sandarm commented 2024-06-21 13:42:50 +02:00
Contributor
Copy Link

ok working on it then

ok working on it then
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset System
Asset datablocks, libraries, browser and shelf

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
Backward and forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Viewport & EEVEE

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Wayland windowing on Unix

  
Interest
Workbench

  
Interest: X11

Xorg/X11 windowing

  
Legacy
Asset Browser Project

Archived

  
Legacy
Blender 2.8 Project

Archived

  
Legacy
Milestone 1: Basic, Local Asset Browser

Archived

  
Legacy
OpenGL Error

Archived

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Related to security, https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Module
Viewport & EEVEE

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Severity
High

  
Severity
Low

  
Severity
Normal

  
Severity
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

Archived

  
Type
Report

Archived

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
10 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#94080
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?