Clicking on empty space in editors creates undo step #94080
Broken: version: 3.0.0, branch: master (modified), commit date: 2021-12-02 18:35, hash:
Broken: version: 2.80
Short description of error
When clicking in certain Editors (doesn't matter if it's not selecting/doing anything) undo step is created. It does make sense to do in certain cases when selecting objects (for example, when selecting objects via outliner undo to previous selection is logical) but definitely not when there are nothing to select.
- Outliner (
- Video Sequencer Editor:
Sequencer & Previewmodes (clicking on image) (
- Dope Sheet:
- Graph Editor
- Drivers: only when clicking on left area,
- Nonlinear Animation
Exact steps for others to reproduce the error
- Open default scene
- open any editor listed above
- Click on area of an editor several times (See above image).
- Notice undo step is created for selection (in reality, we've selected nothing)
Thanks for the report.
This report cannot be resolved in a single commit, as each case mentioned involves a different operator.
Therefore, the ideal would be for them to be mentioned separately :\
Changed status from 'Needs Triage' to: 'Confirmed'
Will mark as confirmed since I can reproduce and there's work being done for it already. I suppose this can be tagged UI for now?
This issue was referenced by
Changed status from 'Confirmed' to: 'Needs User Info'
The steps only mention the
Outliner case, so I'm not sure how to replicate the other cases.
They are the same, only change is affected area.
- Select/deselect Cube to create an action you can undo.
- Click on working area of an editor several times.
- Undo. Notice that your selection/deselection wasn't reverted.
Changed status from 'Needs User Info' to: 'Confirmed'
@mano-wii hi, can we can move this report under #good_first_issue if you're not planning for remaining changes?
A sample commit(
3775615aea) is already available for the reference so I guess it'd be a perfect candidate for new contributors :)
Hi, Can I take this up?
I am new to blender. Can someone guide me on this?
Hi, sure, feel free to submit the patch.
3775615aea you'd need to to do for other editors.
If nothing is selected and state has not changed, then return
OPERATOR_CANCELLED in the
_exec function (returning this doesn't create undo step).
For example, for timeline editor, start by looking at the
actkeys_clickselect_exec function, add breakpoint there. Particularly step into
mouse_action_keys() function call.
I fixed the issue with the Sequencer and the Sequencer Preview in
Hello! I was wondering if I could contribute to this? I'm new to blender but I'm pretty sure I can figure things out from the previous commits!
Hi! Sorry if I made any mistakes with how I did my pull request but I did this fix on the undo step created when clicking the timeline: 67bf4755c1. Any feedback would be appreciated!
@Melissa-Goon hi, you've commited changes to the main branch of remote repository.
For generating/submitting Pull request, create a branch locally and commit changes to the local branch then push these changes to remote repository.
Hey @PratikPB2123, can I pick it up as my first issue if no one is working on it?
No due date set.
No dependencies set.
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?