Multiple calls of 'view3d.select' with LMB selection keymap #95452

New Issue

Germano Cavalcante · 2022-02-02T19:32:46+01:00

2022-02-02 19:32:46 +01:00

System Information
Operating system: Windows-10-10.0.22000-SP0 64 Bits
Graphics card: Radeon (TM) RX 480 Graphics ATI Technologies Inc. 4.5.14760 Core Profile Context 20.45.37.01 27.20.14537.1001

Blender Version
Broken: 2.83, 3.2.0
Worked: Apparently never

Short description of error
In the left-click selection settings, considering only Object Mode in the keymap, there are currently 3 places setting the {key LMB} selection shortcut:

{nav 3D View > 3D View (Global) > Selection}
{nav 3D View > Object Mode > 3D View Tool: Tweak > Selection}
{nav 3D View > Object Mode > 3D View Tool: Tweak (fallback) > Selection}

Respectively each of them can be tested by pressing {key LMB} in the 3D View under the following conditions:

Always active
Active when Tweak Selection Tool is enabled (between selection tools)
Active when fallback selection is Tweak and the Selection Tool is not enabled

The problem is that, in the cases 2 and 3, the key item of 1 is also mapped resulting in view3d.select being called 2 times (since this operator is pass though).

This can be a problem for users editing the settings as they need to make sure the properties of both calls are "compatible".

NOTE: for undo, with the default settings, this is not a problem as an undo step is only added when something changes.

Exact steps for others to reproduce the error

Make sure to use keymap with LMB selection

Testing the Selection Tool Shortcut:

In the 3D view, activate the Tweak selection tool
In the keymap, go to {nav 3D View > Object Mode > 3D View Tool: Tweak > Selection} and disable the option Deselect On Nothing
In the 3d View, select the Cube and then click on an empty region - Note that the Cube has been deselected which is wrong
In the keymap, go to {nav 3D View > 3D View (Global) > Selection} and disable the option Deselect On Nothing
In the 3d View, select the Cube and then click on an empty region - Note that the Cube has not been deselected which is correct.

Testing the Selection Fallback Shortcut:

Re-enable all Deselect On Nothing options and now disable the option located in {nav 3D View > Object Mode > 3D View Tool: Tweak (fallback) > Selection}
In the 3D View, activate a tool other than the selection tool (so the selection fallback will be used)
select the Cube and then click on an empty region - Note that the Cube has been deselected which is wrong
Repeat the last two steps of the selection test with the tool to get the expected result.

**System Information** Operating system: Windows-10-10.0.22000-SP0 64 Bits Graphics card: Radeon (TM) RX 480 Graphics ATI Technologies Inc. 4.5.14760 Core Profile Context 20.45.37.01 27.20.14537.1001 **Blender Version** Broken: 2.83, 3.2.0 Worked: Apparently never **Short description of error** In the left-click selection settings, considering only `Object Mode` in the keymap, there are currently 3 places setting the {key LMB} selection shortcut: 1. {nav 3D View > 3D View (Global) > Selection} 2. {nav 3D View > Object Mode > 3D View Tool: Tweak > Selection} 3. {nav 3D View > Object Mode > 3D View Tool: Tweak (fallback) > Selection} Respectively each of them can be tested by pressing {key LMB} in the `3D View` under the following conditions: 1. Always active 2. Active when `Tweak Selection Tool` is enabled (between selection tools) 3. Active when fallback selection is `Tweak` and the `Selection Tool` is not enabled The problem is that, in the cases `2` and `3`, the key item of `1` is also mapped resulting in `view3d.select` being called 2 times (since this operator is pass though). This can be a problem for users editing the settings as they need to make sure the properties of both calls are "compatible". NOTE: for undo, with the default settings, this is not a problem as an undo step is only added when something changes. **Exact steps for others to reproduce the error** - Make sure to use keymap with LMB selection **Testing the Selection Tool Shortcut:** - In the 3D view, activate the `Tweak` selection tool - In the keymap, go to {nav 3D View > Object Mode > 3D View Tool: Tweak > Selection} and disable the option `Deselect On Nothing` - In the 3d View, select the Cube and then click on an empty region - Note that the Cube has been deselected which is wrong - In the keymap, go to {nav 3D View > 3D View (Global) > Selection} and disable the option `Deselect On Nothing` - In the 3d View, select the Cube and then click on an empty region - Note that the Cube has **not** been deselected which is correct. **Testing the Selection Fallback Shortcut:** - Re-enable all `Deselect On Nothing` options and now disable the option located in {nav 3D View > Object Mode > 3D View Tool: Tweak (fallback) > Selection} - In the 3D View, activate a tool other than the selection tool (so the selection fallback will be used) - select the Cube and then click on an empty region - Note that the Cube has been deselected which is wrong Repeat the last two steps of the selection test with the tool to get the expected result.

Germano Cavalcante commented

2022-02-02 19:32:46 +01:00

Added subscriber: @mano-wii

blender-admin commented

2022-02-02 19:32:46 +01:00

#95504 was marked as duplicate of this issue

blender-admin commented

2022-02-02 19:32:46 +01:00

#95349 was marked as duplicate of this issue

Germano Cavalcante commented

2022-02-02 19:33:13 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Germano Cavalcante commented

2022-02-02 19:34:47 +01:00

Added subscribers: @tiles, @ideasman42, @PratikPB2123

Germano Cavalcante commented

2022-02-07 21:02:24 +01:00

Added subscriber: @HappyOtter

Campbell Barton commented

2022-08-12 08:09:14 +02:00

@mano-wii would you be able to check if this is still an issue? I'm not able to redo the double selection.

tested with 2.93.4 & current master 7f733e294d5485178df800685c69cc15547ee73c.

Used the arguments: --factory-startup --log "wm.operator" --log-level 1 to show operators being called.

I could only get a single selection call to be made with the tweak tool accessed as a fallback the primary tool.

Followed the exact steps, adjusting the key-map etc.

@mano-wii would you be able to check if this is still an issue? I'm not able to redo the double selection. - tested with `2.93.4` & current master `7f733e294d5485178df800685c69cc15547ee73c`. Used the arguments: `--factory-startup --log "wm.operator" --log-level 1` to show operators being called. I could only get a single selection call to be made with the tweak tool accessed as a fallback the primary tool. *Followed the exact steps, adjusting the key-map etc.*

Germano Cavalcante commented

2022-08-12 14:43:54 +02:00

Still an issue.
Here a GIF showing the Deselect On Nothing option still taking effect:

And this is what appears on the console with the arguments given:

INFO (wm.operator): D:\BlenderDev\blender\source\blender\windowmanager\intern\wm_operators.c:807 operator_last_properties_init_impl: loading previous properties for 'VIEW3D_OT_select'
INFO (wm.operator): D:\BlenderDev\blender\source\blender\windowmanager\intern\wm_event_system.cc:968 wm_operator_reports: bpy.ops.view3d.select(deselect_all=True, location=(329, 522))
INFO (wm.operator): D:\BlenderDev\blender\source\blender\windowmanager\intern\wm_operators.c:862 WM_operator_last_properties_store: storing properties for 'VIEW3D_OT_select'

Still an issue. Here a GIF showing the `Deselect On Nothing` option still taking effect: ![GIF.gif](https://archive.blender.org/developer/F13370705/GIF.gif) And this is what appears on the console with the arguments given: ``` INFO (wm.operator): D:\BlenderDev\blender\source\blender\windowmanager\intern\wm_operators.c:807 operator_last_properties_init_impl: loading previous properties for 'VIEW3D_OT_select' INFO (wm.operator): D:\BlenderDev\blender\source\blender\windowmanager\intern\wm_event_system.cc:968 wm_operator_reports: bpy.ops.view3d.select(deselect_all=True, location=(329, 522)) INFO (wm.operator): D:\BlenderDev\blender\source\blender\windowmanager\intern\wm_operators.c:862 WM_operator_last_properties_store: storing properties for 'VIEW3D_OT_select' ```

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Multiple calls of 'view3d.select' with LMB selection keymap #95452