Lattice with modifier (show in editmode enabled) does not show original editlattice -- or misses editpoints on the deformed lattice #95574

New Issue

Open

opened 2022-02-07 06:10:33 +01:00 by Campbell Barton · 11 comments

Campbell Barton commented

2022-02-07 06:10:33 +01:00

Owner

Since 2.8x, lattices have not been displaying selected vertices when the modifier option "Edit Mode" id enabled.

This is easy to test:

add a new lattice object
add a wave deform modifier.
enter edit-mode.
enable "Edit Mode" toggle for the modifier.

This test file shows the problem too, open it and toggle the "Edit Mode" modifier button.

Reporting this to keep track of the issue: BKE_lattice_modifiers_calc is making a copy of the lattice lt_eval which doesn't contain an edit-lattice, which is then used for drawing.

Since 2.8x, lattices have not been displaying selected vertices when the modifier option "Edit Mode" id enabled. This is easy to test: - add a new lattice object - add a wave deform modifier. - enter edit-mode. - enable "Edit Mode" toggle for the modifier. This test file shows the problem too, open it and toggle the "Edit Mode" modifier button. [#77184.blend](https://archive.blender.org/developer/F8571609/T77184.blend) ---- Reporting this to keep track of the issue: `BKE_lattice_modifiers_calc` is making a copy of the lattice `lt_eval` which doesn't contain an edit-lattice, which is then used for drawing.

Campbell Barton commented

2022-02-07 06:10:33 +01:00

Author

Owner

Added subscriber: @ideasman42

Added subscriber: @ideasman42

Philipp Oeser commented

2022-02-07 08:51:09 +01:00

Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser removed the

EEVEE & Viewport

label 2023-02-09 15:12:54 +01:00

yujiaxin commented

2023-09-03 17:41:51 +02:00

version:3.6.2
after my test, even I chose "show in front", vertices of the lattice will still get covered by mesh

version:3.6.2 after my test, even I chose "show in front", vertices of the lattice will still get covered by mesh

4.2 MiB

Philipp Oeser referenced this issue

2024-03-15 15:36:02 +01:00

Lattice with modifier (show in editmode enabled) does not show original editlattice #119268

Philipp Oeser commented

2024-03-15 15:40:06 +01:00

Member

As mentioned in #119268, shouldnt this draw the (editable -- with points) undeformed editlattice? Plus the (deformed) version as wires only?

As mentioned in #119268, shouldnt this draw the (editable -- with points) undeformed editlattice? Plus the (deformed) version as wires only?

Philipp Oeser commented

2024-03-15 16:56:46 +01:00

Member

If we just show the points on the deformed version, it would be like show_in_editmode plus show_on_cage ...

If we just show the points on the deformed version, it would be like `show_in_editmode` plus `show_on_cage` ...

Philipp Oeser commented

2024-03-15 17:05:01 +01:00

Member

Reporting this to keep track of the issue: BKE_lattice_modifiers_calc is making a copy of the lattice lt_eval which doesn't contain an edit-lattice, which is then used for drawing.

I tried looking at this for a bit, and it seems we could share the editlattice with something like the following (but then again we would be only showing the original [undeformed] editlattice -- and would be loosing the evaluated version for drawing -- think this burried deeper / or just missing in the way LatticeRenderData works).

diff --git a/source/blender/blenkernel/intern/lattice.cc b/source/blender/blenkernel/intern/lattice.cc
index fde95d5aa45..9c219a9a705 100644
--- a/source/blender/blenkernel/intern/lattice.cc
+++ b/source/blender/blenkernel/intern/lattice.cc
@@ -559,7 +559,8 @@ void BKE_lattice_modifiers_calc(Depsgraph *depsgraph, Scene *scene, Object *ob)
   Lattice *lt_eval = BKE_object_get_evaluated_lattice(ob);
   if (lt_eval == nullptr) {
     BKE_id_copy_ex(nullptr, &lt->id, (ID **)&lt_eval, LIB_ID_COPY_LOCALIZE);
-    BKE_object_eval_assign_data(ob, &lt_eval->id, true);
+    lt_eval->editlatt = lt->editlatt;
+    BKE_object_eval_assign_data(ob, &lt_eval->id, false);
   }
 
   BKE_lattice_vert_coords_apply(lt_eval, vert_coords);

Subscribing @Sergey @dr.sybren here since they might be interested (and will close #119268 as a duplicate)

>Reporting this to keep track of the issue: BKE_lattice_modifiers_calc is making a copy of the lattice lt_eval which doesn't contain an edit-lattice, which is then used for drawing. I tried looking at this for a bit, and it seems we could share the editlattice with something like the following (but then again we would be only showing the original [undeformed] editlattice -- and would be loosing the evaluated version for drawing -- think this burried deeper / or just missing in the way `LatticeRenderData` works). ```diff diff --git a/source/blender/blenkernel/intern/lattice.cc b/source/blender/blenkernel/intern/lattice.cc index fde95d5aa45..9c219a9a705 100644 --- a/source/blender/blenkernel/intern/lattice.cc +++ b/source/blender/blenkernel/intern/lattice.cc @@ -559,7 +559,8 @@ void BKE_lattice_modifiers_calc(Depsgraph *depsgraph, Scene *scene, Object *ob) Lattice *lt_eval = BKE_object_get_evaluated_lattice(ob); if (lt_eval == nullptr) { BKE_id_copy_ex(nullptr, &lt->id, (ID **)&lt_eval, LIB_ID_COPY_LOCALIZE); - BKE_object_eval_assign_data(ob, &lt_eval->id, true); + lt_eval->editlatt = lt->editlatt; + BKE_object_eval_assign_data(ob, &lt_eval->id, false); } BKE_lattice_vert_coords_apply(lt_eval, vert_coords); ``` Subscribing @Sergey @dr.sybren here since they might be interested (and will close #119268 as a duplicate)

Philipp Oeser changed title from ~~Lattices don't display selected vertices with modifier "Edit Mode" enabled~~ to Lattice with modifier (show in editmode enabled) does not show original editlattice -- or misses editpoints on the deformed lattice

2024-03-15 17:06:09 +01:00

Philipp Oeser referenced this issue

2024-03-15 17:07:36 +01:00

Lattice with modifier (show in editmode enabled) does not show original editlattice #119268

Philipp Oeser added the

Animation & Rigging

Dependency Graph

labels 2024-03-15 17:08:05 +01:00

Sergey Sharybin commented

2024-03-18 11:48:44 +01:00

Owner

@lichtwerk Assigning lt_eval->editlatt = lt->editlatt; seems correct to me.
The change to the non-owning evaluated result (true -> false in the BKE_object_eval_assign_data(ob, &lt_eval->id, false);) seems strange as the lt_eval is allocated by the BKE_id_copy_ex(nullptr, &lt->id, (ID **)&lt_eval, LIB_ID_COPY_LOCALIZE); above. So intuitively this cases a leak.

Maybe you can move the patch to a PR, so we can discuss details there instead of a bug report?

@lichtwerk Assigning `lt_eval->editlatt = lt->editlatt;` seems correct to me. The change to the non-owning evaluated result (`true` -> `false` in the `BKE_object_eval_assign_data(ob, &lt_eval->id, false);`) seems strange as the `lt_eval` is allocated by the `BKE_id_copy_ex(nullptr, &lt->id, (ID **)&lt_eval, LIB_ID_COPY_LOCALIZE);` above. So intuitively this cases a leak. Maybe you can move the patch to a PR, so we can discuss details there instead of a bug report?

Philipp Oeser commented

2024-03-18 16:17:10 +01:00

Member

@Sergey : just sharing the editlatt leads to crashes in lattice_free_data when show_in_editmode is used and you switch modes.

Think I need to dig a bit more wrt ownership etc. before I can put up a PR

@Sergey : just sharing the `editlatt` leads to crashes in `lattice_free_data` when `show_in_editmode` is used and you switch modes. Think I need to dig a bit more wrt ownership etc. before I can put up a PR

Sergey Sharybin commented

2024-03-18 16:57:08 +01:00

Owner

@lichtwerk Ah, indeed. Because Lattice is owning the EditLatt. Perhaps the EditLatt should have something similar to BMEditMesh::is_shallow_copy.

@lichtwerk Ah, indeed. Because `Lattice` is owning the `EditLatt`. Perhaps the `EditLatt` should have something similar to `BMEditMesh::is_shallow_copy`.

Sybren A. Stüvel commented

2024-03-19 16:11:39 +01:00

Member

@Sergey wrote:
Assigning lt_eval->editlatt = lt->editlatt; seems correct to me.

I'm not intimately familiar with the lattice data structures. At first glance I wonder whether this wouldn't be a case of an evaluated copy pointing to non-evaluated data?

> @Sergey wrote: > Assigning `lt_eval->editlatt = lt->editlatt;` seems correct to me. I'm not intimately familiar with the lattice data structures. At first glance I wonder whether this wouldn't be a case of an evaluated copy pointing to non-evaluated data?

Sergey Sharybin commented

2024-03-20 15:58:11 +01:00

Owner

@dr.sybren The edit mode is the source of truth, and is shared between original and evaluated state. You can see mesh_final->edit_mesh manipulation in the editbmesh_calc_modifiers.

@dr.sybren The edit mode is the source of truth, and is shared between original and evaluated state. You can see `mesh_final->edit_mesh` manipulation in the `editbmesh_calc_modifiers`.

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

5 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#95574

No description provided.