The Replacement of Outliner Histories on use of Redo panel #96006

New Issue

B-Lee · 2022-02-24T03:14:50+01:00

B-Lee commented

2022-02-24 03:14:50 +01:00

Operating system: Microsoft Windows 10 Pro (Version 10.0.19043 Build 19043)
Graphics card: NVIDIA GeForce GTX 1060 6GB (GeForce Game Ready Driver Version 496.49)

Blender-3.0.1, Hash: dc2d180181, windows64, Factory setting and Factory Preferences.
Blender-3.2.0-alpha, Hash: master.fcda858e3200, windows64, Factory setting and Factory Preferences.

Short Description
Previous changes are lost on use of Redo panel.

steps to Reproduce

Make any operation, such as move the lamp object, and call out the Adjust Last Operation panel at the bottom left corner.
Make adjustment on Outliner list such as Exclude from View Layer, Selectable, Hide in Viewport, Disable in Viewports, Disable in Renders, Holdout, Indirect Only, but make sure the object of (1.) above still active and Adjust Last Operation panel still editable.
Make any new operation by using the existing Adjust Last Operation panel, and the histories about adjusting Outliner will replaced by this new operation. And all adjustment previously made on Outliner been reset to the early stage.
Desktop 2022.02.24 - 09.02.25.02.mp4

Operating system: Microsoft Windows 10 Pro (Version 10.0.19043 Build 19043) Graphics card: NVIDIA GeForce GTX 1060 6GB (GeForce Game Ready Driver Version 496.49) Blender-3.0.1, Hash: dc2d18018171, windows64, Factory setting and Factory Preferences. Blender-3.2.0-alpha, Hash: master.fcda858e3200, windows64, Factory setting and Factory Preferences. **Short Description** Previous changes are lost on use of Redo panel. **steps to Reproduce** 1. Make any operation, such as move the lamp object, and call out the Adjust Last Operation panel at the bottom left corner. 2. Make adjustment on Outliner list such as Exclude from View Layer, Selectable, Hide in Viewport, Disable in Viewports, Disable in Renders, Holdout, Indirect Only, but make sure the object of (1.) above still active and Adjust Last Operation panel still editable. 3. Make any new operation by using the existing Adjust Last Operation panel, and the histories about adjusting Outliner will replaced by this new operation. And all adjustment previously made on Outliner been reset to the early stage. [Desktop 2022.02.24 - 09.02.25.02.mp4](https://archive.blender.org/developer/F12884934/Desktop_2022.02.24_-_09.02.25.02.mp4)

B-Lee commented

2022-02-24 03:14:50 +01:00

Added subscriber: @toki46-3

Pratik Borhade commented

2022-02-24 07:36:05 +01:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-02-24 08:08:24 +01:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Pratik Borhade commented

2022-02-24 08:08:24 +01:00

Added subscriber: @ideasman42

Pratik Borhade commented

2022-02-24 08:08:24 +01:00

Second issue you have described is already fixed on latest 3.1.0 and 3.2.0 version: #93629 (so I removed that section from your report)
Re first issue: Use of redo panel will consider that operation as active.
In your case, when you preform Move operation from redo panel, we search for the operator which name "Move" in undo stack (ed_undo_step_by_name) and later we make that as active step.
(BKE_undosys_step_load_data_ex: https://developer.blender.org/diffusion/B/browse/master/source/blender/blenkernel/intern/undo_system.c$710)
That said all previous changes were lost from the undo history.
I think we can close this report but I'm not really sure if my understanding is correct. @ideasman42 , can you check?

Second issue you have described is already fixed on latest 3.1.0 and 3.2.0 version: #93629 (so I removed that section from your report) Re first issue: Use of redo panel will consider that operation as active. In your case, when you preform Move operation from redo panel, we search for the operator which name "Move" in undo stack (`ed_undo_step_by_name`) and later we make that as active step. (`BKE_undosys_step_load_data_ex`: https://developer.blender.org/diffusion/B/browse/master/source/blender/blenkernel/intern/undo_system.c$710) That said all previous changes were lost from the undo history. I think we can close this report but I'm not really sure if my understanding is correct. @ideasman42 , can you check?

Pratik Borhade changed title from ~~The Replacement of Outliner Histories, and The Purge of Data-Blocks~~ to The Replacement of Outliner Histories on use of Redo panel

2022-02-24 08:10:33 +01:00

Campbell Barton commented

2022-02-24 11:17:57 +01:00

The actions in the outliner could cause the redo panel to be hidden, although I don't think this is such a high priority.

Note that this happens for changing properties & number buttons too (not only outliner operations).

The actions in the outliner could cause the redo panel to be hidden, although I don't think this is such a high priority. Note that this happens for changing properties & number buttons too (not only outliner operations).

Campbell Barton commented

2022-02-24 11:18:16 +01:00

Changed status from 'Needs Developer To Reproduce' to: 'Confirmed'