Regression: Resizing an image is not correctly reflected in the image editor until the UI is updated #96324

New Issue

Alaska · 2022-03-11T07:15:54+01:00

Alaska commented

2022-03-11 07:15:54 +01:00

System Information
Operating system: Linux-5.16.0-3-amd64-x86_64-with-glibc2.33 64 Bits
Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 510.54

Blender Version
Broken version: 3.2.0 Alpha, branch: master, commit date: 2022-03-11 04:29, hash: f6564df351
Broken version: 3.1 Release
Worked: All versions prior to commit 5e9c1feb8a

Short description of error
Resizing an image in the image editor will not update correct. A correct update will occur once the UI is changed. This may be related to #96312 (Regression: Image Editor Flip option isn't working) and #96323 (Regression: Invert colour is not reflected in the image viewer until a UI change )

Here is a video demonstrating the issue:
Resize not updating.mp4

Exact steps for others to reproduce the error

Load an image in the image editor.
Select from the top {nav Image > Resize} and change the size of the image.
Notice how the image has not been properly updated. Split the editor and the image will update to the correct result.

**System Information** Operating system: Linux-5.16.0-3-amd64-x86_64-with-glibc2.33 64 Bits Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 510.54 **Blender Version** Broken version: 3.2.0 Alpha, branch: master, commit date: 2022-03-11 04:29, hash: `f6564df351` Broken version: 3.1 Release Worked: All versions prior to commit 5e9c1feb8a **Short description of error** Resizing an image in the image editor will not update correct. A correct update will occur once the UI is changed. This may be related to #96312 (Regression: Image Editor Flip option isn't working) and #96323 (Regression: Invert colour is not reflected in the image viewer until a UI change ) Here is a video demonstrating the issue: [Resize not updating.mp4](https://archive.blender.org/developer/F12920753/Resize_not_updating.mp4) **Exact steps for others to reproduce the error** 1. Load an image in the image editor. 2. Select from the top {nav Image > Resize} and change the size of the image. 3. Notice how the image has not been properly updated. Split the editor and the image will update to the correct result.

Alaska commented

2022-03-11 07:15:54 +01:00

Added subscriber: @Alaska

Alaska commented

2022-03-11 07:16:13 +01:00

Added subscriber: @Jeroen-Bakker

Alaska commented

2022-03-11 07:16:13 +01:00

CC @Jeroen-Bakker as you worked on a fix for a similar issue.

Pratik Borhade commented

2022-03-11 08:06:12 +01:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-03-11 08:10:41 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade commented

2022-03-11 08:10:41 +01:00

Worked: Presumably prior to 507a4deef1

Not this time :)
This is actually broke between eb0f8317e2 - eabdcdcd44

> Worked: Presumably prior to 507a4deef1 Not this time :) This is actually broke between eb0f8317e231 - eabdcdcd44b9

Alaska commented

2022-03-11 10:21:22 +01:00

You're right, it is caused by 5e9c1feb8a instead

You're right, it is caused by 5e9c1feb8a instead

Francois commented

2022-03-12 07:11:51 +01:00

Added subscriber: @FrancoisRoussel-3

Pratik Borhade commented

2022-03-19 12:13:13 +01:00

Following change fixes the issue for me. This is same as the fix of #96163

index 3721ea81c04..b48ec4be24c 100644
    - a/source/blender/editors/space_image/image_ops.c
+++ b/source/blender/editors/space_image/image_ops.c
@@ -2992,7 +2992,7 @@ static int image_scale_exec(bContext *C, wmOperator *op)

ED_image_undo_push_end();

/* Force GPU re-upload, all image is invalid. */

- BKE_image_free_gputextures(ima);
+  BKE_image_partial_update_mark_full_update(ima);

DEG_id_tag_update(&ima->id, 0);
WM_event_add_notifier(C, NC_IMAGE | NA_EDITED, ima);```

Following change fixes the issue for me. This is same as the fix of #96163 ```diff --git a/source/blender/editors/space_image/image_ops.c b/source/blender/editors/space_image/image_ops.c index 3721ea81c04..b48ec4be24c 100644 - a/source/blender/editors/space_image/image_ops.c +++ b/source/blender/editors/space_image/image_ops.c @@ -2992,7 +2992,7 @@ static int image_scale_exec(bContext *C, wmOperator *op) ``` ED_image_undo_push_end(); ``` ``` /* Force GPU re-upload, all image is invalid. */ ``` - BKE_image_free_gputextures(ima); + BKE_image_partial_update_mark_full_update(ima); ``` DEG_id_tag_update(&ima->id, 0); WM_event_add_notifier(C, NC_IMAGE | NA_EDITED, ima);```

Philipp Oeser changed title from ~~Resizing an image is not correctly reflected in the image editor until the UI is updated~~ to Regression: Resizing an image is not correctly reflected in the image editor until the UI is updated

2022-03-22 16:06:24 +01:00

Jeroen Bakker was assigned by Dalai Felinto

2022-03-25 16:10:53 +01:00

blender-admin commented

2022-03-25 16:30:10 +01:00

This issue was referenced by f6e2c9bc97

This issue was referenced by f6e2c9bc97d297dab2b8926fae1689ca1807bb7c

blender-admin commented

2022-03-25 16:30:10 +01:00

This issue was referenced by 2fc77071b5

This issue was referenced by 2fc77071b51a7c3ee16c50836d380ed339681992

Jeroen Bakker commented

2022-03-25 16:38:18 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Jeroen Bakker closed this issue

2022-03-25 16:38:18 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Regression: Resizing an image is not correctly reflected in the image editor until the UI is updated #96324