Add Color Attribute: hex colors don't work #99036

New Issue

Scurest · 2022-06-21T04:28:33+02:00

Scurest commented

2022-06-21 04:28:33 +02:00

System Information
Operating system: Linux

Blender Version
Broken: blender-3.3.0-alpha+master.e6e9f1ac5a2d

Short description of error
When creating a new color attribute, if a hex color is entered as the default color, it is not gamma corrected properly.

Exact steps for others to reproduce the error
Add a color attribute to the default cube (the + button in the Color Attributes panel). I'll use Byte Color, but it happens for Float Color the same way. Click the Color field, pick Hex, and enter #FA8072 (which is 250, 128, 114). Hit OK. You can see the color on the cube is different than the color shown in the color picker. The values in the spreadsheet are also wrong.

If you switch to the RGB tab after you put in the hex color, you can read the values (0.980 0.502 0.447). It appears that #FA8072 is not being gamma corrected (not converted from sRGB). Interestingly if you put the same hex color in a color picker for a shader node, you will get the correct (linear) result in the RGB tab. It seems only this particular color picker is affected.

**System Information** Operating system: Linux **Blender Version** Broken: blender-3.3.0-alpha+master.e6e9f1ac5a2d **Short description of error** When creating a new color attribute, if a hex color is entered as the default color, it is not gamma corrected properly. **Exact steps for others to reproduce the error** Add a color attribute to the default cube (the + button in the Color Attributes panel). I'll use Byte Color, but it happens for Float Color the same way. Click the Color field, pick Hex, and enter #FA8072 (which is 250, 128, 114). Hit OK. You can see the color on the cube is different than the color shown in the color picker. The values in the spreadsheet are also wrong. ![ss2.png](https://archive.blender.org/developer/F13210024/ss2.png) If you switch to the RGB tab after you put in the hex color, you can read the values (0.980 0.502 0.447). It appears that #FA8072 is not being gamma corrected (not converted from sRGB). Interestingly if you put the same hex color in a color picker for a shader node, you will get the correct (linear) result in the RGB tab. It seems only this particular color picker is affected.

Scurest commented

2022-06-21 04:28:33 +02:00

Added subscriber: @scurest

Scurest changed title from ~~Add Color Attribute: hex input doesn't work~~ to Add Color Attribute: hex colors don't work

2022-06-21 04:29:04 +02:00

Pratik Borhade commented

2022-06-21 05:48:43 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade commented

2022-06-21 05:48:46 +02:00

Added subscriber: @PratikPB2123

Scurest commented

2022-06-21 19:44:41 +02:00

Perhaps in GEOMETRY_OT_color_attribute_add, RNA_def_property_subtype(prop, PROP_COLOR_GAMMA); should use PROP_COLOR instead of PROP_COLOR_GAMMA?

7140016838/source/blender/editors/geometry/geometry_attributes.cc (L409)

Perhaps in GEOMETRY_OT_color_attribute_add, `RNA_def_property_subtype(prop, PROP_COLOR_GAMMA);` should use PROP_COLOR instead of PROP_COLOR_GAMMA? https://github.com/blender/blender/blob/714001683888770f9d870ba73edd65f4c2757bda/source/blender/editors/geometry/geometry_attributes.cc#L409

Ramil Roosileht commented

2022-06-22 19:28:06 +02:00

Added subscriber: @Limarest