Add Selection functionality to weight painting mode #99113

Closed
opened 2022-06-23 18:57:57 +02:00 by Marion Stalke · 22 comments
Member

As discussed in today's #animation_rigging module meeting:

Many selection shortcuts don't work in weightpaint mode.
f.e. to select a single part of a mesh you always have to go back to edit mode, select it with "L" and set the weights there via vertex panel.
It would be awesome to have following short cuts to work as well

  • {key L} to select parts of a model (Already works in Face Select Mode)
  • Ctrl +/- for expanding/contracting face selection : #105607
  • Ctrl +/- for expanding/contracting vertex selection: #105633
  • {key Alt LMB} select a "ring" (implemented for faces)

Edit from @ChrisLend
In order to see the selection options you need to have either Face- or Vertex selection active: image.png
This also makes the Select menu to the right show up. This menu has different entries depending on which mode you are in.
Operators need to be implemented for both modes and added to their respective menu.

As discussed in today's #animation_rigging module meeting: Many selection shortcuts don't work in weightpaint mode. f.e. to select a single part of a mesh you always have to go back to edit mode, select it with "L" and set the weights there via vertex panel. It would be awesome to have following short cuts to work as well - [x] {key L} to select parts of a model (Already works in Face Select Mode) - [x] Ctrl +/- for expanding/contracting face selection : #105607 - [x] Ctrl +/- for expanding/contracting vertex selection: #105633 - [ ] {key Alt LMB} select a "ring" (implemented for faces) Edit from @ChrisLend In order to see the selection options you need to have either Face- or Vertex selection active: ![image.png](https://archive.blender.org/developer/F14082779/image.png) This also makes the `Select` menu to the right show up. This menu has different entries depending on which mode you are in. Operators need to be implemented for both modes and added to their respective menu.
Author
Member

Added subscriber: @EosFoxx

Added subscriber: @EosFoxx

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

Added subscriber: @FedericaGallo

Added subscriber: @FedericaGallo

Hello everybody, nice to get to know you all

If I don't go wrong with it , these ones are the files : paint_intern.h, paint_utils.c, paint_ops.c
we can add something like "PAINT_OT_vert_select_linked" in order to implement the first requirement (L to select parts of a model)

If we want to select the linked vertices, I would take MESH_OT_select_linked_pick in editmesh_select.c as a reference
image.png

Hello everybody, nice to get to know you all If I don't go wrong with it , these ones are the files : paint_intern.h, paint_utils.c, paint_ops.c we can add something like "PAINT_OT_vert_select_linked" in order to implement the first requirement (L to select parts of a model) If we want to select the linked vertices, I would take MESH_OT_select_linked_pick in editmesh_select.c as a reference ![image.png](https://archive.blender.org/developer/F13283887/image.png)

Added subscriber: @ArtisticBee

Added subscriber: @ArtisticBee
Edward self-assigned this 2022-10-25 19:37:04 +02:00

Removed subscriber: @ArtisticBee

Removed subscriber: @ArtisticBee

Added subscriber: @ChrisLend

Added subscriber: @ChrisLend

So I started looking at this.

It's been a while since I used weight painting in Blender. But I found out that
{key L} and {key Ctrl} {key L} already work but only in Face select mode. Not in vertex select mode though

I will update the task with a more detailled description.

So I started looking at this. It's been a while since I used weight painting in Blender. But I found out that {key L} and {key Ctrl} {key L} already work but only in Face select mode. Not in vertex select mode though I will update the task with a more detailled description.
Edward was unassigned by Sybren A. Stüvel 2023-01-11 17:13:28 +01:00
Christoph Lendenfeld was assigned by Sybren A. Stüvel 2023-01-11 17:13:28 +01:00

Added subscriber: @edward88

Added subscriber: @edward88

This issue was referenced by 04aab7d516

This issue was referenced by 04aab7d51620d74c408d7e3e8f5296ce2af793f3
Philipp Oeser removed the
Interest
Animation & Rigging
label 2023-02-09 14:34:48 +01:00
Sybren A. Stüvel added this to the Animation & Rigging project 2023-02-09 16:55:02 +01:00
Member

If the proposed keymap changes go into Blender 4.0 like currently outlined, the Alt LMB keybindings are already taken by other select operators:
https://devtalk.blender.org/t/draw-paint-sculpting-keymap-proposal-feedback-request/29253

The idea is to make it more consistent across painting and scuilpting modes which keys are used for selection between left & right click select.

The main benefit for Weight Paint Mode for example is that Shift LMB and Ctrl LMB can be used for inverted and smoothing brush strokes.

Action LCS RCS
Context Menu RMB W
Set Selection Alt LMB RMB
Extend/Toggle Selection Alt Shift LMB Shift RMB
Lasso Select Ctrl RMB None
Lasso Deselect Ctrl Shift RMB Ctrl Shift LMB

Alt RMB, Shift Alt RMB and Shift Alt Ctrl RMB would be availible for loop selection in RCS. But this isn't as straight forward in LCS.

If the proposed keymap changes go into Blender 4.0 like currently outlined, the `Alt LMB` keybindings are already taken by other select operators: https://devtalk.blender.org/t/draw-paint-sculpting-keymap-proposal-feedback-request/29253 The idea is to make it more consistent across painting and scuilpting modes which keys are used for selection between left & right click select. The main benefit for Weight Paint Mode for example is that `Shift LMB` and `Ctrl LMB` can be used for inverted and smoothing brush strokes. | Action | LCS | RCS | | -------- | -------- | -------- | | Context Menu | RMB | W | | Set Selection | Alt LMB | RMB | | Extend/Toggle Selection | Alt Shift LMB | Shift RMB | | Lasso Select | Ctrl RMB | None | | Lasso Deselect | Ctrl Shift RMB | Ctrl Shift LMB | `Alt RMB`, `Shift Alt RMB` and `Shift Alt Ctrl RMB` would be availible for loop selection in RCS. But this isn't as straight forward in LCS.

is there a place for loop select then?
unless we make it a tool it's hard to put in a menu

is there a place for loop select then? unless we make it a tool it's hard to put in a menu
Member

The default answer to this question should be: Switch to a selection tool with the shortcut W (Box, lasso, circle select)
Then LMB is less in conflict beween action and selection operators.

  • RCS will not suffer from this issue.
  • LCS need to use a selection tool for loop select and ring select shortcuts (and shortest path selection if this ever gets supported)
  • 3 Mouse button emulation has even less selection keybindings at they disposal and also need to switch the tool for select and select extend.
The default answer to this question should be: Switch to a selection tool with the shortcut `W` (Box, lasso, circle select) Then LMB is less in conflict beween **action** and **selection** operators. - RCS will not suffer from this issue. - LCS need to use a selection tool for **loop select** and **ring select** shortcuts (and **shortest path** selection if this ever gets supported) - 3 Mouse button emulation has even less selection keybindings at they disposal and also need to switch the tool for **select** and **select extend**.

So it would be a selection tool like the box, lasso etc tool
under here. I can live with that
image

So it would be a selection tool like the box, lasso etc tool under here. I can live with that ![image](/attachments/39e38acf-5aef-4089-b866-ee653958acb3)
Member

Just to be clear, the loop/ring select operators would not be new tools.
They would be part of the keymap for the selection tools.
So instead of adding the shortcuts to weight paint mode, they should be part of the selection tools keymap.

Just to be clear, the loop/ring select operators would not be new tools. They would be part of the keymap for the selection tools. So instead of adding the shortcuts to weight paint mode, they should be part of the selection tools keymap.
Member

Just noting that #83804 came up recently again, and taking away available keys somewhat contradicts having a key available to signal you actually dont want to select faces (but bones instead) -- this needs a bit of thinking though, just wanted to drop the case here.

Just noting that #83804 came up recently again, and taking away available keys somewhat contradicts having a key available to signal you actually **dont** want to select faces (but bones instead) -- this needs a bit of thinking though, just wanted to drop the case here.
Author
Member

just seen this now and the Loop Select is actually pretty important.
I switch to edit mode all the time to select loops. So I can set clean weights

when is "Set Selection Alt LMB" actually used ^^' It does nothing curently or it doesnt work ?
Couldnt google anything up

just seen this now and the Loop Select is actually pretty important. I switch to edit mode all the time to select loops. So I can set clean weights when is "Set Selection Alt LMB" actually used ^^' It does nothing curently or it doesnt work ? Couldnt google anything up
Member

just seen this now and the Loop Select is actually pretty important.
I switch to edit mode all the time to select loops. So I can set clean weights

when is "Set Selection Alt LMB" actually used ^^' It does nothing curently or it doesnt work ?
Couldnt google anything up

This was added in 98d48c16a3
If it doesnt work for you, you could open a bugreport for this?

Btw., this task now seems complete?

> just seen this now and the Loop Select is actually pretty important. > I switch to edit mode all the time to select loops. So I can set clean weights > > when is "Set Selection Alt LMB" actually used ^^' It does nothing curently or it doesnt work ? > Couldnt google anything up This was added in https://projects.blender.org/blender/blender/commit/98d48c16a33789388dfebfff2e16592f26f9f62f If it doesnt work for you, you could open a bugreport for this? Btw., this task now seems complete?

Btw., this task now seems complete?

Not quite the vertex loop select is still missing

> Btw., this task now seems complete? Not quite the vertex loop select is still missing
Christoph Lendenfeld removed their assignment 2023-07-28 13:16:28 +02:00

stepping down from this because I don't know how to get the vertex loop select working
here is the abandoned patch
#108770: WIP: Paint: Vertex loop select

stepping down from this because I don't know how to get the vertex loop select working here is the abandoned patch [#108770: WIP: Paint: Vertex loop select](https://projects.blender.org/blender/blender/pulls/108770)
Member

Also note that like I pointed out before, the selection shortcuts were updated and loop selection is only availible while a selection tool is active: fb54d3f865

Unless right click select is used. In that case they are available anytime.

Also note that like I pointed out before, the selection shortcuts were updated and loop selection is only availible while a selection tool is active: https://projects.blender.org/blender/blender/commit/fb54d3f865928ebe4042eb1a3a12eb02709332b8 Unless right click select is used. In that case they are available anytime.

as discussed in yesterdays module meeting this task will be closed. Loop select for vertices was running into technical difficulties and abandoned, everything else is done.
We can revisit loop select for vertices separately at a later date if required

as discussed in [yesterdays module meeting](https://devtalk.blender.org/t/2023-09-14-animation-rigging-module-meeting/31122) this task will be closed. Loop select for vertices was running into technical difficulties and abandoned, everything else is done. We can revisit loop select for vertices separately at a later date if required
Blender Bot added
Status
Archived
and removed
Status
Confirmed
labels 2023-09-15 15:30:26 +02:00
Christoph Lendenfeld removed this from the Animation & Rigging project 2023-10-19 14:14:54 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
8 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#99113
No description provided.