Editing a curve node in edit mode breaks undos #99922

Closed
opened 2022-07-23 01:48:05 +02:00 by Vincent Boistel · 4 comments

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2060 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.59

Blender Version
Broken: version: 3.2.1, branch: master, commit date: 2022-07-05 15:44, hash: `a2d59b2dac

Short description of error
If a "curve" node is edited while the viewport is on edit mode, undos don't do anything until edit mode is left.

Exact steps for others to reproduce the error

  • Go in edit mode
  • Modify a curve node in any way (RGB Curve, Float Curve and Vector Curve node all share this issue), this is shown in the undo history as "Unknown action"
  • Without leaving edit mode, press the undo button (or Ctrl+Z)

Now, undo won't do anything until you reach the point where you switched to edit mode (anything past that can't be undone), and moving through the undo history won't work at all. Going out of edit mode fixes this.

Editing the curve in object mode doesn't break undos, but it still is shown as "Unknown action" in the undo history.

Tested in old versions up to 2.8 (I don't know how to access shader nodes in 2.7 and before), couldn't find a single version that didn't have this bug.

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2060 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.59 **Blender Version** Broken: version: 3.2.1, branch: master, commit date: 2022-07-05 15:44, hash: `a2d59b2dac **Short description of error** If a "curve" node is edited while the viewport is on edit mode, undos don't do anything until edit mode is left. **Exact steps for others to reproduce the error** - Go in edit mode - Modify a curve node in any way (RGB Curve, Float Curve and Vector Curve node all share this issue), this is shown in the undo history as "Unknown action" - Without leaving edit mode, press the undo button (or Ctrl+Z) Now, undo won't do anything until you reach the point where you switched to edit mode (anything past that can't be undone), and moving through the undo history won't work at all. Going out of edit mode fixes this. Editing the curve in object mode doesn't break undos, but it still is shown as "Unknown action" in the undo history. Tested in old versions up to 2.8 (I don't know how to access shader nodes in 2.7 and before), couldn't find a single version that didn't have this bug.

Added subscriber: @Masaru641

Added subscriber: @Masaru641
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Member

Thanks for the report. This is a global vs edit-mode undo issue.
In edit mode, undo steps stores data for the changes occurred in editmesh, editcurve, etc. and all other changes like keyframe, nodes, UI, etc. are ignored (they are handled in global undo).
We already have a report for this so I'll close this as duplicate: #71895 (Undo doesn't consider changes in nodetree when object is in edit and texture paint mode)

Thanks for the report. This is a global vs edit-mode undo issue. In edit mode, undo steps stores data for the changes occurred in editmesh, editcurve, etc. and all other changes like keyframe, nodes, UI, etc. are ignored (they are handled in global undo). We already have a report for this so I'll close this as duplicate: #71895 (Undo doesn't consider changes in nodetree when object is in edit and texture paint mode)
Member

Closed as duplicate of #71895

Closed as duplicate of #71895
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#99922
No description provided.