blender
/
blender
136
406
Fork 589
Code Issues 6.3k Pull Requests 765 Projects 19 Wiki Activity

Cleanup: Use utility function to find groups in node tree #104465

Merged
Hans Goudey merged 23 commits from mod_moder/blender:is_contains into main 2023-02-10 17:30:57 +01:00
Conversation 3 Commits 23 Files Changed 7 +1 -5
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 17b97e41e0 - Show all commits

6
source/blender/blenkernel/BKE_node.h
View File

@ -508,12 +508,8 @@ struct bNode *ntreeFindType(struct bNodeTree *ntree, int type);
/**
* Check recursively whether a sub node tree contain in host tree.
mod_moder marked this conversation as resolved
Jacques Lucke commented 2023-02-10 13:03:40 +01:00
Review
Copy Link

Check recursively if a node tree contains another.

`Check recursively if a node tree contains another.`
*/
<<<<<<< HEAD
bool ntreeContainsTree(const bNodeTree *parent_tree, const bNodeTree *sub_tree);
== == == = bool ntreeContainsTree(const struct bNodeTree *parent_tree,
const struct bNodeTree *sub_tree);
bool ntreeContainsTree(const struct bNodeTree *parent_tree, const struct bNodeTree *sub_tree);
Jacques Lucke commented 2023-02-10 13:04:37 +01:00
Review
Copy Link

I think it would be better to use names like tree_to_search_in and tree_to_search_for. I find that the most clear.

I think it would be better to use names like `tree_to_search_in` and `tree_to_search_for`. I find that the most clear.
👍 1
Iliya Katushenock commented 2023-02-10 14:58:34 +01:00
Review
Copy Link

This only for backend part, or in python is too?
parm = RNA_def_pointer(func, "sub_tree", "NodeTree", "Node Tree", "Node tree for recursive check");

This only for backend part, or in python is too? `parm = RNA_def_pointer(func, "sub_tree", "NodeTree", "Node Tree", "Node tree for recursive check");`
>>>>>>> tree_contain_in
void ntreeUpdateAllNew(struct Main *main);
void ntreeUpdateAllUsers(struct Main *main, struct ID *id);