blender
/
blender
136
406
Fork 589
Code Issues 6.3k Pull Requests 766 Projects 19 Wiki Activity

Cleanup: Use utility function to find groups in node tree #104465

Merged
Hans Goudey merged 23 commits from mod_moder/blender:is_contains into main 2023-02-10 17:30:57 +01:00
Conversation 3 Commits 23 Files Changed 7 +2
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 1f3280745f - Show all commits

2
source/blender/blenkernel/intern/node.cc
View File

@ -3460,6 +3460,7 @@ bool ntreeContainsTree(const bNodeTree *parent_tree, const bNodeTree *sub_tree)
if (parent_tree == sub_tree) {
return true;
}
parent_tree->ensure_topology_cache();
mod_moder marked this conversation as resolved
Hans Goudey commented 2023-02-10 14:36:43 +01:00
Review
Copy Link

reinterpret_cast<bNodeTree *> -> reinterpret_cast<const bNodeTree *>

`reinterpret_cast<bNodeTree *>` -> `reinterpret_cast<const bNodeTree *>`
👀 1
for (const bNode *node_group : parent_tree->group_nodes()) {
const bNodeTree *tree = reinterpret_cast<bNodeTree *>(node_group->id);
@ -3467,6 +3468,7 @@ bool ntreeContainsTree(const bNodeTree *parent_tree, const bNodeTree *sub_tree)
return true;
}
}
return false;
}