blender
/
blender
136
406
Fork 589
Code Issues 6.3k Pull Requests 766 Projects 19 Wiki Activity

Cleanup: Use utility function to find groups in node tree #104465

Merged
Hans Goudey merged 23 commits from mod_moder/blender:is_contains into main 2023-02-10 17:30:57 +01:00
Conversation 3 Commits 23 Files Changed 7 +5 -2
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 7bdda03ed7 - Show all commits

7
source/blender/makesrna/intern/rna_nodetree.c
View File

@ -12723,8 +12723,11 @@ static void rna_def_nodetree(BlenderRNA *brna)
RNA_def_parameter_flags(parm, PROP_NEVER_NULL, PARM_REQUIRED);
func = RNA_def_function(srna, "contains_group", "rna_NodeTree_contains_group");
RNA_def_function_ui_description(func, "Check if the node tree contains another. Used to avoid creating recursive node groups");
parm = RNA_def_pointer(func, "sub_tree", "NodeTree", "Node Group", "Node group for recursive check");
RNA_def_function_ui_description(
func,
"Check if the node tree contains another. Used to avoid creating recursive node groups");
parm = RNA_def_pointer(
func, "sub_tree", "NodeTree", "Node Group", "Node group for recursive check");
RNA_def_parameter_flags(parm, PROP_NEVER_NULL, PARM_REQUIRED);
parm = RNA_def_property(func, "contained", PROP_BOOLEAN, PROP_NONE);
mod_moder marked this conversation as resolved
Jacques Lucke commented 2023-02-08 17:32:16 +01:00
Review
Copy Link

Currently this uses the term group and tree. While we generally use those terms synonymously, it would be better to be consistent within a single function declaration.

Currently this uses the term `group` and `tree`. While we generally use those terms synonymously, it would be better to be consistent within a single function declaration.
RNA_def_function_return(func, parm);